Playback of application/ogg blob media is broken

youennf · youennf · commit 6792010dc8f9 · 2025-12-16T11:21:00.000-08:00
rdar://163119790 https://bugs.webkit.org/show_bug.cgi?id=301509 Reviewed by Jean-Yves Avenard. When loading through blob, WebCoreAVFResourceLoader is used. `application/ogg` mime type does not lead to a valid UTI and AV player is not able to recover itself. Mime Sniffer is used but it will still return `application/ogg`. We update MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL to use `audio/ogg` in case `application/ogg` is the preferred mime type. We only do this for blob URLs and should follow-up for all URLs. We skip the test on iOS due to the lack of ogg support there. Test: http/wpt/media/blob-and-ogg.html Canonical link: https://commits.webkit.org/304530@main
diff --git a/LayoutTests/http/wpt/media/blob-and-ogg-expected.txt b/LayoutTests/http/wpt/media/blob-and-ogg-expected.txt
@@ -0,0 +1,8 @@
+
+
+PASS Playing audio/ogg with blobs should succeed
+PASS Playing application/ogg with blobs should succeed
+PASS Playing video/ogg with blobs should succeed
+PASS Playing bogus/ogg with blobs should succeed
+PASS Playing ogg without content type with blobs should succeed
+
diff --git a/LayoutTests/http/wpt/media/blob-and-ogg.html b/LayoutTests/http/wpt/media/blob-and-ogg.html
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+</head>
+<body>
+<audio controls muted id=audio></audio>
+<script>
+async function validateAudioPlayback(url)
+{
+    audio.src = url;
+    return audio.play();
+}
+
+async function doOggTest(test, contentType)
+{
+    const audioConfig = {
+      type: "file",
+      audio: {
+        contentType: 'audio/ogg; codecs="vorbis"',
+        channels: '2'
+      }
+    };
+    const result = await navigator.mediaCapabilities.decodingInfo(audioConfig);
+    if (!result.supported)
+        return;
+
+    const response = await fetch("resources/ogg-file.py?contentType=${contentType}");
+    const blob = await response.blob();
+    const blobUrl = URL.createObjectURL(blob);
+    test.add_cleanup(() => URL.revokeObjectURL(blobUrl));
+
+    return validateAudioPlayback(blobUrl);
+}
+
+promise_test(test => {
+    return doOggTest(test, "audio/ogg");
+}, "Playing audio/ogg with blobs should succeed");
+
+promise_test(test => {
+    return doOggTest(test, "application/ogg");
+}, "Playing application/ogg with blobs should succeed");
+
+promise_test(test => {
+   return doOggTest(test, "video/ogg");
+}, "Playing video/ogg with blobs should succeed");
+
+promise_test(test => {
+    return doOggTest(test, "bogus/ogg");
+}, "Playing bogus/ogg with blobs should succeed");
+
+promise_test(test => {
+    return doOggTest(test, "resources/ogg-file.py");
+}, "Playing ogg without content type with blobs should succeed");
+</script>
+</body>
+</html>
diff --git a/LayoutTests/http/wpt/media/resources/ogg-file.py b/LayoutTests/http/wpt/media/resources/ogg-file.py
@@ -0,0 +1,16 @@
+import os.path
+
+from wptserve.utils import isomorphic_decode
+
+def main(request, response):
+  contentType = request.GET.first(b"contentType", b"")
+  path = os.path.join(os.path.dirname(isomorphic_decode(__file__)), u"silence.ogg")
+  body = open(path, "rb").read()
+
+  response.add_required_headers = False
+  response.writer.write_status(200)
+  response.writer.write_header(b"content-length", len(body))
+  response.writer.write_header(b"content-type", path)
+  response.writer.end_headers()
+
+  response.writer.write(body)
diff --git a/LayoutTests/http/wpt/media/resources/silence.ogg b/LayoutTests/http/wpt/media/resources/silence.ogg
diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
@@ -298,6 +298,9 @@ webaudio/codec-tests/vorbis [ Skip ]
 webaudio/decode-audio-data-webm-vorbis.html [ Failure ]
 media/track/audio-track-configuration-webm.html
 
+# ogg not available in simulator
+http/wpt/media/blob-and-ogg.html [ Skip ]
+
 # No wheel events on iOS
 fast/events/wheel [ Skip ]
 fast/scrolling/iframe-scrollable-after-back.html [ Skip ]
diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
@@ -908,6 +908,10 @@ static URL conformFragmentIdentifierForURL(const URL& url)
     auto type = player->contentMIMEType();
 
     if (PAL::canLoad_AVFoundation_AVURLAssetOutOfBandMIMETypeKey() && !type.isEmpty() && !player->contentMIMETypeWasInferredFromExtension()) {
+        // FIXME: Remove that check once AVFoundation allows it (rdar://163119790). This should also not be restricted to blobs.
+        if (type == "application/ogg"_s && url.protocolIsBlob())
+            type = "audio/ogg"_s;
+
         auto codecs = player->contentTypeCodecs();
         if (!codecs.isEmpty()) {
             RetainPtr typeString = adoptNS([[NSString alloc] initWithFormat:@"%@; codecs=\"%@\"", type.createNSString().get(), codecs.createNSString().get()]);
