Skip to content

Commit 0c57767

Browse files
lilyspiniolaslilyspiniolas
committed
geforcenow.com: [macOS & iPadOS] The wrong values for are reported for the MouseEvent.button& MouseEvent.which property for extra mouse buttons.
https://bugs.webkit.org/show_bug.cgi?id=280755 rdar://137592588 Reviewed by Megan Gardner and Aditya Keerthi. Re-landing 5aee38f with an added build fix. `MouseEvent.button` and `MouseEvent.which` now return the correct values for mouse events occuring as a result of a fourth or fifth mouse button being pressed. Thanks to Abrar Protyasha for starting this patch, and for the work in 289800@main which is re-landed here as the foundation for these changes. `MouseEvent.button` and `MouseEvent.which` now return the correct value when the wheel button is clicked on iOS (macOS already supported this button). Tested by `fast/events/mouse-event-buttons.html` on non-iOS platforms, and tested on iOS by new API test `iOSMouseSupport.NonPrimaryMouseButtonsForEvents`. Added an extra, unrelated test `iOSMouseSupport.LeftClickFiresPointerAndMouseEvents` to increase test comprehensiveness for iOS mouse support. Link WebKitTestRunner against JavaScriptCore on iOS and visionOS to resolve a build failure that occurs for debug builds. Tests: fast/events/mouse-event-buttons.html Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm * LayoutTests/fast/events/fire-mousedown-while-pressing-mouse-button.html: * LayoutTests/fast/events/mouse-click-events-expected.txt: * LayoutTests/fast/events/mouse-click-events.html: * LayoutTests/fast/events/mouse-event-buttons-expected.txt: Added. * LayoutTests/fast/events/mouse-event-buttons.html: Added. * LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_mouse-right-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_mouse-right-nonstandard-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_pen-right-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_pen-right-nonstandard-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_on_chorded_mouse_button.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/uievents/mouse/synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative_buttonType=MIDDLE&button=1&buttons=4-expected.txt: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/fast/events/mouse-event-buttons-expected.txt: Added. * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/uievents/mouse/synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative_buttonType=MIDDLE&button=1&buttons=4-expected.txt: * LayoutTests/platform/win/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/dom/MouseEvent.cpp: (WebCore::MouseEvent::button const): * Source/WebCore/dom/MouseEventTypes.h: (WebCore::buttonFromShort): (WebCore::nsEventButtonNumberFromWebCoreMouseButton): * Source/WebCore/platform/mac/PlatformEventFactoryMac.mm: (WebCore::currentMouseButton): (WebCore::buttonFromButtonNumber): (WebCore::mouseButtonForEvent): * Source/WebKit/Shared/API/c/WKEvent.h: * Source/WebKit/Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): * Source/WebKit/Shared/WebEvent.serialization.in: * Source/WebKit/Shared/WebEventConversion.cpp: (WebKit::platform): (WebKit::kit): * Source/WebKit/Shared/WebMouseEvent.h: * Source/WebKit/Shared/ios/AdditionalButtonMasksIOS.h: Added. * Source/WebKit/Shared/ios/WebIOSEventFactory.mm: (WebKit::WebIOSEventFactory::toUIEventButtonMask): * Source/WebKit/Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::toNSButtonNumber): * Source/WebKit/UIProcess/API/glib/WebKitPrivate.cpp: (toWebKitMouseButton): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (MotionEvent::setState): (webkitWebViewBaseSynthesizeMouseEvent): * Source/WebKit/UIProcess/Automation/Automation.json: * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::WebAutomationSession): * Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::mouseButtonToGdkButton): * Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp: (WebKit::mouseButtonToWPEButton): (WebKit::stateModifierForWPEButton): * Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp: (WebKit::libWPEMouseButtonToWPEButton): * Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::sendSynthesizedEventsToPage): (WebKit::WebAutomationSession::platformSimulateMouseInteraction): * Source/WebKit/UIProcess/ios/WKMouseInteraction.mm: (-[WKMouseInteraction createMouseEventWithType:wasCancelled:]): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * Tools/DumpRenderTree/mac/EventSendingController.h: * Tools/DumpRenderTree/mac/EventSendingController.mm: (eventTypeForMouseButtonAndAction): (swizzledEventPressedMouseButtons): (swizzledEventButtonNumber): (-[EventSendingController mouseDown:withModifiers:]): (-[EventSendingController mouseUp:withModifiers:]): (-[EventSendingController contextClick]): * Tools/TestWebKitAPI/Configurations/Base.xcconfig: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: (-[TestWKWebView pointerInfoAtLocation:]): ((iOSMouseSupport, TrackButtonMaskFromTouchStart)): ((iOSMouseSupport, MouseTimestampTimebase)): ((iOSMouseSupport, EndedTouchesTriggerClick)): ((iOSMouseSupport, CancelledTouchesDoNotTriggerClick)): ((iOSMouseSupport, MouseDidMoveOverElement)): ((iOSMouseSupport, SelectionUpdatesBeforeContextMenuAppears)): ((iOSMouseSupport, DisablingTextIteractionPreventsSelectionWhenShowingContextMenu)): ((iOSMouseSupport, ShowingContextMenuSelectsEditableText)): ((iOSMouseSupport, ShowingContextMenuSelectsNonEditableText)): ((iOSMouseSupport, ContextClickAtEndOfSelection)): ((iOSMouseSupport, WebsiteMouseEventPolicies)): ((iOSMouseSupport, MouseInitiallyDisconnected)): ((iOSMouseSupport, MouseInitiallyConnected)): ((iOSMouseSupport, MouseLaterDisconnected)): ((iOSMouseSupport, MouseLaterConnected)): ((iOSMouseSupport, MouseAlwaysConnected)): ((iOSMouseSupport, BasicPointerInteractionRegions)): ((iOSMouseSupport, LeftClickFiresPointerAndMouseEvents)): ((iOSMouseSupport, NonPrimaryMouseButtonsForEvents)): * Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::buildAndPerformTest): * Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::eventTypeForButton): (TestWebKitAPI::PlatformWebView::simulateButtonClick): * Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: * Tools/WebKitTestRunner/EventSenderProxy.h: (WTR::EventSenderProxy::lastButtonDown const): (WTR::EventSenderProxy::mouseButtonsCurrentlyDown const): Deleted. * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * Tools/WebKitTestRunner/cocoa/EventSenderProxyCocoa.mm: Copied from Source/WebKit/Shared/API/c/WKEvent.h. (WTR::EventSenderProxy::mouseButtonsCurrentlyDown const): * Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::eventSenderButtonToGDKButton): (WTR::stateModifierForGdkButton): * Tools/WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::eventTypeForMouseButtonAndAction): (WTR::EventSenderProxy::EventSenderProxy): (WTR::swizzledEventButtonNumber): (WTR::EventSenderProxy::mouseDown): (WTR::EventSenderProxy::mouseUp): (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents): (): Deleted. Canonical link: https://commits.webkit.org/304761@main
1 parent f8fe1f3 commit 0c57767

File tree

51 files changed

+757
-155
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+757
-155
lines changed

‎LayoutTests/fast/events/fire-mousedown-while-pressing-mouse-button.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@
5454
switch (w3cButton) {
5555
case LeftMouseButton:
5656
return 1 << 0;
57-
case MiddleMouseButton:
58-
return 1 << 1;
5957
case RightMouseButton:
58+
return 1 << 1;
59+
case MiddleMouseButton:
6060
return 1 << 2;
6161
}
6262
return; // We shouldn't get here.

‎LayoutTests/fast/events/mouse-click-events-expected.txt‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ PASS successfullyParsed is true
77

88
TEST COMPLETE
99
Left Mouse Button
10-
PASS eventLog is "mousedown(0) mouseup(0) click(0) mousedown(0) mouseup(0) click(0) dblclick(0) "
10+
PASS eventLog is "mousedown(button: 0 which: 1) mouseup(button: 0 which: 1) click(button: 0 which: 1) mousedown(button: 0 which: 1) mouseup(button: 0 which: 1) click(button: 0 which: 1) dblclick(button: 0 which: 1) "
1111
Middle Mouse Button
12-
PASS eventLog is "mousedown(1) mouseup(1) auxclick(1) mousedown(1) mouseup(1) auxclick(1) "
12+
PASS eventLog is "mousedown(button: 1 which: 2) mouseup(button: 1 which: 2) auxclick(button: 1 which: 2) mousedown(button: 1 which: 2) mouseup(button: 1 which: 2) auxclick(button: 1 which: 2) "
1313
Right Mouse Button
14-
PASS eventLog is "mousedown(2) mouseup(2) auxclick(2) mousedown(2) mouseup(2) auxclick(2) "
15-
4th Mouse Button
16-
PASS eventLog is "mousedown(1) mouseup(1) auxclick(1) mousedown(1) mouseup(1) auxclick(1) "
14+
PASS eventLog is "mousedown(button: 2 which: 3) mouseup(button: 2 which: 3) auxclick(button: 2 which: 3) mousedown(button: 2 which: 3) mouseup(button: 2 which: 3) auxclick(button: 2 which: 3) "
15+
Back Mouse Button
16+
PASS eventLog is "mousedown(button: 3 which: 4) mouseup(button: 3 which: 4) auxclick(button: 3 which: 4) mousedown(button: 3 which: 4) mouseup(button: 3 which: 4) auxclick(button: 3 which: 4) "
17+
Forward Mouse Button
18+
PASS eventLog is "mousedown(button: 4 which: 5) mouseup(button: 4 which: 5) auxclick(button: 4 which: 5) mousedown(button: 4 which: 5) mouseup(button: 4 which: 5) auxclick(button: 4 which: 5) "
1719

‎LayoutTests/fast/events/mouse-click-events.html‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
function appendEventLog() {
1818
if (window.eventSender) {
19-
eventLog += event.type + "(" + event.button + ") ";
19+
eventLog += event.type + "(button: " + event.button + " which: " + event.which + ") ";
2020
} else {
21-
debug(event.type + "(" + event.button + ")");
21+
debug(event.type + "(button: " + event.button + " which: " + event.which + ")");
2222
}
2323
}
2424

@@ -68,10 +68,11 @@
6868

6969
if (window.eventSender) {
7070
await eventSender.asyncMouseMoveTo(10, 10);
71-
await testEvents("Left Mouse Button", 0, "mousedown(0) mouseup(0) click(0) mousedown(0) mouseup(0) click(0) dblclick(0) ");
72-
await testEvents("Middle Mouse Button", 1, "mousedown(1) mouseup(1) auxclick(1) mousedown(1) mouseup(1) auxclick(1) ");
73-
await testEvents("Right Mouse Button", 2, "mousedown(2) mouseup(2) auxclick(2) mousedown(2) mouseup(2) auxclick(2) ");
74-
await testEvents("4th Mouse Button", 3, "mousedown(1) mouseup(1) auxclick(1) mousedown(1) mouseup(1) auxclick(1) ");
71+
await testEvents("Left Mouse Button", 0, "mousedown(button: 0 which: 1) mouseup(button: 0 which: 1) click(button: 0 which: 1) mousedown(button: 0 which: 1) mouseup(button: 0 which: 1) click(button: 0 which: 1) dblclick(button: 0 which: 1) ");
72+
await testEvents("Middle Mouse Button", 1, "mousedown(button: 1 which: 2) mouseup(button: 1 which: 2) auxclick(button: 1 which: 2) mousedown(button: 1 which: 2) mouseup(button: 1 which: 2) auxclick(button: 1 which: 2) ");
73+
await testEvents("Right Mouse Button", 2, "mousedown(button: 2 which: 3) mouseup(button: 2 which: 3) auxclick(button: 2 which: 3) mousedown(button: 2 which: 3) mouseup(button: 2 which: 3) auxclick(button: 2 which: 3) ");
74+
await testEvents("Back Mouse Button", 3, "mousedown(button: 3 which: 4) mouseup(button: 3 which: 4) auxclick(button: 3 which: 4) mousedown(button: 3 which: 4) mouseup(button: 3 which: 4) auxclick(button: 3 which: 4) ");
75+
await testEvents("Forward Mouse Button", 4, "mousedown(button: 4 which: 5) mouseup(button: 4 which: 5) auxclick(button: 4 which: 5) mousedown(button: 4 which: 5) mouseup(button: 4 which: 5) auxclick(button: 4 which: 5) ");
7576
}
7677
testRunner?.notifyDone();
7778
}

‎LayoutTests/fast/events/mouse-event-buttons-expected.txt‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
This tests the `buttons` property for mouse events we send.
2+
3+
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
4+
5+
6+
PASS successfullyParsed is true
7+
8+
TEST COMPLETE
9+
Left Mouse Button
10+
PASS eventLog is "mousedown(1) mouseup(0) click(0) mousedown(1) mouseup(0) click(0) dblclick(0) "
11+
Middle Mouse Button
12+
PASS eventLog is "mousedown(4) mouseup(0) auxclick(0) mousedown(4) mouseup(0) auxclick(0) "
13+
Right Mouse Button
14+
PASS eventLog is "mousedown(2) mouseup(0) auxclick(0) mousedown(2) mouseup(0) auxclick(0) "
15+
Back Mouse Button
16+
PASS eventLog is "mousedown(8) mouseup(0) auxclick(0) mousedown(8) mouseup(0) auxclick(0) "
17+
Forward Mouse Button
18+
PASS eventLog is "mousedown(16) mouseup(0) auxclick(0) mousedown(16) mouseup(0) auxclick(0) "
19+
Left and Right Mouse Buttons
20+
PASS eventLog is "mousedown(1) mousedown(3) mouseup(1) auxclick(1) mouseup(0) "
21+
Left, Right, and Middle Mouse Buttons
22+
PASS eventLog is "mousedown(1) mousedown(3) mousedown(7) mouseup(3) auxclick(3) mouseup(1) mouseup(0) "
23+
Left, Right, Middle, Back, and Forward Mouse Buttons
24+
PASS eventLog is "mousedown(1) mousedown(3) mousedown(7) mousedown(15) mousedown(31) mouseup(15) auxclick(15) mouseup(7) mouseup(3) mouseup(1) mouseup(0) "
25+

‎LayoutTests/fast/events/mouse-event-buttons.html‎

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
2+
<html>
3+
<head>
4+
<script src="../../resources/js-test.js"></script>
5+
</head>
6+
<body>
7+
<script>
8+
description("This tests the `buttons` property for mouse events we send.");
9+
10+
var div = document.createElement("div");
11+
div.style.width = "100px";
12+
div.style.height = "100px";
13+
div.style.backgroundColor = "blue";
14+
15+
var eventLog = "";
16+
17+
function appendEventLog() {
18+
if (window.eventSender) {
19+
eventLog += event.type + "(" + event.buttons + ") ";
20+
} else {
21+
debug(event.type + "(" + event.buttons + ")");
22+
}
23+
}
24+
25+
function clearEventLog() {
26+
eventLog = "";
27+
}
28+
29+
function dismissContextMenu() {
30+
if (window.eventSender) {
31+
// esc key to kill the context menu.
32+
eventSender.keyDown(String.fromCharCode(0x001B), null);
33+
}
34+
}
35+
36+
async function sendEvents(button) {
37+
if (!window.eventSender) {
38+
debug("This test requires WebKitTestRunner. Click on the blue rect with different mouse buttons to log.")
39+
return;
40+
}
41+
await eventSender.asyncMouseDown(button);
42+
if (button == 2)
43+
dismissContextMenu();
44+
await eventSender.asyncMouseUp(button);
45+
await eventSender.asyncMouseDown(button);
46+
if (button == 2)
47+
dismissContextMenu();
48+
await eventSender.asyncMouseUp(button);
49+
// could test dragging here too
50+
}
51+
52+
async function sendChordedEvents(buttons) {
53+
if (!window.eventSender) {
54+
debug("This test requires WebKitTestRunner. Click on the blue rect with different mouse buttons to log.")
55+
return;
56+
}
57+
58+
for (const button of buttons) {
59+
await eventSender.asyncMouseDown(button);
60+
if (button == 2)
61+
dismissContextMenu();
62+
}
63+
64+
for (const button of [...buttons].reverse())
65+
await eventSender.asyncMouseUp(button);
66+
}
67+
68+
async function testEvents(description, button, expectedString) {
69+
debug(description);
70+
await sendEvents(button);
71+
shouldBeEqualToString("eventLog", expectedString);
72+
clearEventLog();
73+
}
74+
75+
async function testChordedEvents(description, buttons, expectedString) {
76+
debug(description);
77+
await sendChordedEvents(buttons);
78+
shouldBeEqualToString("eventLog", expectedString);
79+
clearEventLog();
80+
}
81+
82+
onload = async () => {
83+
testRunner?.waitUntilDone();
84+
85+
div.addEventListener("auxclick", appendEventLog, false);
86+
div.addEventListener("click", appendEventLog, false);
87+
div.addEventListener("dblclick", appendEventLog, false);
88+
div.addEventListener("mousedown", appendEventLog, false);
89+
div.addEventListener("mouseup", appendEventLog, false);
90+
document.body.insertBefore(div, document.body.firstChild);
91+
92+
if (window.eventSender) {
93+
await eventSender.asyncMouseMoveTo(10, 10);
94+
await testEvents("Left Mouse Button", 0, "mousedown(1) mouseup(0) click(0) mousedown(1) mouseup(0) click(0) dblclick(0) ");
95+
await testEvents("Middle Mouse Button", 1, "mousedown(4) mouseup(0) auxclick(0) mousedown(4) mouseup(0) auxclick(0) ");
96+
await testEvents("Right Mouse Button", 2, "mousedown(2) mouseup(0) auxclick(0) mousedown(2) mouseup(0) auxclick(0) ");
97+
await testEvents("Back Mouse Button", 3, "mousedown(8) mouseup(0) auxclick(0) mousedown(8) mouseup(0) auxclick(0) ");
98+
await testEvents("Forward Mouse Button", 4, "mousedown(16) mouseup(0) auxclick(0) mousedown(16) mouseup(0) auxclick(0) ");
99+
await testChordedEvents("Left and Right Mouse Buttons", [0, 2], "mousedown(1) mousedown(3) mouseup(1) auxclick(1) mouseup(0) ");
100+
await testChordedEvents("Left, Right, and Middle Mouse Buttons", [0, 2, 1], "mousedown(1) mousedown(3) mousedown(7) mouseup(3) auxclick(3) mouseup(1) mouseup(0) ");
101+
await testChordedEvents("Left, Right, Middle, Back, and Forward Mouse Buttons", [0, 2, 1, 3, 4], "mousedown(1) mousedown(3) mousedown(7) mousedown(15) mousedown(31) mouseup(15) auxclick(15) mouseup(7) mouseup(3) mouseup(1) mouseup(0) ");
102+
}
103+
testRunner?.notifyDone();
104+
}
105+
</script>
106+
</body>
107+
</html>

‎LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_mouse-right-expected.txt‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ done
33

44
Harness Error (FAIL), message = Unhandled rejection: assert_unreached: missing pointermove event Reached unreachable code
55

6-
FAIL Test pointer events in the main document assert_equals: Buttons attribute on pointerdown expected 2 but got 4
6+
PASS Test pointer events in the main document
77
FAIL Test pointer events in an iframe assert_unreached: missing pointerover event Reached unreachable code
88
PASS mouse pointerover event is a PointerEvent event
99
PASS mouse pointerover.isTrusted value is true
@@ -26,6 +26,13 @@ PASS mouse pointermove.bubbles value is valid
2626
PASS mouse pointermove.cancelable value is valid
2727
PASS mouse pointermove.pressure value is valid
2828
PASS mouse pointermove properties for pointerType = mouse
29+
PASS mouse pointerdown event is a PointerEvent event
30+
PASS mouse pointerdown.isTrusted value is true
31+
PASS mouse pointerdown.composed value is valid
32+
PASS mouse pointerdown.bubbles value is valid
33+
PASS mouse pointerdown.cancelable value is valid
34+
PASS mouse pointerdown.pressure value is valid
35+
PASS mouse pointerdown properties for pointerType = mouse
2936
PASS mouse pointerup event is a PointerEvent event
3037
PASS mouse pointerup.isTrusted value is true
3138
PASS mouse pointerup.composed value is valid

‎LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_mouse-right-nonstandard-expected.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@ done
33

44
Harness Error (FAIL), message = Unhandled rejection: assert_unreached: missing pointermove event Reached unreachable code
55

6-
FAIL Test pointer events in the main document assert_equals: Buttons attribute on pointerdown expected 2 but got 4
6+
PASS Test pointer events in the main document
77
FAIL Test pointer events in an iframe assert_unreached: missing pointerover event Reached unreachable code
88
PASS mouse pointerover.fromElement value is null
99
PASS mouse pointerover.toElement value is null
1010
PASS mouse pointerenter.fromElement value is null
1111
PASS mouse pointerenter.toElement value is null
1212
PASS mouse pointermove.fromElement value is null
1313
PASS mouse pointermove.toElement value is null
14+
PASS mouse pointerdown.fromElement value is null
15+
PASS mouse pointerdown.toElement value is null
1416
PASS mouse pointerup.fromElement value is null
1517
PASS mouse pointerup.toElement value is null
1618
PASS mouse pointerout.fromElement value is null

‎LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_pen-right-expected.txt‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ done
33

44
Harness Error (FAIL), message = Unhandled rejection: assert_unreached: missing pointermove event Reached unreachable code
55

6-
FAIL Test pointer events in the main document assert_equals: Buttons attribute on pointerdown expected 2 but got 4
6+
PASS Test pointer events in the main document
77
FAIL Test pointer events in an iframe assert_unreached: missing pointerover event Reached unreachable code
88
PASS mouse pointerover event is a PointerEvent event
99
PASS mouse pointerover.isTrusted value is true
@@ -26,6 +26,13 @@ PASS mouse pointermove.bubbles value is valid
2626
PASS mouse pointermove.cancelable value is valid
2727
PASS mouse pointermove.pressure value is valid
2828
PASS mouse pointermove properties for pointerType = mouse
29+
PASS mouse pointerdown event is a PointerEvent event
30+
PASS mouse pointerdown.isTrusted value is true
31+
PASS mouse pointerdown.composed value is valid
32+
PASS mouse pointerdown.bubbles value is valid
33+
PASS mouse pointerdown.cancelable value is valid
34+
PASS mouse pointerdown.pressure value is valid
35+
PASS mouse pointerdown properties for pointerType = mouse
2936
PASS mouse pointerup event is a PointerEvent event
3037
PASS mouse pointerup.isTrusted value is true
3138
PASS mouse pointerup.composed value is valid

‎LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_pen-right-nonstandard-expected.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@ done
33

44
Harness Error (FAIL), message = Unhandled rejection: assert_unreached: missing pointermove event Reached unreachable code
55

6-
FAIL Test pointer events in the main document assert_equals: Buttons attribute on pointerdown expected 2 but got 4
6+
PASS Test pointer events in the main document
77
FAIL Test pointer events in an iframe assert_unreached: missing pointerover event Reached unreachable code
88
PASS mouse pointerover.fromElement value is null
99
PASS mouse pointerover.toElement value is null
1010
PASS mouse pointerenter.fromElement value is null
1111
PASS mouse pointerenter.toElement value is null
1212
PASS mouse pointermove.fromElement value is null
1313
PASS mouse pointermove.toElement value is null
14+
PASS mouse pointerdown.fromElement value is null
15+
PASS mouse pointerdown.toElement value is null
1416
PASS mouse pointerup.fromElement value is null
1517
PASS mouse pointerup.toElement value is null
1618
PASS mouse pointerout.fromElement value is null

‎LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_on_chorded_mouse_button.tentative-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11

22
FAIL Chorded button sequence L-down M-down M-up L-up assert_equals: received click-like events expected "{type: auxclick, button: 1, buttons: 1},{type: click, button: 0, buttons: 0}" but got "{type: auxclick, button: 1, buttons: 1}"
3-
FAIL Chorded button sequence M-down L-down L-up M-up assert_equals: received click-like events expected "{type: click, button: 0, buttons: 4},{type: auxclick, button: 1, buttons: 0}" but got "{type: click, button: 0, buttons: 2}"
3+
FAIL Chorded button sequence M-down L-down L-up M-up assert_equals: received click-like events expected "{type: click, button: 0, buttons: 4},{type: auxclick, button: 1, buttons: 0}" but got "{type: click, button: 0, buttons: 4}"
44

0 commit comments

Comments
 (0)