Web Inspector: remove trailing ".0" for timestamps

stwrt · stwrt · commit b4456ac914a1 · 2025-12-21T23:01:31.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=191122 rdar://problem/166500013 Reviewed by Devin Rousso. Strip trailing zeros from integer duration values to improve readability. For example, "1.00ms" now displays as "1ms". This is achieved by adding `trailingZeroDisplay: "stripIfInteger"` to the `toLocaleString` options in `String.standardFormatters`, which handles this in a locale-aware manner. * LayoutTests/inspector/unit-tests/number-utilities.html: * Source/WebInspectorUI/UserInterface/Base/Utilities.js: (value.f): * Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js: (WI.FontDetailsPanel.prototype._formatAxisValueAsString): * Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js: (WI.FontVariationDetailsSectionRow.prototype._formatAxisValueAsString): Canonical link: https://commits.webkit.org/304851@main
diff --git a/LayoutTests/inspector/unit-tests/number-utilities.html b/LayoutTests/inspector/unit-tests/number-utilities.html
@@ -42,7 +42,7 @@
             InspectorTest.expectEqual(Number.secondsToString(0.123456, false), "123ms", "normal resolution of greater than 100ms but sub 1s should be ms");
             InspectorTest.expectEqual(Number.secondsToString(1.123456, false), "1.12s", "normal resolution of greater than 1s but sub 1min should be seconds");
             InspectorTest.expectEqual(Number.secondsToString(30.123456, false), "30.12s", "normal resolution of greater than 1s but sub 1min should be seconds");
-            InspectorTest.expectEqual(Number.secondsToString(60.123456, false), "1.0min", "normal resolution of greater than 1min but sub 1hr should be minutes");
+            InspectorTest.expectEqual(Number.secondsToString(60.123456, false), "1min", "normal resolution of greater than 1min but sub 1hr should be minutes");
             InspectorTest.expectEqual(Number.secondsToString(100.123456, false), "1.7min", "normal resolution of greater than 1min but sub 1hr should be minutes");
             InspectorTest.expectEqual(Number.secondsToString(12345, false), "3.4hrs", "normal resolution of greater than 1hr but sub 1 day should be hrs");
             InspectorTest.expectEqual(Number.secondsToString(123456, false), "1.4 days", "normal resolution of greater than 1 day should be days");
diff --git a/Source/WebInspectorUI/UserInterface/Base/Utilities.js b/Source/WebInspectorUI/UserInterface/Base/Utilities.js
@@ -1158,7 +1158,8 @@ Object.defineProperty(String, "standardFormatters",
             let options = {
                 minimumFractionDigits: token.precision,
                 maximumFractionDigits: token.precision,
-                useGrouping: false
+                useGrouping: false,
+                trailingZeroDisplay: "stripIfInteger",
             };
             return value.toLocaleString(undefined, options);
         },
@@ -1321,7 +1322,7 @@ Object.defineProperty(Number, "percentageString",
 {
     value(fraction, precision = 1)
     {
-        return fraction.toLocaleString(undefined, {minimumFractionDigits: precision, style: "percent"});
+        return fraction.toLocaleString(undefined, {minimumFractionDigits: precision, style: "percent", trailingZeroDisplay: "stripIfInteger"});
     }
 });
 
diff --git a/Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js b/Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js
@@ -297,7 +297,8 @@ WI.FontDetailsPanel = class FontDetailsPanel extends WI.StyleDetailsPanel
             minimumFractionDigits: 0,
             maximumFractionDigits: 2,
             useGrouping: false,
-        }
+            trailingZeroDisplay: "stripIfInteger",
+        };
         return value.toLocaleString(undefined, options);
     }
 
diff --git a/Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js b/Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js
@@ -141,7 +141,8 @@ WI.FontVariationDetailsSectionRow = class FontVariationDetailsSectionRow extends
             minimumFractionDigits: 0,
             maximumFractionDigits: 2,
             useGrouping: false,
-        }
+            trailingZeroDisplay: "stripIfInteger",
+        };
         return value.toLocaleString(undefined, options);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1158,7 +1158,8 @@ Object.defineProperty(String, "standardFormatters",`
`1158`	`1158`	`let options = {`
`1159`	`1159`	`minimumFractionDigits: token.precision,`
`1160`	`1160`	`maximumFractionDigits: token.precision,`
`1161`		`- useGrouping: false`
	`1161`	`+ useGrouping: false,`
	`1162`	`+ trailingZeroDisplay: "stripIfInteger",`
`1162`	`1163`	`};`
`1163`	`1164`	`return value.toLocaleString(undefined, options);`
`1164`	`1165`	`},`
`@@ -1321,7 +1322,7 @@ Object.defineProperty(Number, "percentageString",`
`1321`	`1322`	`{`
`1322`	`1323`	`value(fraction, precision = 1)`
`1323`	`1324`	`{`
`1324`		`- return fraction.toLocaleString(undefined, {minimumFractionDigits: precision, style: "percent"});`
	`1325`	`+ return fraction.toLocaleString(undefined, {minimumFractionDigits: precision, style: "percent", trailingZeroDisplay: "stripIfInteger"});`
`1325`	`1326`	`}`
`1326`	`1327`	`});`
`1327`	`1328`
Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,8 @@ WI.FontDetailsPanel = class FontDetailsPanel extends WI.StyleDetailsPanel`
`297`	`297`	`minimumFractionDigits: 0,`
`298`	`298`	`maximumFractionDigits: 2,`
`299`	`299`	`useGrouping: false,`
`300`		`- }`
	`300`	`+ trailingZeroDisplay: "stripIfInteger",`
	`301`	`+ };`
`301`	`302`	`return value.toLocaleString(undefined, options);`
`302`	`303`	`}`
`303`	`304`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,8 @@ WI.FontVariationDetailsSectionRow = class FontVariationDetailsSectionRow extends`
`141`	`141`	`minimumFractionDigits: 0,`
`142`	`142`	`maximumFractionDigits: 2,`
`143`	`143`	`useGrouping: false,`
`144`		`- }`
	`144`	`+ trailingZeroDisplay: "stripIfInteger",`
	`145`	`+ };`
`145`	`146`	`return value.toLocaleString(undefined, options);`
`146`	`147`	`}`
`147`	`148`