[blocks-in-inline] getClientRects is missing an entry when called on an inline box

alanbaradlay · alanbaradlay · commit 8a9a5a9f8b7a · 2025-12-26T08:25:17.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=304665 Reviewed by Antti Koivisto. A single block inside inline (<span><div></div></span>) generates 3 "lines" and getClientRects is supposed to return all of them. However due to ignoring 0px width (non-leading) inline boxes in collectInlineBoxRects, we only return 2 (the first, leading (0px tall) line and the one generated by the block). Having all lines included makes block-in-inline-client-rects-001.html fail but we already render such content incorrectly on trunk. <div> <span style="outline: 1px solid green"> <div style="width: 500px"></div> </span> </div> There should _not_ be a green line here. * LayoutTests/TestExpectations: * LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry-expected.txt: Added. * LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry.html: Added. * LayoutTests/fast/inline/blocks-in-inline-client-rects-expected.txt: Removed. : this is a copy of block-in-inline-client-rects-001.html * LayoutTests/fast/inline/blocks-in-inline-client-rects.html: Removed. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::collectInlineBoxRects const): Canonical link: https://commits.webkit.org/304949@main
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
@@ -8184,6 +8184,10 @@ imported/w3c/web-platform-tests/css/css-viewport/zoom/border.html [ ImageOnlyFai
 # RenderTreeNeedsLayoutChecker hits.
 webkit.org/b/304002 [ Debug ] fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html [ Skip ]
 
+# This already fails visually as we stretch the inline box to the size of the containing block (in inline direction)
+# as opposed to the size of the content.
+webkit.org/b/304666 imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-in-inline-client-rects-001.html [ Failure ]
+
 # Digital Credentials API tests failing due to lack of implementation
 webkit.org/b/303807 imported/w3c/web-platform-tests/digital-credentials/allow-attribute-with-create.https.html [ Skip ]
 webkit.org/b/303807 imported/w3c/web-platform-tests/digital-credentials/create-enabled-on-self-origin-by-permissions-policy.https.sub.html [ Skip ]
diff --git a/LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry-expected.txt b/LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry-expected.txt
@@ -0,0 +1,4 @@
+ 0 0 0 0
+0 0 50 50
+0 50 0 0
+
diff --git a/LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry.html b/LayoutTests/fast/block/inside-inlines/getClientRects-on-inline-box-missing-entry.html
@@ -0,0 +1,23 @@
+<style>
+body {
+  margin: 0px;
+}
+.container {
+  width: 50px;
+}
+
+.block-in-inline {
+  height: 50px;
+}
+</style>
+<div class=container>
+  <span id=target>
+    <div class=block-in-inline></div>
+  </span>
+</div>
+<pre id=log></pre>
+<script>
+window.testRunner?.dumpAsText();
+for (const rect of target.getClientRects())
+  log.textContent += rect.x + " " + rect.y + " " + rect.width + " " + rect.height + "\n";
+</script>
diff --git a/LayoutTests/fast/inline/blocks-in-inline-client-rects-expected.txt b/LayoutTests/fast/inline/blocks-in-inline-client-rects-expected.txt
diff --git a/LayoutTests/fast/inline/blocks-in-inline-client-rects.html b/LayoutTests/fast/inline/blocks-in-inline-client-rects.html
diff --git a/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp b/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
@@ -1151,9 +1151,7 @@ Vector<FloatRect> LineLayout::collectInlineBoxRects(const RenderInline& renderIn
 
     Vector<FloatRect> result;
     m_inlineContent->traverseNonRootInlineBoxes(layoutBox, [&](auto& inlineBox) {
-        auto rect = inlineBox.visualRectIgnoringBlockDirection();
-        if (result.isEmpty() || !rect.isEmpty())
-            result.append(rect);
+        result.append(inlineBox.visualRectIgnoringBlockDirection());
     });
     return result;
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 + 0 0 0 0
 +0 0 50 50
 +0 50 0 0
++