Skip to content

Commit ce23da4

Browse files
beidsonbeidson
committed
window.<blank>bar.visible should be based on the "is popup" flag of the window, and not the real UI values
rdar://166554327 https://bugs.webkit.org/show_bug.cgi?id=306442 Reviewed by Alex Christensen and Anne van Kesteren. There exists the following accessors in JavaScript: window.locationbar.visible window.menubar.visible window.personalbar.visible window.scrollbars.visible window.statusbar.visible window.toolbar.visible These properties were meant to give JavaScript information about the decorations of the browser window that surround the web content itself. For decades, WebKit has attempted to report the accurate values for those properties by allowing the client (e.g. Safari) to keep the values updated. However the spec changed to account for privacy and interop in the modern web. https://html.spec.whatwg.org/multipage/nav-history-apis.html#browser-interface-elements This patch changes the behavior of these accessors in WebCore such that they solely report based on the "is popup" flag, and completely ignore the actual visibility of the browser interface elements. When reporting "real" values, WebKit relied on the embedding app to keep the values up to date via UI delegate methods or property setters on `WKWebView`. Since WebKit can do the "is popup" calculation itself, those methods are no longer needed. This patch removes them and/or makes them a no-op for bin-compat. No new tests - Covered by changes to existing test expectations, and removed a now irrelevant API test. * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_combination-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_position-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_single-1-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_single-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-popup-behavior-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/loader/EmptyClients.h: * Source/WebCore/page/BarProp.cpp: (WebCore::BarProp::BarProp): (WebCore::BarProp::visible const): * Source/WebCore/page/BarProp.h: * Source/WebCore/page/Chrome.cpp: (WebCore::Chrome::isPopup const): (WebCore::Chrome::toolbarsVisible const): Deleted. (WebCore::Chrome::statusbarVisible const): Deleted. (WebCore::Chrome::scrollbarsVisible const): Deleted. (WebCore::Chrome::menubarVisible const): Deleted. * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::locationbar): (WebCore::LocalDOMWindow::menubar): (WebCore::LocalDOMWindow::personalbar): (WebCore::LocalDOMWindow::scrollbars): (WebCore::LocalDOMWindow::statusbar): (WebCore::LocalDOMWindow::toolbar): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParameters.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setStatusBarIsVisible:]): (-[WKWebView _statusBarIsVisible]): (-[WKWebView _setMenuBarIsVisible:]): (-[WKWebView _menuBarIsVisible]): (-[WKWebView _setToolbarsAreVisible:]): (-[WKWebView _toolbarsAreVisible]): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::m_pageForTesting): (WebKit::WebPageProxy::creationParameters): (WebKit::m_statusBarIsVisible): Deleted. (WebKit::m_menuBarIsVisible): Deleted. (WebKit::m_toolbarsAreVisible): Deleted. (WebKit::WebPageProxy::setToolbarsAreVisible): Deleted. (WebKit::WebPageProxy::setMenuBarIsVisible): Deleted. (WebKit::WebPageProxy::setStatusBarIsVisible): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow): (WebKit::WebChromeClient::isPopup const): (WebKit::WebChromeClient::toolbarsVisible const): Deleted. (WebKit::WebChromeClient::statusbarVisible const): Deleted. (WebKit::WebChromeClient::scrollbarsVisible const): Deleted. (WebKit::WebChromeClient::menubarVisible const): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_isPopup): (WebKit::m_backgroundTextExtractionEnabled): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::isPopup const): (WebChromeClient::setToolbarsVisible): Deleted. (WebChromeClient::toolbarsVisible const): Deleted. (WebChromeClient::setStatusbarVisible): Deleted. (WebChromeClient::statusbarVisible const): Deleted. (WebChromeClient::setScrollbarsVisible): Deleted. (WebChromeClient::scrollbarsVisible const): Deleted. (WebChromeClient::setMenubarVisible): Deleted. (WebChromeClient::menubarVisible const): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::(SiteIsolation, StatusBarVisibility)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: ((WebKit, ToolbarVisible)): Deleted. Canonical link: https://commits.webkit.org/306391@main
1 parent d6623b5 commit ce23da4

28 files changed

+123
-317
lines changed

‎LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_combination-expected.txt‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
PASS "location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to true
33
PASS "location,menubar,resizable,scrollbars,status" should set BarProp visibility to true
44
PASS "toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to true
5-
FAIL "resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
6-
FAIL "location=no,menubar=no,resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
7-
FAIL "location,toolbar,resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
5+
PASS "resizable,scrollbars,status" should set BarProp visibility to false
6+
PASS "location=no,menubar=no,resizable,scrollbars,status" should set BarProp visibility to false
7+
PASS "location,toolbar,resizable,scrollbars,status" should set BarProp visibility to false
88
PASS "location,toolbar,menubar,scrollbars,status" should set BarProp visibility to true
9-
FAIL "location,toolbar,menubar,resizable=no,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
10-
FAIL "location,toolbar,menubar,resizable,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
11-
FAIL "location,toolbar,menubar,resizable,scrollbars" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
12-
FAIL "popup=1,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
13-
FAIL "popup=yes,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
14-
FAIL "popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
9+
PASS "location,toolbar,menubar,resizable=no,scrollbars,status" should set BarProp visibility to false
10+
PASS "location,toolbar,menubar,resizable,status" should set BarProp visibility to false
11+
PASS "location,toolbar,menubar,resizable,scrollbars" should set BarProp visibility to false
12+
PASS "popup=1,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false
13+
PASS "popup=yes,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false
14+
PASS "popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false
1515
PASS "popup=0,location,toolbar,menubar,resizable,scrollbars" should set BarProp visibility to true
1616

‎LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_position-expected.txt‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11

2-
FAIL "left=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
3-
FAIL "screenX=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
4-
FAIL "top=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
5-
FAIL "screenY=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
6-
FAIL "width=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
7-
FAIL "innerWidth=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
8-
FAIL "outerWidth=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
9-
FAIL "height=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
10-
FAIL "innerHeight=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
11-
FAIL "outerHeight=500" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
2+
PASS "left=500" should set BarProp visibility to false
3+
PASS "screenX=500" should set BarProp visibility to false
4+
PASS "top=500" should set BarProp visibility to false
5+
PASS "screenY=500" should set BarProp visibility to false
6+
PASS "width=500" should set BarProp visibility to false
7+
PASS "innerWidth=500" should set BarProp visibility to false
8+
PASS "outerWidth=500" should set BarProp visibility to false
9+
PASS "height=500" should set BarProp visibility to false
10+
PASS "innerHeight=500" should set BarProp visibility to false
11+
PASS "outerHeight=500" should set BarProp visibility to false
1212

‎LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_single-1-expected.txt‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11

22
PASS undefined should set BarProp visibility to true
3-
FAIL "popup" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
4-
FAIL "popup=1" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
5-
FAIL "popup=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
3+
PASS "popup" should set BarProp visibility to false
4+
PASS "popup=1" should set BarProp visibility to false
5+
PASS "popup=true" should set BarProp visibility to false
66
PASS "popup=0" should set BarProp visibility to true
7-
FAIL "location" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
8-
FAIL "location=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
9-
FAIL "location=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
10-
FAIL "location=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
11-
FAIL "toolbar" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
12-
FAIL "toolbar=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
13-
FAIL "toolbar=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
14-
FAIL "toolbar=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
15-
FAIL "menubar" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
16-
FAIL "menubar=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
17-
FAIL "menubar=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
18-
FAIL "menubar=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
19-
FAIL "resizable" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
20-
FAIL "resizable=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
21-
FAIL "resizable=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
22-
FAIL "resizable=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
7+
PASS "location" should set BarProp visibility to false
8+
PASS "location=yes" should set BarProp visibility to false
9+
PASS "location=true" should set BarProp visibility to false
10+
PASS "location=no" should set BarProp visibility to false
11+
PASS "toolbar" should set BarProp visibility to false
12+
PASS "toolbar=yes" should set BarProp visibility to false
13+
PASS "toolbar=true" should set BarProp visibility to false
14+
PASS "toolbar=no" should set BarProp visibility to false
15+
PASS "menubar" should set BarProp visibility to false
16+
PASS "menubar=yes" should set BarProp visibility to false
17+
PASS "menubar=true" should set BarProp visibility to false
18+
PASS "menubar=no" should set BarProp visibility to false
19+
PASS "resizable" should set BarProp visibility to false
20+
PASS "resizable=yes" should set BarProp visibility to false
21+
PASS "resizable=true" should set BarProp visibility to false
22+
PASS "resizable=no" should set BarProp visibility to false
2323

‎LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-is-popup-condition_single-2-expected.txt‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11

2-
FAIL "scrollbars" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
3-
FAIL "scrollbars=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
4-
FAIL "scrollbars=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
5-
FAIL "scrollbars=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
6-
FAIL "status" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
7-
FAIL "status=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
8-
FAIL "status=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
9-
FAIL "status=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
10-
FAIL "titlebar" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
11-
FAIL "titlebar=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
12-
FAIL "titlebar=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
13-
FAIL "titlebar=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
14-
FAIL "close" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
15-
FAIL "close=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
16-
FAIL "close=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
17-
FAIL "close=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
18-
FAIL "minimizable" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
19-
FAIL "minimizable=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
20-
FAIL "minimizable=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
21-
FAIL "minimizable=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
22-
FAIL "personalbar" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
23-
FAIL "personalbar=yes" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
24-
FAIL "personalbar=true" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
25-
FAIL "personalbar=no" should set BarProp visibility to false assert_equals: window.locationbar.visible expected false but got true
2+
PASS "scrollbars" should set BarProp visibility to false
3+
PASS "scrollbars=yes" should set BarProp visibility to false
4+
PASS "scrollbars=true" should set BarProp visibility to false
5+
PASS "scrollbars=no" should set BarProp visibility to false
6+
PASS "status" should set BarProp visibility to false
7+
PASS "status=yes" should set BarProp visibility to false
8+
PASS "status=true" should set BarProp visibility to false
9+
PASS "status=no" should set BarProp visibility to false
10+
PASS "titlebar" should set BarProp visibility to false
11+
PASS "titlebar=yes" should set BarProp visibility to false
12+
PASS "titlebar=true" should set BarProp visibility to false
13+
PASS "titlebar=no" should set BarProp visibility to false
14+
PASS "close" should set BarProp visibility to false
15+
PASS "close=yes" should set BarProp visibility to false
16+
PASS "close=true" should set BarProp visibility to false
17+
PASS "close=no" should set BarProp visibility to false
18+
PASS "minimizable" should set BarProp visibility to false
19+
PASS "minimizable=yes" should set BarProp visibility to false
20+
PASS "minimizable=true" should set BarProp visibility to false
21+
PASS "minimizable=no" should set BarProp visibility to false
22+
PASS "personalbar" should set BarProp visibility to false
23+
PASS "personalbar=yes" should set BarProp visibility to false
24+
PASS "personalbar=true" should set BarProp visibility to false
25+
PASS "personalbar=no" should set BarProp visibility to false
2626

‎LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-popup-behavior-expected.txt‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,51 +3,51 @@ PASS undefined (expect tab)
33
PASS (expect tab)
44
PASS ,noopener (expect tab)
55
PASS ,noreferrer (expect tab)
6-
FAIL ,popup (expect popup) assert_equals: Popup state expected true but got false
6+
PASS ,popup (expect popup)
77
PASS ,noopener,noreferrer,popup (expect tab)
8-
FAIL resizable=yes,scrollbars=yes,status=yes (expect popup) assert_equals: Popup state expected true but got false
8+
PASS resizable=yes,scrollbars=yes,status=yes (expect popup)
99
PASS resizable=yes,scrollbars=yes,status=yes,noopener (expect tab)
1010
PASS resizable=yes,scrollbars=yes,status=yes,noreferrer (expect tab)
11-
FAIL resizable=yes,scrollbars=yes,status=yes,popup (expect popup) assert_equals: Popup state expected true but got false
11+
PASS resizable=yes,scrollbars=yes,status=yes,popup (expect popup)
1212
PASS resizable=yes,scrollbars=yes,status=yes,noopener,noreferrer,popup (expect tab)
13-
FAIL menubar=yes,resizable=yes,scrollbars=yes (expect popup) assert_equals: Popup state expected true but got false
13+
PASS menubar=yes,resizable=yes,scrollbars=yes (expect popup)
1414
PASS menubar=yes,resizable=yes,scrollbars=yes,noopener (expect tab)
1515
PASS menubar=yes,resizable=yes,scrollbars=yes,noreferrer (expect tab)
16-
FAIL menubar=yes,resizable=yes,scrollbars=yes,popup (expect popup) assert_equals: Popup state expected true but got false
16+
PASS menubar=yes,resizable=yes,scrollbars=yes,popup (expect popup)
1717
PASS menubar=yes,resizable=yes,scrollbars=yes,noopener,noreferrer,popup (expect tab)
18-
FAIL toolbar=yes,resizable=yes,status=yes (expect popup) assert_equals: Popup state expected true but got false
18+
PASS toolbar=yes,resizable=yes,status=yes (expect popup)
1919
PASS toolbar=yes,resizable=yes,status=yes,noopener (expect tab)
2020
PASS toolbar=yes,resizable=yes,status=yes,noreferrer (expect tab)
21-
FAIL toolbar=yes,resizable=yes,status=yes,popup (expect popup) assert_equals: Popup state expected true but got false
21+
PASS toolbar=yes,resizable=yes,status=yes,popup (expect popup)
2222
PASS toolbar=yes,resizable=yes,status=yes,noopener,noreferrer,popup (expect tab)
23-
FAIL toolbar=yes,menubar=yes,resizable=yes (expect popup) assert_equals: Popup state expected true but got false
23+
PASS toolbar=yes,menubar=yes,resizable=yes (expect popup)
2424
PASS toolbar=yes,menubar=yes,resizable=yes,noopener (expect tab)
2525
PASS toolbar=yes,menubar=yes,resizable=yes,noreferrer (expect tab)
26-
FAIL toolbar=yes,menubar=yes,resizable=yes,popup (expect popup) assert_equals: Popup state expected true but got false
26+
PASS toolbar=yes,menubar=yes,resizable=yes,popup (expect popup)
2727
PASS toolbar=yes,menubar=yes,resizable=yes,noopener,noreferrer,popup (expect tab)
28-
FAIL location=yes,scrollbars=yes,status=yes (expect popup) assert_equals: Popup state expected true but got false
28+
PASS location=yes,scrollbars=yes,status=yes (expect popup)
2929
PASS location=yes,scrollbars=yes,status=yes,noopener (expect tab)
3030
PASS location=yes,scrollbars=yes,status=yes,noreferrer (expect tab)
31-
FAIL location=yes,scrollbars=yes,status=yes,popup (expect popup) assert_equals: Popup state expected true but got false
31+
PASS location=yes,scrollbars=yes,status=yes,popup (expect popup)
3232
PASS location=yes,scrollbars=yes,status=yes,noopener,noreferrer,popup (expect tab)
33-
FAIL location=yes,menubar=yes,scrollbars=yes (expect popup) assert_equals: Popup state expected true but got false
33+
PASS location=yes,menubar=yes,scrollbars=yes (expect popup)
3434
PASS location=yes,menubar=yes,scrollbars=yes,noopener (expect tab)
3535
PASS location=yes,menubar=yes,scrollbars=yes,noreferrer (expect tab)
36-
FAIL location=yes,menubar=yes,scrollbars=yes,popup (expect popup) assert_equals: Popup state expected true but got false
36+
PASS location=yes,menubar=yes,scrollbars=yes,popup (expect popup)
3737
PASS location=yes,menubar=yes,scrollbars=yes,noopener,noreferrer,popup (expect tab)
38-
FAIL location=yes,toolbar=yes,status=yes (expect popup) assert_equals: Popup state expected true but got false
38+
PASS location=yes,toolbar=yes,status=yes (expect popup)
3939
PASS location=yes,toolbar=yes,status=yes,noopener (expect tab)
4040
PASS location=yes,toolbar=yes,status=yes,noreferrer (expect tab)
41-
FAIL location=yes,toolbar=yes,status=yes,popup (expect popup) assert_equals: Popup state expected true but got false
41+
PASS location=yes,toolbar=yes,status=yes,popup (expect popup)
4242
PASS location=yes,toolbar=yes,status=yes,noopener,noreferrer,popup (expect tab)
43-
FAIL location=yes,toolbar=yes,menubar=yes (expect popup) assert_equals: Popup state expected true but got false
43+
PASS location=yes,toolbar=yes,menubar=yes (expect popup)
4444
PASS location=yes,toolbar=yes,menubar=yes,noopener (expect tab)
4545
PASS location=yes,toolbar=yes,menubar=yes,noreferrer (expect tab)
46-
FAIL location=yes,toolbar=yes,menubar=yes,popup (expect popup) assert_equals: Popup state expected true but got false
46+
PASS location=yes,toolbar=yes,menubar=yes,popup (expect popup)
4747
PASS location=yes,toolbar=yes,menubar=yes,noopener,noreferrer,popup (expect tab)
4848
PASS location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes (expect tab)
4949
PASS location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes,noopener (expect tab)
5050
PASS location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes,noreferrer (expect tab)
51-
FAIL location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes,popup (expect popup) assert_equals: Popup state expected true but got false
51+
PASS location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes,popup (expect popup)
5252
PASS location=yes,toolbar=yes,menubar=yes,resizable=yes,scrollbars=yes,status=yes,noopener,noreferrer,popup (expect tab)
5353

0 commit comments

Comments
 (0)