Web Inspector: virtualized WI.TreeOutline shows nothing when filters are active

dcrousso · dcrousso · commit cd6fa76b38f1 · 2026-02-02T20:55:44.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=306587 Reviewed by BJ Burg. None of the callsites that provide `ignoreHidden` probably actually want to ignore `hidden`, especially when trying to check if `revealed`. Put another way, it cannot be `revealed` if it is `hidden`. * Source/WebInspectorUI/UserInterface/Views/TreeElement.js: (WI.TreeElement.prototype.get revealed): Renamed from `revealed` to match `WI.DataGridNode`. (WI.TreeElement.prototype.traverseNextTreeElement.shouldSkip): (WI.TreeElement.prototype.traversePreviousTreeElement.shouldSkip): * Source/WebInspectorUI/UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype._treeKeyDown): (WI.TreeOutline.prototype.get revealed): Renamed from `revealed` to match `WI.DataGridNode`. (WI.TreeOutline.prototype._updateVirtualizedElements): * Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourceNavigationSidebarPanel.prototype.handleCopyEvent): Canonical link: https://commits.webkit.org/306680@main
diff --git a/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
@@ -705,11 +705,10 @@ WI.SourcesNavigationSidebarPanel = class SourcesNavigationSidebarPanel extends W
 
         let treeElement = this._callStackTreeOutline.children[0];
 
-        const ignoreHidden = true;
         const skipUnrevealed = true;
         const stayWithin = null;
         const dontPopulate = true;
-        while (!treeElement.revealed(ignoreHidden))
+        while (!treeElement.revealed)
             treeElement = treeElement.traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate);
 
         let indentString = WI.indentString();
diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
@@ -498,16 +498,16 @@ WI.TreeElement = class TreeElement extends WI.Object
             this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementRevealed, {element: this});
     }
 
-    revealed(ignoreHidden)
+    get revealed()
     {
-        if (!ignoreHidden && this.hidden)
+        if (this._hidden)
             return false;
 
         var currentAncestor = this.parent;
         while (currentAncestor && !currentAncestor.root) {
             if (!currentAncestor.expanded)
                 return false;
-            if (!ignoreHidden && currentAncestor.hidden)
+            if (currentAncestor._hidden)
                 return false;
             currentAncestor = currentAncestor.parent;
         }
@@ -590,7 +590,7 @@ WI.TreeElement = class TreeElement extends WI.Object
     traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate, info)
     {
         function shouldSkip(element) {
-            return skipUnrevealed && !element.revealed(true);
+            return skipUnrevealed && !element.revealed;
         }
 
         var depthChange = 0;
@@ -623,7 +623,7 @@ WI.TreeElement = class TreeElement extends WI.Object
     traversePreviousTreeElement(skipUnrevealed, dontPopulate)
     {
         function shouldSkip(element) {
-            return skipUnrevealed && !element.revealed(true);
+            return skipUnrevealed && !element.revealed;
         }
 
         var element = this;
diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
@@ -141,6 +141,8 @@ WI.TreeOutline = class TreeOutline extends WI.Object
 
     set hidden(x)
     {
+        console.assert(false, "not expected to be called");
+
         if (this._hidden === x)
             return;
 
@@ -568,7 +570,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
                         this.selectedTreeElement.parent.collapse();
                 }
             } else if (event.keyIdentifier === expandKeyIdentifier) {
-                if (!this.selectedTreeElement.revealed()) {
+                if (!this.selectedTreeElement.revealed) {
                     this.selectedTreeElement.reveal();
                     handled = true;
                 } else if (this.selectedTreeElement.expandable) {
@@ -635,7 +637,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
         // this is the root, do nothing
     }
 
-    revealed()
+    get revealed()
     {
         return true;
     }
@@ -936,14 +938,13 @@ WI.TreeOutline = class TreeOutline extends WI.Object
         const skipUnrevealed = true;
         const stayWithin = null;
         const dontPopulate = true;
-        const ignoreHidden = true;
 
         let firstChild = this.children[0];
-        if (firstChild && !firstChild.revealed(ignoreHidden))
+        if (firstChild && !firstChild.revealed)
             firstChild = firstChild.traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate);
 
         let shouldScroll = false;
-        if (focusedTreeElement && focusedTreeElement.revealed(false)) {
+        if (focusedTreeElement?.revealed) {
             let index = 0;
             for (let child = firstChild; child && child !== focusedTreeElement; child = child.traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate))
                 ++index;

Original file line number	Diff line number	Diff line change
`@@ -498,16 +498,16 @@ WI.TreeElement = class TreeElement extends WI.Object`
`498`	`498`	`this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementRevealed, {element: this});`
`499`	`499`	`}`
`500`	`500`
`501`		`- revealed(ignoreHidden)`
	`501`	`+ get revealed()`
`502`	`502`	`{`
`503`		`- if (!ignoreHidden && this.hidden)`
	`503`	`+ if (this._hidden)`
`504`	`504`	`return false;`
`505`	`505`
`506`	`506`	`var currentAncestor = this.parent;`
`507`	`507`	`while (currentAncestor && !currentAncestor.root) {`
`508`	`508`	`if (!currentAncestor.expanded)`
`509`	`509`	`return false;`
`510`		`- if (!ignoreHidden && currentAncestor.hidden)`
	`510`	`+ if (currentAncestor._hidden)`
`511`	`511`	`return false;`
`512`	`512`	`currentAncestor = currentAncestor.parent;`
`513`	`513`	`}`
`@@ -590,7 +590,7 @@ WI.TreeElement = class TreeElement extends WI.Object`
`590`	`590`	`traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate, info)`
`591`	`591`	`{`
`592`	`592`	`function shouldSkip(element) {`
`593`		`- return skipUnrevealed && !element.revealed(true);`
	`593`	`+ return skipUnrevealed && !element.revealed;`
`594`	`594`	`}`
`595`	`595`
`596`	`596`	`var depthChange = 0;`
`@@ -623,7 +623,7 @@ WI.TreeElement = class TreeElement extends WI.Object`
`623`	`623`	`traversePreviousTreeElement(skipUnrevealed, dontPopulate)`
`624`	`624`	`{`
`625`	`625`	`function shouldSkip(element) {`
`626`		`- return skipUnrevealed && !element.revealed(true);`
	`626`	`+ return skipUnrevealed && !element.revealed;`
`627`	`627`	`}`
`628`	`628`
`629`	`629`	`var element = this;`