RTCIceCandidate.toJSON() doesn't serialize usernameFragment

Ahmad-S792 · Ahmad Saleem · commit a57d4c42da1c · 2026-02-05T01:23:37.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=307038 rdar://169679947 Reviewed by Philippe Normand. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. The toJSON() method was missing the usernameFragment field in its serialization, this patch adds it to progress failing test case. * Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp: (WebCore::RTCIceCandidate::toJSON const): * LayoutTests/imported/w3c/web-platform-tests/webrtc/toJSON-expected.txt: Progression Canonical link: https://commits.webkit.org/306845@main
diff --git a/LayoutTests/imported/w3c/web-platform-tests/webrtc/toJSON-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webrtc/toJSON-expected.txt
@@ -1,4 +1,4 @@
 
 PASS RTCSessionDescription.toJSON serializes only specific attributes
-FAIL RTCIceCandidate.toJSON serializes only specific attributes assert_equals: expected (string) "test" but got (object) null
+PASS RTCIceCandidate.toJSON serializes only specific attributes
 
diff --git a/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp b/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp
@@ -75,6 +75,7 @@ RTCIceCandidateInit RTCIceCandidate::toJSON() const
     result.candidate = m_candidate;
     result.sdpMid = m_sdpMid;
     result.sdpMLineIndex = m_sdpMLineIndex;
+    result.usernameFragment = m_fields.usernameFragment;
     return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`
`2`	`2`	`PASS RTCSessionDescription.toJSON serializes only specific attributes`
`3`		`-FAIL RTCIceCandidate.toJSON serializes only specific attributes assert_equals: expected (string) "test" but got (object) null`
	`3`	`+PASS RTCIceCandidate.toJSON serializes only specific attributes`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ RTCIceCandidateInit RTCIceCandidate::toJSON() const`
`75`	`75`	`result.candidate = m_candidate;`
`76`	`76`	`result.sdpMid = m_sdpMid;`
`77`	`77`	`result.sdpMLineIndex = m_sdpMLineIndex;`
	`78`	`+ result.usernameFragment = m_fields.usernameFragment;`
`78`	`79`	`return result;`
`79`	`80`	`}`
`80`	`81`