RTCRtpSender should allow maxFramerate of 0

Ahmad-S792 · Ahmad Saleem · commit 3fba1c94c150 · 2026-02-08T07:50:53.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=307227 rdar://169863687 Reviewed by Philippe Normand. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web Specification [1]. This patch updates our validation from <= to just < since we should just reject negative values. Previously, we were also rejecting when maxFramerate was '0', which is not aligned with below specification referenced: "Verify that the value of each maxFramerate member in sendEncodings that is defined is greater than 0.0." [1] https://w3c.github.io/webrtc-pc/#dfn-addtransceiver-sendencodings-validation-steps * Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp: (WebCore::validateSendEncodings): * LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpParameters-maxFramerate-expected.txt: Progression Canonical link: https://commits.webkit.org/307034@main
diff --git a/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpParameters-maxFramerate-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpParameters-maxFramerate-expected.txt
@@ -10,7 +10,7 @@ PASS setParameters() with maxFramerate undefined->16 should succeed with RTCRtpT
 PASS setParameters() with maxFramerate undefined->16 should succeed without RTCRtpTransceiverInit
 FAIL setParameters() with maxFramerate 24->undefined should succeed with RTCRtpTransceiverInit assert_equals: expected (undefined) undefined but got (number) 24
 FAIL setParameters() with maxFramerate 24->undefined should succeed without RTCRtpTransceiverInit assert_equals: expected (undefined) undefined but got (number) 24
-FAIL setParameters() with maxFramerate 0->16 should succeed with RTCRtpTransceiverInit promise_test: Unhandled rejection with value: object "RangeError: maxFrameRate is below or equal 0"
+PASS setParameters() with maxFramerate 0->16 should succeed with RTCRtpTransceiverInit
 PASS setParameters() with maxFramerate 0->16 should succeed without RTCRtpTransceiverInit
 PASS setParameters() with maxFramerate 24->0 should succeed with RTCRtpTransceiverInit
 PASS setParameters() with maxFramerate 24->0 should succeed without RTCRtpTransceiverInit
diff --git a/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp b/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
@@ -2,7 +2,7 @@
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2015, 2016 Ericsson AB. All rights reserved.
- * Copyright (C) 2017-2025 Apple Inc. All rights reserved.
+ * Copyright (C) 2017-2026 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -210,8 +210,8 @@ static std::optional<Exception> validateSendEncodings(Vector<RTCRtpEncodingParam
         if (encoding.scaleResolutionDownBy && *encoding.scaleResolutionDownBy < 1)
             return Exception { ExceptionCode::RangeError, "scaleResolutionDownBy is below 1"_s };
 
-        if (encoding.maxFramerate && *encoding.maxFramerate <= 0)
-            return Exception { ExceptionCode::RangeError, "maxFrameRate is below or equal 0"_s };
+        if (encoding.maxFramerate && *encoding.maxFramerate < 0)
+            return Exception { ExceptionCode::RangeError, "maxFrameRate is below 0"_s };
 
         if (hasAnyScaleResolutionDownBy) {
             if (!encoding.scaleResolutionDownBy)
