Readonly date input can be edited via keyboard

nipunshukla21 · nipunshukla21 · commit 4d6199e55419 · 2026-02-20T12:04:49.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=306307 rdar://169488939 Reviewed by Ryosuke Niwa. Fix readonly date input picker opening via space key by adding an isMutable() guard to didReceiveSpaceKeyFromControl(), matching the existing guards in handleDOMActivateEvent() and handleAccessibilityActivation(). Test: fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress.html * LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress-expected.txt: Added. * LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress.html: Added. * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::didReceiveSpaceKeyFromControl): Canonical link: https://commits.webkit.org/307934@main
diff --git a/LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress-expected.txt b/LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress-expected.txt
@@ -0,0 +1,15 @@
+Tests that a readonly date input's calendar view cannot be opened using the space key.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS showingPicker is false
+Focusing readonly input using tab key and then pressing space key.
+PASS showingPicker is false
+PASS document.getElementById('input').value is "1970-01-01"
+Removing readonly attribute and pressing space key.
+PASS showingPicker is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress.html b/LayoutTests/fast/forms/date/date-editable-components/date-readonly-picker-does-not-open-on-space-keypress.html
@@ -0,0 +1,44 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../../../resources/js-test.js"></script>
+<script src="../../../../resources/ui-helper.js"></script>
+</head>
+<body>
+
+<input id="input" type="date" readonly value="1970-01-01"/>
+
+<script>
+
+jsTestIsAsync = true;
+
+addEventListener("load", async () => {
+    description("Tests that a readonly date input's calendar view cannot be opened using the space key.");
+
+    showingPicker = await UIHelper.isShowingDateTimePicker();
+    shouldBeFalse("showingPicker");
+
+    debug("Focusing readonly input using tab key and then pressing space key.");
+    UIHelper.keyDown("\t");
+    UIHelper.keyDown(" ");
+    await UIHelper.ensurePresentationUpdate();
+
+    showingPicker = await UIHelper.isShowingDateTimePicker();
+    shouldBeFalse("showingPicker");
+
+    shouldBeEqualToString("document.getElementById('input').value", "1970-01-01");
+
+    debug("Removing readonly attribute and pressing space key.");
+    document.getElementById("input").removeAttribute("readonly");
+    UIHelper.keyDown(" ");
+    await UIHelper.ensurePresentationUpdate();
+
+    showingPicker = await UIHelper.isShowingDateTimePicker();
+    shouldBeTrue("showingPicker");
+
+    finishJSTest();
+});
+</script>
+
+</body>
+</html>
diff --git a/Source/WebCore/html/BaseDateAndTimeInputType.cpp b/Source/WebCore/html/BaseDateAndTimeInputType.cpp
@@ -597,6 +597,10 @@ void BaseDateAndTimeInputType::didChangeValueFromControl()
 
 void BaseDateAndTimeInputType::didReceiveSpaceKeyFromControl()
 {
+    ASSERT(element());
+    if (!element()->renderer() || !protect(element())->isMutable())
+        return;
+
     // One of our subfields received a space key event, so let's move focus into the picker.
     m_pickerWasActivatedByKeyboard = true;
     m_didTransferFocusToPicker = true;
