You need to start building your own module (extension). https://docs.modmore.com/en/Commerce/v1/Developer/Guides/Bootstrapping_a_Module.html

Once you have that, you can extend the comShippingMethod class through the xPDO model in the extension to create your custom shipping method. https://docs.modmore.com/en/Commerce/v1/Developer/Custom_Shipping_Methods.html

Once you have that, you can take your example code and put it in the getPriceForShipment method. I see some minor issues you’d need to fix:

• It’s $shipment->getItems(), or $order = $shipment->getOrder() and then $order->getItems() to get the items.
• It’s $product->getTarget(), not $product->getResource().
• Careful using strict type matching for TV values. Those typically come through as strings, so I suspect your $profit match would not work.

1. if there is a way where I can add shipping fee on a product based on a TV value.
2. to then there to be no shipping cost if they have more than 1 product in the cart.

This is a sample snippet with the logic:

<?php
/**
 * Custom shipping calculator for Commerce
 * Returns £8 if:
 * - There is exactly one ink product (total quantity of inks = 1)
 * - AND that ink product has product_profit < 8
 * Otherwise returns 0 (free shipping).
 */

// Get the cart
$cart = $modx->commerce->getCart();
$items = $cart->getItems();

$totalInkQuantity = 0;
$lowProfitExists  = false;

foreach ($items as $item) {
    // Get the product object (comProduct)
    $product = $item->getProduct();
    if (!$product) {
        continue;
    }

    // Get the linked resource (MODX resource) to access the TV
    $resource = $product->getResource();
    if (!$resource) {
        continue;
    }

    // Retrieve the product_profit TV value
    $profit = $resource->getTVValue('product_profit');

    // If the TV is not equal to -1, we consider this an ink product
    if ($profit !== -1) {
        $quantity = $item->get('quantity');
        $totalInkQuantity += $quantity;

        // Check if this product has low profit (<8)
        if ((float)$profit < 8) {
            $lowProfitExists = true;
        }
    }
}

// Rule 1: If total ink quantity > 1, shipping is free
if ($totalInkQuantity > 1) {
    return 0.00;
}

// Rule 2: If exactly one ink product (total quantity = 1) and it has low profit, charge £8
if ($totalInkQuantity === 1 && $lowProfitExists) {
    return 8.00;
}

// All other cases: free shipping
return 0.00;

If the page is once “manually” rebuilt it will get newer changes.

Using MODX-3.2.0 and CB 1.15.0-rc2

It’s also not that bad. My crude snippet takes 0.4s to create two HTML tables for fields and layouts with sum and links to every resource on a page with 800 resources. (only problem is that fields in a repeater are registered as a regular fields)

mhamstra:

This is very broken, conceptually that seems like it’s supposed to be checking for absolute files and let those through, but it only let’s an empty string through - meaning it just checks /.

Yes, this part of code probably never runs and is probably not needed.

Looking few lines above I wander what would happen if somebody starts regular file name with ‘http’?
if (substr($src, 0, 4) != 'http')
This is very poor check for http protocol. Should be someting like
if (substr($src, 0, 7) != 'http://' && substr($src, 0, 8) != 'https://')
or some regex.

mhamstra:

Correct - that’s basically the first thing I do in a typical site, configuring specific sources for specific uses, but I suppose not everyone does that with a new source.

I would consider this a very specific setup, we never needed media source from web root. It might be convenient for admin. But other users must not have access to it. We only create specific sources for editors.

Maybe it never really worked, just nobody noticed. You didn’t because of your webroot default media source. We didn’t either because for years and many sites always using image crops, which works fine. This is first time page design let users decide if they want crop.

To me it seems that all you need to do is:

• return source parameter back to phpthumb call
• if basePathRelative and url starts with MODX_BASE_PATH, strip that path
• if url starts with basePath, strip that path
• call phpthumb with this relative path and source number

Basically, you need to do inverse logic to prepareSrcForThumb($src) function:

            if (strpos($src, DIRECTORY_SEPARATOR) !== 0) {
                $src = !empty($properties['basePath']) ? $properties['basePath'] . $src : $src;
                if (!empty($properties['basePathRelative'])) {
                    $src = $this->ctx->getOption('base_path', null, MODX_BASE_PATH) . $src;
                }
            }

Or you can call phpthumb directly like phpthumof does, without any MediaSource stuff. But not sure what happens with S3 sources.

Same code in 3.x.

hrabovec:

This also means creating another Source replacing original one, and use that Source everywhere: image TVs, default media source in core system setting, CB system settings, Formit system settings etc.

Correct - that’s basically the first thing I do in a typical site, configuring specific sources for specific uses, but I suppose not everyone does that with a new source.

That’s basically how it was before - we were passing the url and either the fields’ source or the contentblocks.image.source system setting value. But then apparently that stopped working for whatever reason…

I guess we’re going to have to build our own phpthumb endpoint that tries to parse out the base url of whatever media source and hope for the best. Don’t think we can do that client-side which is where most of this logic is at.

Please think about it again: you said we store full url without Media Source ID. This is not exactly true: Media Source ID is stored in contentblocks.image.source and can be overwritten per Image CB Field. You use that Media source each time uploading or choosing existing one. So why not using the same info to construct Media Source relative url in manager thumb?

Please try it out and let me know if you continue to encounter issues with that!

In theory I can try to reconfigure server as you have, it’s probably not too difficult. But this should be mentioned somewhere in docs to spare us from such headache. I don’t think this is specific to MODX2 in general, but to introduction of Media sources. Due to your default setup you didn’t found this glitch until now. Neither we did because of using crops.

Thinking about it further: inspiration might be popular phpthumbof: it’s doesn’t care about Media source, because it’s mostly used as output filter to processed TV (that already include base path). Looking into code, (when useResizer is off) it uses modPhpThumb class directly to generate thumbnail, which also manages caching. It doesn’t call PhpThumb processor that makes things complicated due to Media sources. This would only affect manager thumbnails. It has nothing to do with CB template parsing or front end. So it’s won’t break any site.

hrabovec:

What I am saying is that TV doesn’t store full url, just part relative to media source. Also in manager, you only see that part:

I understand, but we can’t do that. We store the full url. We haven’t reliably stored the right media source ID when people have selected images to use in the past, plus users can also add images just by entering a URL, or uploading directly which then gets saved somewhere, so moving to the model that uses the media sources API would be tricky for the thousands of existing sites and that existing content.

Did you perhaps change the source with ID 1 to a different base path? On my site(s), that’s always the root one (typically for admin one) which would be consistent with what I’m seeing and what’s different for you.

Development is mainly done on MODX 2 here as well so that could be something that explains the difference, worth reviewing.

Processor PhpThumb.php

1. on line 64 sets Media source from request source param:
   $this->getSource($this->getProperty('source'));
2. getSource() sets requested or default Media source:
   $this->source = modMediaSource::getDefaultSource($this->modx, $sourceId, false);
3. on line 70 calls Media source to process $src param:
   $src = $this->source->prepareSrcForThumb($src);
   If this returns empty, php thumb quetly exits. This is what is happening.

Class modMediaSource.php

1. function prepareSrcForThumb($src) uses FileSystem class to check if file exist
   if (!$this->filesystem->fileExists($src)) { return ''; }
   It does not, because of how filesystem works and filesystem adapter is initialized

Class modFileMediaSource.php

1. in initialize() function creates LocalFileSystemAdapter($this->getBasePath(), ... )
2. getBasePath() returns absolute path for this source
3. so adapter is doing all operations relative to this base path

Class LocalFileSystemAdapter.php

1. in constructor creates PathPrefixer using base path that is used later in all operations of this FileSystem instance

All this is consistent with my observations of how it works. So question really is how can be this working differently for Mark?

images/image.jpg is also what is stored in modx_site_tmplvar_contentvalues db table.
When MODX renders [[*myTV]] on front-end, it adds media source base path, from media source defined in TV Media Sources tab for each context. So one TV can behave differently in different contexts.
One must be carefull when using raw db values of image TVs and not processed values from parser.

Full url in our setup described above is /_user/images/image.jpg
Manager call for thumbnail doesn’t contain media source base /_user/:
/connectors/system/phpthumb.php?w=400&h=400&aoe=0&far=0&f=png&src=images%2Fimage.jpg&wctx=web&source=1&version=28d95d9b

Is the full URL it generates when selecting an image not correct?

Full URL is correct, but it must not be full url to work properly.
When playing with direct calls to phpthumb, ti works like I have written before: src must not contain media source base and source if not specified is defaulted to 1.

So the question is why it works differently in your setup?

The funny thing here is that we use CB for years with pretty large and complex sites and we found this bug only recently. It’s because design of those sites required fixed aspect ratios for images, so we made users use crops. Crops works fine for manager previews. Now client requires mostly uncropped images so we are in trouble.

So the question I don’t have an answer to yet is why passing the full URL does not let phpthumb create the thumbnail for you. That works here, regardless of which source I select an image from.

Is the full URL it generates when selecting an image not correct? If so, that could point to a misconfigured media source. Or maybe there is another variable we’re overlooking here.

I even tried to clear default_media_source system setting, didn’t help. Seems that media source 1 is always default one. Can see this in modMediaSource:
$defaultSourceId = $xpdo->getOption('default_media_source', null, 1);

I tried calling phpthumb on image from another media source and to make it work I had to add source=3 to make it work. But for images from media source 1 (which is also default one) it doesn’t matter if you add source param or not.

Image template variables store path relative to media source. This is why you see correct preview in manager, it doesn’t contain media source base.
But when TV is used (processed), it returns complete path including base, so front end is fine.

hrabovec:

Unfortunately, #3 is still the same bug. The only difference I can see is missing &source=1 parameter from manager php thumb call. But the media source basePath is still there, resulting in error. Seems that phpthumb is still adding basePath, even if it’s not explicitely defined in call.

The fix was to remove the source parameter, to make phpthumb look from the project root. The problem we had trying to run it with the source, is that we don’t store the source-relative URL - only the full URL, as determined by the media source, which does indeed include your media source base url/path and is what the front-end renders too.

Without the source parameter phpthumb should be looking in MODX_BASE_PATH + provided path for the file. So your MODX base path + /_user/images/_contentblocks/image.jpg which should be correct.

Unfortunately, #3 is still the same bug. The only difference I can see is missing &source=1 parameter from manager php thumb call. But the media source basePath is still there, resulting in error. Seems that phpthumb is still adding basePath, even if it’s not explicitely defined in call.

Now the manager call is:
https://myhost/connectors/system/phpthumb.php?src=/_user/images/_contentblocks/image.jpg&w=150&h=100&zc=1

Should be:
https://myhost/connectors/system/phpthumb.php?src=images/_contentblocks/image.jpg&w=150&h=100&zc=1&source=1

Edit: released!

In v2 which already has the structured data model, this is easy and optimized already and definitely something we’ll add to the UI.

With the help of AI built myself a snippet that lists all Blocks, how often they are used and provides links to the manager page of each resource that uses it. It has become very helpful when upgrading sites. Such info should be integrated in the CB-CMP, too.

return $modx->runSnippet('getResources', [
    'parents' => 13,
    'limit' => 0,
    'sortby' => 'pagetitle',
    'tpl' => '@INLINE [[+id]]==[[+pagetitle]]'
]);

Assuming you might be doing something multi-context here, what about using [[+context_key]]?

3.x does add a new original_width/height so we need to use that. It looks straightforward enough to use that and fall back to the image_width/height if it’s not set (on 2.x), so consider that fixed in 1.15.0-rc2 as well.

Still need to research why the media source thing doesn’t work (#3)… will review that hopefully tomorrow.

The 403 forbidden suggests to me there might be a firewall/WAF on the server blocking that request.

The browser’s console shows an error:

ext-base.js:21 POST https://my_problematic_domain.de/connectors/index.php 403 (Forbidden)

||i|@|ext-base.js:21|
| --- | --- | --- | --- |
||request|@|ext-base.js:21|
||request|@|ext-all.js:21|
||onDownload|@|package.browser.panels.js?mv=312pl:277|
||onClick|@|package.browser.panels.js?mv=312pl:236|
||A|@|ext-all.js:21|

Do you see any errors in the browsers’ developer console perhaps when you try to download? Can you download other extras, from modmore or modx, just fine?

What can I do to get Magic Preview?

System: MODX Rev 3.1.2-pl
PHP 8.3.25 on Linux server
mysql DB
Provider dogado.de

Cleared cache via MODX and manually multiple times.

Thanks for hints and help.

Will take a look, should be an easy fix.

Hello,

I’m experiencing deprecation warnings with MoreGallery in my MODX installation running on PHP 8.4. The warnings appear to be coming from the Alpacka dependency.

I have some PHP CLI scripts that include MODX object (use MODX\Revolution\modX;), and that is enough to raise this erorr message in every output of this script.

Error Message:

Deprecated: modmore\Alpacka\Alpacka::getBooleanOption(): Implicitly marking parameter $options as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/core/components/moregallery/vendor/modmore/alpacka/core/components/alpacka/src/Alpacka.php on line 541

Environment:

• MODX Revolution: 3.1.2
• PHP Version: 8.4
• MoreGallery: 1.18.0-rc1

Request:
Could you please update the Alpacka package to remedy this issue?

And thank you for your excellent work on MoreGallery!

This should’ve been fixed with v3.2, released november 2023. Are you still seeing it in that release or newer?

(Internal issue 540)

Also useful would be having an @CHUNK binding, which could more easily implemented (maybe ?). I sometimes use a chunk just to make list-specific calls that pass params to a general-purpose list getter snippet I created.

But I have found quite an elegant way using newly added CB events.
Consider this field template (simplified use case):

<img class="mx-cb-field-image-cropped" src="proxy.php?url=[[+crops.Free.url]]" width="[[+crops.Free.targetWidth]]" height="[[+crops.Free.targetHeight]]">

If “Free” crop is not defined, you need to switch to a different template. So I used plugin for ContentBlocks_BeforeParse:

<?php
$tpl = $scriptProperties['tpl'];
$phs = $scriptProperties['phs'];
if (strpos($tpl, 'mx-cb-field-image-cropped') !== false) {
  if(!$phs["crops"] || !$phs["crops"]["free"]) {
    $modx->log(modX::LOG_LEVEL_ERROR, "changing template");
    $modx->event->output('<img src="proxy.php?url=[[+url]]" width="[[+width]]" height="[[+height]]">');
  }
}
return null;

We have it more complicated than this, rescaling with phpthumbof etc, but the basic idea work just fine.

Unfortunately this doesn’t solve bugs mentioned here: Bugs with Image input type