feat: Global search for all scene/external/prefabs/extensions event sheet by ViktorVovk · Pull Request #8292 · 4ian/GDevelop

ViktorVovk · 2026-02-18T16:16:27Z

Hello. I would like to present my PR in which I implemented a global project search feature.

Currently, in large projects with many scenes and external events, it can be quite time-consuming to quickly find specific items such as actions, conditions, or variables. For this reason, a global search functionality has been implemented.

It is designed as a separate tab panel that contains a search form and search results grouped by scenes. When clicking a search result entry, the editor automatically navigates to the corresponding tab (scene event sheet or external events), where the matches are highlighted.

I would like to share a few screenshots to demonstrate how it currently looks:

- Implemented methods to set and clear global search results in EventsFunctionsExtensionEditor and EventsEditorContainer. - Enhanced EventsSheetComponent to manage global search results and focus. - Added UI components for displaying highlighted search results across various event renderers. - Introduced a new GlobalEventsSearchEditorContainer for managing global search interactions. - Updated MainFrame to handle navigation and state management for global search.

- Introduced a new SVG icon for the global search functionality. - Implemented a utility function `highlightSearchText` to highlight search terms in various components. - Updated multiple components (Instruction, DefaultField, ObjectField, VariableField, GlobalEventsSearchEditorContainer) to utilize the new highlighting function. - Enhanced the MainFrame to include global search options in the menu and project manager. - Integrated global search event handling for improved user experience.

- Added a check for bad instruction metadata in the Instruction component. - Introduced a fallback rendering for missing instructions using the InstructionMissing component. - Ensured that the small icon filename defaults to an empty string if not available.

4ian · 2026-02-19T16:30:44Z

This looks like a cool addition. I know this is still a draft but from a functional point of view we can think of these ways to discover this feature:

Probably a link/button somewhere in the current search box in events "[Search in all event sheets...]"
Maybe the same in the context menu of events? A "Search >" menu with three options: Search & Replace, Search any text, | (separator), Search any text in all Event Sheets
Probably the same in the File menu in a Search menu?
Having a "Global Search" in the project manager seems to actually give a visibility that is a tad too high to this (it's an excellent feature, but is not part of the structure of the project, so unsure it should be an item, if you see what I mean?)
And a command in the command palette! :)

This last point would allow one day to extend this search with a "Search anything" (that could search in events, object properties, behavior properties, extension properties...) (but that's not the point of this PR of course).

- Introduced the GlobalEventsSearchEditor for managing global search interactions. - Created supporting components including GroupItem, GroupList, and RenderMatchRow for displaying search results. - Implemented context management for search state and navigation using GlobalSearchContext. - Added utility functions for handling search logic and deduplication of event paths. - Updated BaseEditor to streamline navigation to events from global search results.

- Added matchCase parameter to global search methods across various components, including EventsFunctionsExtensionEditor, EventsEditorContainer, and GlobalEventsSearchEditor. - Updated highlightSearchText utility to support case-sensitive searches. - Modified multiple components to utilize the new matchCase feature for improved search accuracy. - Ensured consistent handling of search results and state management in the MainFrame and related containers.

ViktorVovk · 2026-02-20T14:36:40Z

HI @4ian. First of all, I would like to thank you for reviewing my PR, even though it is still in Draft. Your comments are truly helpful, as I spent quite some time thinking about the best place to position the project search button. I chose Game Settings because it’s quick to access and easy to find. However, you are absolutely right — the “Search” feature is not really part of the project itself, and to be honest, I was counting on your feedback and suggestions.

In my opinion, a good place could be a transition from the scene search to the project-wide search. However, I’m still struggling from a UI/UX perspective with how and where exactly to place a button (or another control) that would switch from the local search to the global search tab. I would really appreciate it if you could provide a rough mockup (PNG) showing how you think the control for switching from local search to the global search tab should be positioned.

Additionally, I have already added a menu item under View => Global Search.

I would also like to add a hotkey for this feature. I’d be glad if you could suggest which key combination would be the most appropriate.

Regarding the context menu, I’m not entirely sure about it yet, since the entire line gets selected, and actions or conditions can sometimes be quite long.

Removed the button from Game Settings.
Added the command to the Command Palette (Global Search / Search in Project).
Added a hotkey: Ctrl+Shift+F (since Ctrl+F is used for scene search).

- Deleted the unused search_black.svg icon from the project. - Added 'OPEN_GLOBAL_SEARCH' command to the CommandsList for initiating global search. - Defined keyboard shortcut 'CmdOrCtrl+Shift+KeyF' for the global search functionality. - Updated MainFrame and command handlers to support the new global search command. - Adjusted KeyboardShortcuts to prevent conflicts with existing search functionality.

…ld and ObjectField components - Updated the highlightSearchText function calls in DefaultField and ObjectField to consistently use the matchCase parameter for improved case-sensitive search functionality. - Removed unnecessary spanProps variable to streamline the code.

…tem components - Simplified the rendering of search result messages by replacing Trans components with template literals for better readability and performance. - Updated the label for match counts in GroupItem to use string interpolation, enhancing consistency across the search interface.

4ian · 2026-02-23T15:44:33Z

@ViktorVovk This is still in draft, do you want a new review or not yet? :)

I would also like to add a hotkey for this feature. I’d be glad if you could suggest which key combination would be the most appropriate.

Sounds good, I think Ctrl/Cmd+Shift+F is fine (similar to IDEs where Ctrl+F is in the text file, Ctrl+Shift+F is in the whole project/workspace).

Additionally, I have already added a menu item under View => Global Search.

Perfect! That's fine to me.

I chose Game Settings because it’s quick to access and easy to find. However, you are absolutely right — the “Search” feature is not really part of the project itself, and to be honest, I was counting on your feedback and suggestions.

We might not display it in the project manager and just count on people finding it through View and from a link the "local" search (see next point).

a good place could be a transition from the scene search to the project-wide search. However, I’m still struggling from a UI/UX perspective with how and where exactly to place a button (or another control) that would switch from the local search to the global search tab. I would really appreciate it if you could provide a rough mockup (PNG) showing how you think the control for switching from local search to the global search tab should be positioned.

I do agree it would be best to find this feature to have the ability to "transition" from local search to this "global search". I just... am not sure how to do this yet!
I'll check with our design if we can come up with a good idea :)

- Updated the setGlobalSearchResults method in multiple components (EventsFunctionsExtensionEditor, EventsSheet, EventsEditorContainer, EventsFunctionsExtensionEditorContainer, ExternalEventsEditorContainer) to enforce non-nullable types for focusedEventPath, searchText, and matchCase parameters. - Ensured consistent handling of search text and case sensitivity across the application for improved search functionality.

- Updated the globalSearchMatchCase assignment to directly use the matchCase parameter for improved clarity and consistency in search functionality.

…l-search-clean

ViktorVovk · 2026-02-25T15:41:47Z

@ViktorVovk This is still in draft, do you want a new review or not yet? :)

Good day @4ian ,

Please accept my apologies for the delay. Yes, the PR is ready for review.
I will be looking forward to your feedback and comments.

4ian · 2026-02-25T16:57:02Z

No worries! Let me run an AI powered review to see if it catches any obvious issue and we will review it too now.

4ian · 2026-02-25T16:57:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c737575b76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-25T17:04:00Z

newIDE/app/src/MainFrame/index.js

+        openEventsFunctionsExtension(
+          extensionName || name,
+          functionName,
+          behaviorName,
+          objectName
+        );


Select target extension function before navigating match

This branch assumes passing functionName/behaviorName/objectName to openEventsFunctionsExtension is enough to land on the matched function, but openEditorTab only focuses an already-open extension tab and does not reapply extraEditorProps. In that common case, clicking a global-search result from a different function keeps the old function selected, so scrollToEventPath/setGlobalSearchResults run against the wrong events list and the user is taken to an unrelated location.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-25T17:04:00Z

newIDE/app/src/MainFrame/index.js

+      setTimeout(() => {
+        const editorKind =
+          locationType === 'layout'
+            ? 'layout events'
+            : locationType === 'external-events'
+            ? 'external events'
+            : 'events functions extension';


Wait for editor ref before applying global search results

Applying highlights is attempted once via a fixed 450ms timeout; if the destination editor has not mounted yet (slow machine, heavy project, throttled tab), editorRef is still null and this callback exits without retrying, so matches are not highlighted even though navigation was requested. This should wait for/refetch the editor ref (or retry with a bounded loop) instead of relying on a single delay.

Useful? React with 👍 / 👎.

- Introduced a new function to apply search results conditionally based on the current context (extension or standard). - Added logic to ensure the correct function is selected before setting search results, improving the responsiveness of the search feature. - Utilized requestAnimationFrame to defer search result application, allowing for smoother UI updates.

- Added a new prop `searchFocusedEvent` to track the currently focused event during search in the EventsTree. - Updated the SortableEventsTree to utilize `searchFocusedEvent` for improved search match handling. - Introduced a global search retry mechanism in MainFrame to manage search result application more effectively, ensuring smoother user experience.

4ian

First review pass, only nitpickings for now! We need to go deeper in the review for:

The search logic itself (just quickly went through it)
The opening in MainFrame (MainFrame is pretty big already, so I tend to try to move any logic that is added to it to hooks or helper functions so MainFrame is long but not complex)

We will get back to you with more comments as we dig more into the search feature itself :)

newIDE/app/src/EventsSheet/index.js

4ian · 2026-02-26T10:00:00Z

newIDE/app/src/MainFrame/EditorContainers/GlobalSearch/index.js

@@ -0,0 +1,6 @@
+// @flow


Big nitpicking from my side but we usually don't do in the codebase such "index re-exporting type/components" files, because they add more noise than actual encapsulation.

removed! fbc5370

newIDE/app/src/MainFrame/EditorTabsPane.js

newIDE/app/src/MainFrame/EditorContainers/GlobalSearch/RenderMatchRow.js

- Introduced a new type `EventPath` to standardize event path representation as an array of numbers. - Updated multiple components (e.g., EventsSheet, MainFrame, GlobalSearch) to utilize `EventPath` for improved type safety and consistency. - Modified relevant functions and props to accept and return `EventPath`, enhancing clarity in event navigation and search functionalities.

…ex file - Updated the import path for `GlobalEventsSearchEditor` to reflect its new location within the directory structure. - Deleted the now unnecessary `index.js` file in the `GlobalSearch` directory, streamlining the codebase.

- Replaced the `onGlobalSearchWillClose` callback with `onEditorTabClosing` to streamline tab closing behavior. - Updated the `renderTabs` function to ensure tooltips are cleared and the correct editor tab is closed. - Enhanced the `onEditorTabClosing` function to clear global search highlights when a global search tab is closed, improving user experience.

- Replaced `RenderMatchRowList` with `SearchMatchRowList` to enhance clarity in match rendering. - Introduced `SearchMatchRow` component for improved match display and interaction. - Deleted obsolete `RenderMatchRowList` file, streamlining the codebase.

- Consolidated global and local search state management into a single `searchHighlight` object for improved clarity and efficiency. - Updated state initialization and search result handling to accommodate the new structure, enhancing the search functionality. - Simplified the rendering logic to utilize the new `searchHighlight` state, ensuring consistent behavior across search operations.

- Introduced a new type import for `EditorTab` from the `EditorTabsHandler` to enhance type safety and clarity in the MainFrame component. - This addition prepares the codebase for future enhancements related to editor tab management.

ViktorVovk · 2026-02-27T17:40:31Z

Hi @4ian ,

Thank you for the review — I’ve done my best to address all the comments you left.

Additionally, I implemented synchronization between global and local search when navigating from global search results to an event sheet (commit e00502ba1586221ee9eb51b64de06108783cd8eb).

The idea was that when we navigate from the global search results to an event sheet tab, the local search form should automatically open and receive the current search state. This allows us to leverage the advantages of the local search, such as navigating between results and potentially replacing matched entries.

Secondly, this resolves a logic conflict we previously had — when there were existing local search results and we navigated to the same event sheet with completely different results coming from the global search, it raised questions:

What should happen to the existing local search results?
And conversely, how should the local search behave when entering from a global search result?

4ian

Thanks for the updates! Looks better for everything. Added a comment about translation. Another pass to do on our side to check how the search is made and we should be able to merge this next week :)

4ian · 2026-02-26T15:22:39Z

newIDE/app/src/MainFrame/EditorContainers/GlobalSearch/GroupItem.js

+              size="small"
+              variant="outlined"
+              color="secondary"
+              label={totalMatches === 1 ? '1 match' : `${totalMatches} matches`}


Use translation component for all strings when a React.Node is supported:

Suggested change

label={totalMatches === 1 ? '1 match' : `${totalMatches} matches`}

label={totalMatches === 1 ? <Trans>1 match</Trans> : <Trans>{totalMatches} matches</Trans>}

(and in the case where a string is expected, then you either use

i18n._(t`your text`)

or just pass the text with the t macro and let the component call i18n._ (in which case the type should be MessageDescriptor for the prop))

fixed! 7becaa4

newIDE/app/src/EventsSheet/index.js

4ian · 2026-02-27T17:37:02Z

newIDE/app/src/MainFrame/EditorContainers/GlobalSearch/index.js

@@ -0,0 +1,6 @@
+// @flow


newIDE/app/src/MainFrame/EditorTabsPane.js

newIDE/app/src/EventsSheet/index.js

4ian · 2026-02-27T17:45:28Z

This allows us to leverage the advantages of the local search, such as navigating between results and potentially replacing matched entries.

This is a great side effect!

Can you confirm if the previous "conflict between global search + local search" is now solved or if there is still some arbitrage to do in the interface between them?

ViktorVovk · 2026-02-27T17:48:14Z

Yes, this has now been fully resolved and implemented.

…tsSearchEditor and GroupItem components - Wrapped match count text in <Trans> components to support localization in the GlobalEventsSearchEditor. - Updated label for match count in GroupItem to use <Trans> for consistent internationalization across components.

4ian · 2026-03-03T15:45:57Z

Hi! We've made some changes for now mostly on the user interface:

Rename some React states
Used new icons + context menu for filtering (a new addition to conform with the updated local search)
Avoid custom style, prefer Text for all texts, LineStackLayout/ColumnStackLayout for layouting (flexbox), Paper for backgrounds.
- ResponsiveLineStackLayout for 1 column layout on small screens
- Common gotcha: you have to sprinkle some "useFullHeight"/"noOverflowParent" on Column/Line to avoid them to overflow their parents (equivalent to min-width: 0) (probably something that should be done by default... flexbox is complicated)
Use ScrollView instead of custom style
Avoid styles for "marginLeft: 8px" (example: searchButton, resultsArea), just use a LineStackLayout to create consistent gaps between children. It's not the "responsibility" of a RaisedButton, or a button in general, to have some margins. It's the responsibility of the parent component (the LineStackLayout) to create the gaps needed for it.
Replaced the custom made "No matches found." by a EmptyPlaceholder so it's consistent with the rest of the app.
Focus the search field by default when opened.

Next and hopefully final step will be to take a look at if we can simplify the actual global search.

ViktorVovk · 2026-03-03T16:27:16Z

Good day @4ian .
First of all, I would like to express my gratitude for such a thorough review of my PR. Everything looks great.

4ian · 2026-03-04T18:18:05Z

FYI, I'm working on a few more things in the code to make it cleaner, notably avoid strings that are parsed for context.

…n mainframe

…d be a bad error anyway)

…arch/diagnostic report

* Send context of the conversation to improve AI asset search * Add a short description for all extensions and dimension field (2D, 3D, 2D/3D or n/a) (4ian#8303) Only show in developer changelog * Add missing support for short description/dimension Don't show in changelog * Fix being able to rename a layer with shortcut (4ian#8309) * Fix opening the 3D editor not working after launching a preview first on the web (4ian#8310) * Fix property group wrongly set when dragging a folder to the root (4ian#8312) * Fix handling of instance/locked variables (4ian#8311) - Removed the + button that was wrongly shown to add an instance variable (instance variables can only "override" the values of the variables defined in the object) - Fix paste/delete a child of structure/array of a variable that is re-defined in instances variables. Previously it was not possible to paste a variable as a child of a instance variable that was a structure/array. This is now possible (and fully supported - you can't add new variables at the root, but items inside structures/arrays can be changed). * Fix properties sometimes missing or duplicated when grouped in columns (4ian#8313) * Fix keyboard shortcuts (copy/cut/paste/delete/undo/redo) not working when editing variables * Replace old search bar by compact search bar in scene editor panels (4ian#8317) * Improve robustness of AI events generation and asset swapping * [Auto PR] Update translations (4ian#8304) This updates the translations by downloading them from Crowdin and compiling them for usage by the app. Please double check the values in `newIDE/app/src/locales/LocalesMetadata.js` to ensure the changes are sensible. Co-authored-by: 4ian <[email protected]> * Add support for ordering For Each by an expression, with optional limit (4ian#8319) - For advanced use cases where it's important to run events on each instance of an object with an ordering, the For Each can now have an ordering: an expression can be written and will be evaluated for each instance separately. The For Each will then execute for each instance in the order of the result of the expression. - It's possible to change the direction (ascending or descending) - It's also possible to give a limit (for example, 1 will allow to pick just the instance with the highest/lowest value for the expression). - Examples are provided in the UI for common use cases (maximum value of a variable, health points, ammo, distance to another object...) * Update cordova config for new xcode/ios versions (4ian#8321) Only show in developer changelog * Fix tileset scrollbar area changing selection (4ian#8324) Fix 4ian#8316 * Improve details of center/origin when an object is created by the AI (4ian#8322) * Add a simplified version of the Anchor behavior editor (4ian#8325) * [Auto PR] Update translations (4ian#8323) * Bump newIDE version * Fix size calculation for variants Don't show in changelog * [Auto PR] Update translations (4ian#8328) * Fix new group name to ensure no usage of forbidden characters (4ian#8329) * Add storybook stories for Anchor behavior editors (4ian#8330) Do not show in changelog * Fix brackets showing in the top right corner of the scene editor (4ian#8332) Don't show in changelog * Fix Scene Editor panels not resizing as small as possible (4ian#8331) * Allow to import asset pack files (GDO) (4ian#8296) * Explain the difference between built-in and external extensions in the documentation (4ian#8335) - Don't show in changelog * Fix to avoid objects to move when the gizmo dragging point is clicked (4ian#8334) * Tweak the delay before moving an object with gizmo in the 3D editor * Fix event generation errors not properly reported * Allow multiple deletions in a single operation for generated events * Persist properties panel scroll position for instances and objects (4ian#8337) * Fix For Each rendering when disabled and default values * Rename "any order" to "default order" for For Each events * Fix npm commands not working with projects on a different disk on Windows (4ian#8345) * Improve events search UI with Match Case/Filters icon * Pass estimated complexity to events generation Don't show in changelog * Fix overflow in sidebar with leaderboard fields * Fix crashes in Events Sheet * [Auto PR] Update translations (4ian#8333) * Bump newIDE version (4ian#8353) * Fix variable of objects used in events broken after opening the object editor * Bump newIDE version * Add Global Search, allowing to search in all Events Sheets (including extensions) (4ian#8292) - Global Search can be opened using Ctrl+Shift+F (or Cmd+Shift+F). The shortcut works from any editor, even if the Global Search is already opened, allowing to quickly launch a new search. - Click on any search result to open the corresponding events sheet with the result(s) highlighted. - By default, extensions from the store are excluded from results. You can change this in the filters. * Improve current Build mode for the AI, with planning capabilities (4ian#8294) * Also give the ability to stop an ongoing conversation * [Auto PR] Update translations (4ian#8355) * Add "internal instruction name" search criterion in Events Sheet search panel (4ian#8356) Only show in developer changelog * Add support for folders to organize functions in the extension editor (4ian#8357) * Extract instruction name parsing into reusable utility method (4ian#8362) Don't show in changelog * [Auto PR] Update translations [ci skip] (4ian#8360) * Add "MemoryTracked" classes and "UseAfterFreeError" (4ian#8359) - This will track alive/dead instances of some C++ classes and will throw a JS error in case of usage of a already destroyed object from JavaScript. This should avoid crashing/corrupting the wasm/C++ side by calling a method on an object already destroyed. Instead the exception stays on JS side, without reaching the C++ implementation. Only show in developer changelog * Fix test Don't show in changelog * Fix mapVector and Array declarations flow errors (4ian#8364) Only show in developer changelog * Fix flow import-type-as-value errors (4ian#8361) Only show in developer changelog * Forbid to use `/` in folder names (4ian#8366) Don't show in changelog * Add a button to open the community list in a browser (4ian#8367) * Add a new center mode "Centered on Z only" for 3D model objects (4ian#8338) * Fix number formatting to use 16 digits instead of 17 (4ian#8373) * Fix missing extension dependencies in GDO files (4ian#8372) Also fix an exception when importing a GDO file with an extension without a valid version number * Upgrade to React 18 (4ian#8368) Only show in developer changelog * Fix null reference error in Material-UI ButtonBase ripple effect (4ian#8374) Only show in developer changelog * Fix potential crashes (4ian#8375) * Fix crash when pinching in image preview on mobile (4ian#8379) * Fix formatting * Education plan now supports inviting existing accounts (useful for SSO requirements) (4ian#8371) * [Auto PR] Update translations (4ian#8363) This updates the translations by downloading them from Crowdin and compiling them for usage by the app. Please double check the values in `newIDE/app/src/locales/LocalesMetadata.js` to ensure the changes are sensible. Co-authored-by: ClementPasteau <[email protected]> * Fix to try to prevent crashes at project switch (4ian#8380) * Fix tentatively more crashes when switching/closing projects (4ian#8383) * Fix tentatively crashes when deleting an object from the objects list * Fix regression when importing assets on newly created local project (4ian#8384) * Fix resource sub-folders when imported GDO file on Windows (4ian#8381) * Fix crash when using invalid BBCode color values in BBText (4ian#8386) * Make Steamworks extension accessible from the web-app * Add memory tracking to additional container classes (4ian#8392) Only show in developer changelog * Fix the displayed group of functions that are not in any folders (4ian#8395) * Fix wrong error on iOS certificate upload (4ian#8397) * Fix tooltip text not visible on light theme (4ian#8396) * Redesign the function property editor to use compact fields (4ian#8394) * Fix typo (4ian#8398) Do not show in changelog * Add ability to use an expression for the 'Set skin' action for Spine (4ian#8389) * Fix setters being put in the root folder (4ian#8399) - Don't show in changelog * Fix parameter placeholder overflowing (4ian#8400) - Don't show in changelog * Update package-lock.json --------- Co-authored-by: Florian Rival <[email protected]> Co-authored-by: Florian Rival <[email protected]> Co-authored-by: Clément Pasteau <[email protected]> Co-authored-by: D8H <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 4ian <[email protected]> Co-authored-by: LuniMoon <[email protected]> Co-authored-by: opaldi <[email protected]> Co-authored-by: ViktorVovk <[email protected]>

Viktor Vovk added 3 commits February 18, 2026 14:47

Viktor Vovk added 2 commits February 19, 2026 22:39

Viktor Vovk added 3 commits February 20, 2026 17:10

Viktor Vovk added 3 commits February 25, 2026 12:46

Refactor global search match case handling in EventsSheet component

eb2444e

- Updated the globalSearchMatchCase assignment to directly use the matchCase parameter for improved clarity and consistency in search functionality.

Merge branch 'master' of github-v:ViktorVovk/GDevelop into feat-globa…

c737575

…l-search-clean

ViktorVovk marked this pull request as ready for review February 25, 2026 15:39

ViktorVovk requested a review from 4ian as a code owner February 25, 2026 15:39

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

Viktor Vovk added 2 commits February 25, 2026 19:31

4ian reviewed Feb 26, 2026

View reviewed changes

newIDE/app/src/MainFrame/EditorContainers/GlobalSearch/RenderMatchRow.js Outdated Show resolved Hide resolved

Viktor Vovk added 6 commits February 27, 2026 17:41

Add EditorTab type import in MainFrame component

95e7cd6

- Introduced a new type import for `EditorTab` from the `EditorTabsHandler` to enhance type safety and clarity in the MainFrame component. - This addition prepares the codebase for future enhancements related to editor tab management.

ViktorVovk requested a review from 4ian February 27, 2026 17:40

4ian reviewed Feb 27, 2026

View reviewed changes

ViktorVovk requested a review from 4ian February 27, 2026 17:54

4ian added 4 commits March 3, 2026 15:11

Fix translation and update namings

254972d

Merge branch 'master' into feat-global-search-clean

2ae3c40

Add missing shortcut in menu, rework buttons to be like local search

2d0a0a3

Fix responsiveness, remove some custom styles, use EmptyPlaceholder

a4b79e9

Refocus search field when search is re-opened with the shortcut

7b348f1

4ian added 3 commits March 4, 2026 18:07

Fix warning and outdated search text when Enter is pressed

4ac9206

Factor functions to render instruction as string and add missing type

71ab155

Fix risky dynamic access bypassing the type system

a99a7bb

4ian added 5 commits March 4, 2026 20:08

Remove useless string/parsing of string for search matches

c8f88f2

Add unit test

700f61d

Remove dead code

1973d79

Remove Types folder, we use utils instead

27bb8b8

Refactor global search and tab logic in a hook to reduce complexity i…

27859f7

…n mainframe

4ian added the 🏁PR almost ready: final fixes The PR is almost ready and needs final fixes and/or polishing before merge label Mar 4, 2026

4ian added 3 commits March 4, 2026 21:36

Refactor state of MainFrame in a different file

b6b9904

Use more idiomatic code, remove useless try/catch (throwing here woul…

4209b2f

…d be a bad error anyway)

Prefer to display unknown instruction than the instruction type in se…

34945ba

…arch/diagnostic report

4ian merged commit 0a839c8 into 4ian:master Mar 5, 2026
2 of 3 checks passed

D8H mentioned this pull request Mar 18, 2026

Fix missing instructions not being selectable #8410

Merged

	label={totalMatches === 1 ? '1 match' : `${totalMatches} matches`}
	label={totalMatches === 1 ? <Trans>1 match</Trans> : <Trans>{totalMatches} matches</Trans>}

Conversation

ViktorVovk commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

4ian commented Feb 19, 2026

Uh oh!

ViktorVovk commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

4ian commented Feb 23, 2026

Uh oh!

ViktorVovk commented Feb 25, 2026

Uh oh!

4ian commented Feb 25, 2026

Uh oh!

4ian commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4ian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ViktorVovk commented Feb 27, 2026

Uh oh!

4ian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

4ian commented Feb 27, 2026

Uh oh!

ViktorVovk commented Feb 27, 2026

Uh oh!

4ian commented Mar 3, 2026

Uh oh!

ViktorVovk commented Mar 3, 2026

Uh oh!

4ian commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ViktorVovk commented Feb 18, 2026 •

edited

Loading

ViktorVovk commented Feb 20, 2026 •

edited

Loading