Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3614 +/- ##
==========================================
+ Coverage 73.24% 73.49% +0.25%
==========================================
Files 678 679 +1
Lines 26209 26316 +107
Branches 2364 2371 +7
==========================================
+ Hits 19196 19342 +146
+ Misses 6857 6818 -39
Partials 156 156
|
chopin-fan
force-pushed
the
feature/whitelist-to-sdk
branch
from
47246dc to
a57f39e
Compare
…eature/whitelist-to-sdk
eanzhao
reviewed
Oct 11, 2024
| namespace AElf.Types | ||
| { | ||
|
|
||
| public partial class BigIntValue : IComparable, IComparable<BigIntValue> |
Contributor
There was a problem hiding this comment.
Improved BigIntValue by the way, nice.
eanzhao
approved these changes
Oct 11, 2024
David20240718
approved these changes
Dec 13, 2024
Contributor
David20240718
left a comment
David20240718
left a comment
There was a problem hiding this comment.
Everything checks out, approved.
JimAelf
approved these changes
Dec 14, 2024
Contributor
There was a problem hiding this comment.
if this file hasn't anything actual code change, please maintain the old file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #3610 .
Add *, +, - operators to BigIntValue type.
Add Keccak256, Bn254G1Mul, Bn254G1Add, and Bn254Pairing functions for the ZkVerify contract.
Add ValueTuple function to the whitelist.
Allow the StructuredState class.