Skip to content

Revert "Fix redundant host resolution in DDL Worker"#1219

Merged
zvonand merged 1 commit intoantalya-25.8from
bugfix/antalya-25.8/revert_88153
Dec 13, 2025
Merged

Revert "Fix redundant host resolution in DDL Worker"#1219
zvonand merged 1 commit intoantalya-25.8from
bugfix/antalya-25.8/revert_88153

Conversation

@ianton-ru
Copy link

@ianton-ru ianton-ru commented Dec 12, 2025 •
edited
Loading

This reverts commit be89d26.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Solved ClickHouse#89693
Revert of ClickHouse#88153

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Workflow [PR], commit [321b18f]

@zvonand
Copy link
Collaborator

zvonand commented Dec 13, 2025

02210_processors_profile_log: is it related? looks not very related

It is not very flaky in upstream:

https://play.clickhouse.com/play?user=play#c2VsZWN0IAp0b1N0YXJ0T2ZEYXkoY2hlY2tfc3RhcnRfdGltZSkgYXMgZCwKY291bnQoKSwgIGdyb3VwVW5pcUFycmF5KHB1bGxfcmVxdWVzdF9udW1iZXIpLCAgYW55KHJlcG9ydF91cmwpCmZyb20gY2hlY2tzIHdoZXJlICcyMDI1LTAxLTAxJyA8PSBjaGVja19zdGFydF90aW1lIGFuZCB0ZXN0X25hbWUgbGlrZSAnJTAyMjEwX3Byb2Nlc3NvcnNfcHJvZmlsZV9sb2clJyBhbmQgdGVzdF9zdGF0dXMgaW4gKCdGQUlMJywgJ0ZMQUtZJykgZ3JvdXAgYnkgZCBvcmRlciBieSBkIGRlc2M=

@ianton-ru
Copy link
Author

ianton-ru commented Dec 13, 2025

02210_processors_profile_log: is it related? looks not very related

It is not very flaky in upstream:

https://play.clickhouse.com/play?user=play#c2VsZWN0IAp0b1N0YXJ0T2ZEYXkoY2hlY2tfc3RhcnRfdGltZSkgYXMgZCwKY291bnQoKSwgIGdyb3VwVW5pcUFycmF5KHB1bGxfcmVxdWVzdF9udW1iZXIpLCAgYW55KHJlcG9ydF91cmwpCmZyb20gY2hlY2tzIHdoZXJlICcyMDI1LTAxLTAxJyA8PSBjaGVja19zdGFydF90aW1lIGFuZCB0ZXN0X25hbWUgbGlrZSAnJTAyMjEwX3Byb2Nlc3NvcnNfcHJvZmlsZV9sb2clJyBhbmQgdGVzdF9zdGF0dXMgaW4gKCdGQUlMJywgJ0ZMQUtZJykgZ3JvdXAgYnkgZCBvcmRlciBieSBkIGRlc2M=

Looks unrelated. Test is very strange, relays in timer precision
https://github.com/ClickHouse/ClickHouse/blob/master/tests/queries/0_stateless/02210_processors_profile_log.sql#L19
an looks like in reality it is not so precision, 999992 is a little bit less than 1e6.

@zvonand
Copy link
Collaborator

zvonand commented Dec 13, 2025

So, you think it is ok to merge?

@ianton-ru
Copy link
Author

ianton-ru commented Dec 13, 2025

Yes

@zvonand zvonand merged commit 2264456 into antalya-25.8 Dec 13, 2025
134 of 138 checks passed
zvonand added a commit that referenced this pull request Dec 15, 2025
@zvonand
Merge pull request #1219 from Altinity/bugfix/antalya-25.8/revert_88153
cbf109a 
Revert "Fix redundant host resolution in DDL Worker"
@alsugiliazova
Copy link
Member

alsugiliazova commented Dec 18, 2025

Verified by clients in here ClickHouse#89693.
I was not able to reproduce this issue.

@alsugiliazova alsugiliazova added the verified Verified by QA label Dec 18, 2025
@svb-alt svb-alt added the port-antalya PRs to be ported to all new Antalya releases label Feb 6, 2026
@ianton-ru ianton-ru added antalya-obsolete PR exists in higher Altinity release (doesn’t need forward porting) and removed port-antalya PRs to be ported to all new Antalya releases labels Feb 6, 2026
@ianton-ru
Copy link
Author

ianton-ru commented Feb 6, 2026

Must be fixed in 26.1 (ClickHouse#93779)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

antalya antalya-25.8 antalya-obsolete PR exists in higher Altinity release (doesn’t need forward porting) bugfix verified Verified by QA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ianton-ru @zvonand @alsugiliazova @svb-alt