Skip to content

25.8.15 Stable Backport of #86633 - Add support for user names in config containing a dot#1342

Merged
zvonand merged 2 commits intoreleases/25.8.15from
backports/25.8.15/86633
Jan 28, 2026
Merged

25.8.15 Stable Backport of #86633 - Add support for user names in config containing a dot#1342
zvonand merged 2 commits intoreleases/25.8.15from
backports/25.8.15/86633

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Jan 27, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes handling of users with a dot in the name when added via config file (ClickHouse#86633 by @mkmkme)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@azat @zvonand
Merge pull request ClickHouse#86633 from mkmkme/mkmkme/name-dots
b297adb 
Add support for user names in config containing a dot
@zvonand zvonand mentioned this pull request Jan 27, 2026
Closed
25 tasks
@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Workflow [PR], commit [d02ec12]

@zvonand
Copy link
Collaborator Author

zvonand commented Jan 28, 2026

S3 fails: Altinity/clickhouse-regression#93

Aggregate fails: uniqTheta was updated in upstream, not related, test will be updated separately by QA team

@zvonand zvonand merged commit e8f10d5 into releases/25.8.15 Jan 28, 2026
792 of 840 checks passed
@Selfeer
Copy link
Collaborator

Selfeer commented Jan 30, 2026 •
edited
Loading

Failed Jobs Analysis

Job Status Cause PR-Related
AST fuzzer (amd_debug) error Infrastructure error ❌ No
BuzzHouse (amd_debug) error Infrastructure error ❌ No
Regression aarch64/release aggregate_functions_1 failure uniqTheta test needs changes unrelated to the pr ❌ No
Regression aarch64 parquet failure Test infrastructure issue ❌ No
Regression aarch64/release s3_aws_s3_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No
Regression aarch64/release s3_azure_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No
Regression aarch64/release s3_minio_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No

────────────────────────────────────────

Detailed Failure Analysis

  1. AST fuzzer & BuzzHouse errors (INFRASTRUCTURE)

• Reports: AST fuzzer | BuzzHouse
• Reason: Jobs errored without completing - infrastructure/runner issue
• Verdict: Infrastructure problem, not caused by PR

  1. uniqTheta aggregate function test

• Reports: x86_64 | aarch64
• Reason: Aggregate function test completely unrelated to UsersConfigAccessStorage changes
• Verdict: Test needs to be updated because of the other changes made in upstream related to aggregate functions.

  1. Parquet test

• Report: aarch64
• Reason: Parquet format handling unrelated to user config parsing
• Verdict: infrastructure issue, could not bring up docker compose

  1. Zero-copy replication tests

Failed tests across AWS S3, Azure, and MinIO backends:
• zero copy replication/add remove replica parallel
• zero copy replication/add remove one replica
• zero copy replication/bad detached part
• zero copy replication/insert multiple replicas (x86_64 AWS S3 only)

The issue: #1338
The fix: ClickHouse#95597

Reports:
• s3_aws_s3_2 x86_64
• s3_minio_2 x86_64
• s3_azure_2 x86_64
• Reason: S3/Zero-copy replication logic is completely unrelated to user config access storage.
• Verdict: not caused by PR

@Selfeer Selfeer added the verified Verified by QA label Feb 3, 2026
@svb-alt svb-alt added 25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable and removed 25.8.15 25.8.15.10001 labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkmkme mkmkme mkmkme approved these changes

Assignees

No one assigned

Labels

25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable verified Verified by QA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zvonand @Selfeer @mkmkme @svb-alt @azat