24.8 Avoid leaking AWS secrets via logs#691
Conversation
Using credentials file instead of environment
|
We can remove the credentials from the function inputs ClickHouse/docker/packager/packager Line 149 in 1978b14 ClickHouse/docker/packager/packager Line 153 in 1978b14 and then the commented out ones as well ClickHouse/docker/packager/packager Line 563 in 1978b14 ClickHouse/docker/packager/packager Line 567 in 1978b14 |
My motivation was to stick as close to upstream as possible to avoid merge conflicts down the road, when we are going to port that to the other versions... |
|
Actually removing them would be closer to upstream - for example, 24.8 doesn't have them https://github.com/ClickHouse/ClickHouse/blob/24.8/docker/packager/packager . Same with master |
|
Continued in #693 |
2 participants
Changelog category (leave one):
Exclude tests: