Fix #479: C backend: preserve case in union member names#480
Merged
andreasabel merged 3 commits intomasterfrom Apr 28, 2024
Merged
Fix #479: C backend: preserve case in union member names#480andreasabel merged 3 commits intomasterfrom
andreasabel merged 3 commits intomasterfrom
Conversation
andreasabel
force-pushed
the
issue-479
branch
2 times, most recently
from
a4b6e0a to
9ee3aec
Compare
andreasabel
changed the title
Member
Author
|
@ivanperez-keera : Would this change in the C backend affect you? What is your opinion? |
Member
Author
|
This adds java/479_LabelsCaseSensitive to the broken tests:
|
Building HTF with GHC 9.10 is stuck on - haskell/cabal#9917
Java does not suffer case-sensitive labels as each label becomes a class in its own file. Thus, we check this and throw an error. Consequently, test 479_LabelsCaseSensitive is broken for the java backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #479: C: case-sensitive labels: preserve case in union member names.
Java does not suffer case-sensitive labels as each label becomes a class in its own file.
Thus, we check this and throw an error.
Consequently, test
479_LabelsCaseSensitiveis broken for the java backends.Breaking change: this might break C client code.
Fixes #479