fix(registry): accurate patch status for missing agent configs#96
Merged
fix(registry): accurate patch status for missing agent configs#96
Conversation
…y wrapped PatchClientDef returned nil when config had no MCP servers, causing the registry to mark agents as 'patched' even when nothing was wrapped. This made the GUI show 'Protected' for agents with no MCP servers. Return ErrNothingPatched sentinel so the registry can distinguish 'nothing to do' from 'successfully patched'.
…configs HTTPAgent.Patch returned nil when ConfigPath was empty or the config file did not exist, causing PatchAll to falsely mark the target as "patched". Now returns ErrNothingPatched consistent with MCP targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PatchClientDefnow returnsErrNothingPatched(instead ofnil) when config is absent or has no stdio servers, soPatchAllno longer falsely marks these targets as "patched"HTTPAgent.PatchreturnsErrNothingPatchedwhen config path is empty or file doesn't exist (same fix, consistent with MCP targets)PatchAllsuppresses warn-level logs forErrNothingPatched(expected on machines where not all agents are installed)ErrNothingPatchedfrom registry for test ergonomicsTest plan
go test ./internal/daemon/registry/— 9 tests passgo test ./internal/daemon/— passesgo test ./internal/mcpdiscover/— passes