Conversation
…-block - isClaudeHookInstalled now reads ~/.claude/settings.json (was hooks.json) - Metrics.Reset() clears HookBlocks and HookAllowed counters - Dashboard shimmer animation fires on first block event (0→1 transition) - Update TestMetrics_GetStats for hook counter keys
- Use defer for RestoreAgentConfigs after PatchAgentConfigs so normal shutdown always restores configs (crust stop handles crash case) - Register signal handler before ListenAndServe to prevent a race where SIGTERM arrives before signal.Notify is called - Skip writePortFile when eval server fails (port 0) to avoid hook processes connecting to nothing
- Explicitly discard conn.Write errors in eval server TCP handler - Explicitly discard gzReader.Close error in response decompression
Fixes gosec G306 (WriteFile permissions too broad).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defer RestoreAgentConfigs()afterPatchAgentConfigsso normal shutdown always restores configs;crust stophandles crash casesignal.NotifybeforeListenAndServeto prevent missing early SIGTERMwritePortFile(0)when eval server fails to startsettings.jsoninstead of removedhooks.jsonfor Claude Code hook detectionHookBlocksandHookAllowedinMetrics.Reset()-1forprevBlockedTest plan
go build ./...passesgo vet ./...passes