This repository was archived by the owner on Apr 2, 2024. It is now read-only.
refactor(BUX-451): test BUX & cleanup before v1#536
Merged
chris-4chain merged 5 commits intomasterfrom Jan 16, 2024
Merged
Conversation
… by broadcast-client
Contributor
|
Welcome to our open-source project @chris-4chain! 💘 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 51.88% 53.31% +1.42%
==========================================
Files 109 110 +1
Lines 11250 10840 -410
==========================================
- Hits 5837 5779 -58
+ Misses 4946 4596 -350
+ Partials 467 465 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
kuba-4chain
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This taks focused on manual tests of this
buxpackage which I primarily conducted using provided examples and in connection withbux-server.Along with these tests I made the following changes:
bux& `bux-server) with several exceptions - if I determined that a function might be usefull for a potential user of our package, I retained it.staticcheckand fixed issues detected by this toolgolintand fixed most of the errorsutils.byte_array.gofile because of the conversion from byte array to string and vice versa was previously done in a buggy way