Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.
/ bux Public archive
generated from mrz1836/go-template

chore(BUX-417): remove address resolution methods#537

Merged
pawellewandowski98 merged 1 commit intorc-v1.1from
feat-417-remove-address-resolution-methods
Jan 16, 2024
Merged

chore(BUX-417): remove address resolution methods#537
pawellewandowski98 merged 1 commit intorc-v1.1from
feat-417-remove-address-resolution-methods

Conversation

@pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Description

  • Removed DefaultNote from config
  • Removed address resolution methods (deprecated)

@pawellewandowski98 pawellewandowski98 self-assigned this Jan 16, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner January 16, 2024 09:20
@mergify mergify bot added the feature Any new significant addition label Jan 16, 2024
@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (06feaba) 55.19% compared to head (58aba73) 54.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           rc-v1.1     #537      +/-   ##
===========================================
- Coverage    55.19%   54.97%   -0.22%     
===========================================
  Files          104      104              
  Lines        10316    10228      -88     
===========================================
- Hits          5694     5623      -71     
+ Misses        4177     4166      -11     
+ Partials       445      439       -6     
Flag Coverage Δ
unittests 54.97% <83.33%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client.go 65.57% <ø> (ø)
client_internal.go 94.35% <ø> (-0.14%) ⬇️
client_paymail.go 89.47% <ø> (-2.20%) ⬇️
model_draft_transactions.go 73.41% <ø> (-0.13%) ⬇️
model_transaction_config.go 80.26% <100.00%> (-0.73%) ⬇️
paymail.go 46.29% <ø> (-7.18%) ⬇️
client_options.go 75.67% <50.00%> (+0.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06feaba...58aba73. Read the comment docs.

@pawellewandowski98 pawellewandowski98 merged commit e345669 into rc-v1.1 Jan 16, 2024
@mergify mergify bot deleted the feat-417-remove-address-resolution-methods branch January 16, 2024 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature Any new significant addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants