Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.
/ bux Public archive
generated from mrz1836/go-template

BUX-480: Record Transaction#548

Merged
Nazarii-4chain merged 17 commits intomasterfrom
feat/BUX-480/RecordTransaction
Feb 9, 2024
Merged

BUX-480: Record Transaction#548
Nazarii-4chain merged 17 commits intomasterfrom
feat/BUX-480/RecordTransaction

Conversation

@Nazarii-4chain
Copy link
Contributor

@Nazarii-4chain Nazarii-4chain commented Jan 25, 2024

Added error handler

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@Nazarii-4chain Nazarii-4chain self-assigned this Jan 25, 2024
@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner January 25, 2024 09:35
@mergify mergify bot added the feature Any new significant addition label Jan 25, 2024
@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2024

Welcome to our open-source project @Nazarii-4chain! 💘

@codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e530b2c) 54.45% compared to head (612d49e) 54.71%.
Report is 1 commits behind head on master.

❗ Current head 612d49e differs from pull request most recent head 88df6cf. Consider uploading reports for the commit 88df6cf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   54.45%   54.71%   +0.25%     
==========================================
  Files         110      110              
  Lines        8353     8361       +8     
==========================================
+ Hits         4549     4575      +26     
+ Misses       3335     3319      -16     
+ Partials      469      467       -2
Flag Coverage Δ
unittests 54.71% <25.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
record_tx_strategy_outgoing_tx.go 54.62% <100.00%> (+2.48%) ⬆️
paymail_service_provider.go 0.00% <0.00%> (ø)
record_tx_strategy_external_incoming_tx.go 25.55% <0.00%> (-0.59%) ⬇️
record_tx_strategy_internal_incoming_tx.go 24.52% <0.00%> (+24.52%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e94c7...88df6cf. Read the comment docs.

chris-4chain
chris-4chain reviewed Jan 26, 2024
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2024

Welcome to our open-source project @Nazarii-4chain! 💘

arkadiuszos4chain
arkadiuszos4chain suggested changes Feb 6, 2024
View reviewed changes
arkadiuszos4chain
arkadiuszos4chain suggested changes Feb 6, 2024
View reviewed changes
@chris-4chain
Copy link
Contributor

chris-4chain commented Feb 8, 2024

I'm gonna test it 🧪

@chris-4chain chris-4chain added the tested PR was tested by a team member label Feb 9, 2024
@Nazarii-4chain Nazarii-4chain merged commit 6b55e2a into master Feb 9, 2024
@Nazarii-4chain Nazarii-4chain deleted the feat/BUX-480/RecordTransaction branch February 9, 2024 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Nazarii-4chain Nazarii-4chain

Labels

feature Any new significant addition tested PR was tested by a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nazarii-4chain @chris-4chain @arkadiuszos4chain