This repository was archived by the owner on Apr 2, 2024. It is now read-only.
chore(BUX-351): improve logging when requesting Pulse#549
Merged
chris-4chain merged 3 commits intomasterfrom Jan 29, 2024
Merged
chore(BUX-351): improve logging when requesting Pulse#549chris-4chain merged 3 commits intomasterfrom
chris-4chain merged 3 commits intomasterfrom
Conversation
Contributor
|
Welcome to our open-source project @chris-4chain! 💘 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 53.28% 53.89% +0.60%
==========================================
Files 110 110
Lines 10854 10853 -1
==========================================
+ Hits 5784 5849 +65
+ Misses 4605 4533 -72
- Partials 465 471 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kuba-4chain
approved these changes
Jan 29, 2024
pawellewandowski98
approved these changes
Jan 29, 2024
Nazarii-4chain
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
While doing this task, I discovered that, every time a request to our Pulse service is made, a new
http.Clientis created. I've change it - so that now, only one http.Client is created during the initialization stage.From golang documentation: