Fix JSON parsing for floats with negative exponents#377
Merged
lefticus merged 1 commit intoChaiScript:developfrom Nov 21, 2017
Merged
Fix JSON parsing for floats with negative exponents#377lefticus merged 1 commit intoChaiScript:developfrom
lefticus merged 1 commit intoChaiScript:developfrom
Conversation
- also add unit tests to cover some broken (now fixed) cases.
Contributor
Author
|
How does one figure out what the error was? I built everything and ran the unit tests, and there were no errors, nor were there with most of the CI builds/tests. But here, it says one of the fuzz tests (only when compiling with GCC v6) had a segmentation fault, but I don't even know what it was testing: |
Contributor
Author
|
@lefticus I know you've been busy with your various C++ conference presentations... (-; Any tips on how to figure out what the above fuzz-testing error was? Thanks. |
Member
|
I have been busy, but I'm just going to go ahead and merge this and sort out the details of why that test was failing. It was a test that was automatically created with a fuzzer, so if the nature of the test changes because of correctness - that's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue this pull request references: #376