In to_json(), maintain the "type" of empty maps and vectors#400
Merged
lefticus merged 2 commits intoChaiScript:developfrom Feb 3, 2018
Merged
In to_json(), maintain the "type" of empty maps and vectors#400lefticus merged 2 commits intoChaiScript:developfrom
lefticus merged 2 commits intoChaiScript:developfrom
Conversation
- fix issue ChaiScript#399. - make to_json() with an empty Map, Vector or Dynamic_Object return a similar/compatible type (JSON object or array), rather than "null". - include the fix for ChaiScript#381 (to_json() support for null values), so that can also be unit tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue this pull request references: #399
Changes proposed in this pull request