Better diagnostic info in input formats#10418
Merged
alexey-milovidov merged 1 commit intomasterfrom Apr 26, 2020
Merged
Conversation
tavplubix
added
the
pr-bugfix
| { | ||
| verbose_diagnostic = getDiagnosticInfo(); | ||
| } | ||
| catch (Exception & exception) |
|
|
||
| void CSVRowInputFormat::tryDeserializeFiled(const DataTypePtr & type, IColumn & column, size_t file_column, | ||
| ReadBuffer::Position & prev_pos, ReadBuffer::Position & curr_pos) | ||
| void CSVRowInputFormat::tryDeserializeFiled(const DataTypePtr & type, IColumn & column, size_t file_column) |
Member
There was a problem hiding this comment.
We also have 8 such typos in our codebase, let's fix them.
Member
Author
|
And may be we should disable conversion from Float to Decimal128 in Values with expressions until we have Decimal literals |
Member
|
@4ertus2 Could you please help to clarify? |
tavplubix
force-pushed
the
fix_logical_error_in_diagnostic_info
branch
from
200072a to
53dcce5
Compare
tavplubix
pushed a commit
that referenced
this pull request
Apr 30, 2020
…stic_info Better diagnostic info in input formats (cherry picked from commit c6ae6a7)
This was referenced Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Minor improvements in printing diagnostic info in input formats. Fixes #10204