Improve right table insert for Partial MergeJoin on disk#10467
Merged
4ertus2 merged 10 commits intoClickHouse:masterfrom Apr 28, 2020
Merged
Improve right table insert for Partial MergeJoin on disk#104674ertus2 merged 10 commits intoClickHouse:masterfrom
4ertus2 merged 10 commits intoClickHouse:masterfrom
Conversation
4ertus2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Better insert logic for right table for Partial MergeJoin.
Detailed description / Documentation draft:
Do not lock inserts and disk writes: allow 1 disk stream and parallel inserts in memory for right PMJ table (allowed memory is splitted into 2 pieces, while we flush one anoter is allowed for inserts). Use another merge-on-disk strategy (less disk i/o). Allow to set how much files to use for merge-sort on disk. Then bigger then more memory used and then less disk i/o needed. Write bigger intermediate files.