Skip to content

WIP: Add syntax highlighting#11422

Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
kuskarov:add_syntax_highlighting
Jun 8, 2020
Merged

WIP: Add syntax highlighting#11422
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
kuskarov:add_syntax_highlighting

Conversation

@kuskarov
Copy link

@kuskarov kuskarov commented Jun 4, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added syntax highligting to clickhouse-client using ReplXX

Detailed description / Documentation draft:

Syntax is highlighted using Lexer. Input query is passed to Lexer and each token has its own color.

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

@blinkov blinkov added doc-alert pr-feature Pull request with new product feature labels Jun 4, 2020
@qoega qoega marked this pull request as draft June 4, 2020 11:32
@qoega
Copy link
Member

qoega commented Jun 4, 2020

Converted to draft for now.

alexey-milovidov added a commit that referenced this pull request Jun 4, 2020
alexey-milovidov added a commit that referenced this pull request Jun 8, 2020
…hting

Merge #11422 syntax highlighting in clickhouse-client
@alexey-milovidov alexey-milovidov merged commit 348d209 into ClickHouse:master Jun 8, 2020
@vkingnew
Copy link

syntax highligting to clickhouse-client using ReplXX,this function,cloud you give a demo to show it ?

@alexey-milovidov
Copy link
Member

@vkingnew This PR is already merged and basic syntax highlighting is available since 20.5 release.

@alexey-milovidov
Copy link
Member

This PR implements syntax highlighting based on tokens (lexer).
I also have another PR (not merged) with advanced syntax highlighting.

@vkingnew
Copy link

syntax highligting this functions how use?

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jul 29, 2020

@vkingnew

Do I understand your question correctly?

Q: How to enable syntax highlighting in ClickHouse?
A: It is available and enabled since ClickHouse version 20.5.
When you install new ClickHouse version, clickhouse-client will have syntax highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants