Skip to content

Merge #11422 syntax highlighting in clickhouse-client#11458

Merged
alexey-milovidov merged 18 commits intomasterfrom
kuskarov-add_syntax_highlighting
Jun 8, 2020
Merged

Merge #11422 syntax highlighting in clickhouse-client#11458
alexey-milovidov merged 18 commits intomasterfrom
kuskarov-add_syntax_highlighting

Conversation

@alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 4, 2020
@alexey-milovidov
Copy link
Member Author

Before merge:

  • check on white background;
  • provide command line argument to disable highlighting.

@alexey-milovidov
Copy link
Member Author

PS. I have tested performance of big paste manually. It's Ok.

@alexey-milovidov alexey-milovidov marked this pull request as draft June 5, 2020 22:12
@alexey-milovidov
Copy link
Member Author

It does not look alright on white background. So, we cannot merge it.
Need to replace support for colors in replxx, so WHITE will actually mean "intense".

@alexey-milovidov
Copy link
Member Author

Also it's tempting to add more pleasant, naturally distributed 24bit colors as we have in logs.
But only if we can detect whether it's supported by terminal (for example, it does not work in screen by default).

@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Jun 6, 2020
@alexey-milovidov alexey-milovidov marked this pull request as ready for review June 6, 2020 21:29
@alexey-milovidov
Copy link
Member Author

00993_system_parts_race_condition_drop_zookeeper - reported.

@alexey-milovidov
Copy link
Member Author

Need to replace support for colors in replxx, so WHITE will actually mean "intense".

Done.

@alexey-milovidov
Copy link
Member Author

Functional stateless tests (unbundled) — fail: 1, passed: 1873, skipped: 40

The new test cannot work for "unbundled" build, I've disabled it.

Functional stateless tests (debug) — fail: 1, passed: 1904, skipped: 9

Flaky test is reported.

@alexey-milovidov alexey-milovidov merged commit 0d47257 into master Jun 8, 2020
@alexey-milovidov alexey-milovidov deleted the kuskarov-add_syntax_highlighting branch June 8, 2020 02:42
@alexey-milovidov
Copy link
Member Author

I've noticed a bug when I edit some text with parentheses but I cannot reproduce it more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants