Kafka work with formats based on PeekableReadBuffer and other improvements#11599
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jun 20, 2020
Merged
Conversation
11 tasks
azat
reviewed
Jun 15, 2020
tavplubix
reviewed
Jun 16, 2020
filimonov
commented
Jun 17, 2020
Contributor
Author
There was a problem hiding this comment.
This one is really strange. I don't really understand how it happen (it looks the needed checks are there).
filimonov
commented
Jun 17, 2020
src/IO/PeekableReadBuffer.h
Outdated
Contributor
Author
There was a problem hiding this comment.
It is the reason why Template format doesn't work with Kafka.
I've fixed the issue by adding one more flag but after that I get to a very similar problem as segfault with empty message in RowBinaryWithNamesAndTypes
Contributor
Author
There was a problem hiding this comment.
If i fix that i get the following segfault
########################################
(version 20.5.1.1) (from thread 25) (no query) Received signal Segmentation fault (11).
Address: NULL pointer. Access: read. Address not mapped to object.
Stack trace: 0x15c8d9c1 0x15c8db3d 0x1dfbb955 0x1dfb2e05 0x1de7289f 0x1dd79807 0x1d8f80c4 0x1d8f6942 0x1c9c92fd 0x1c9ea01c 0x1c9e9fc7 0x1d8cc3fa 0x1d8cb509 0x1d8ce978 0x1d8ce93d 0x1d8ce8ed 0x1d8ce8bd 0x1d8cda1e 0x15c4f055 0x15c4dfb5 0x1cbcfe12 0x1cbd6f96 0x1cbd1873 0x1cbd4c58 0x1cbd4c2d 0x1cbd4bf1 0x1cbd4bc2 0x1cbd4abc
/src/IO/ReadHelpers.cpp:92: DB::checkString(char const*, DB::ReadBuffer&) @ 0x15c8d9c1 in /usr/bin/clickhouse
/src/IO/ReadHelpers.cpp:119: DB::assertString(char const*, DB::ReadBuffer&) @ 0x15c8db3d in /usr/bin/clickhouse
/src/IO/ReadHelpers.h:181: DB::assertString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ReadBuffer&) @ 0x1dfbb955 in /usr/bin/clickhouse
/src/Processors/Formats/Impl/TemplateRowInputFormat.cpp:171: DB::TemplateRowInputFormat::readRow(std::__1::vector<COW<DB::IColumn>::mutable_ptr<DB::IColumn>, std::__1::allocator<COW<DB::IColumn>::mutable_ptr<DB::IColumn> > >&, DB::RowReadExtension&) @ 0x1dfb2e05 in /usr/bin/clickhouse
Contributor
Author
|
The current state of formats supported by engine=Kafka
TabSeparated = TSV |
Contributor
Author
|
Formats which support for Kafka was fixed in that PR (were not working before)
|
…inor fixes. Add formats tests, fixes for JSONCompactEachRowWithNamesAndTypes, TSVWithNamesAndTypes. Some CR fixes Add sanitizing for kafka_max_block_size and kafka_poll_max_batch_size
adf4ad2 to
9609bd9
Compare
alexey-milovidov
approved these changes
Jun 20, 2020
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jul 3, 2020
After ClickHouse#11599 it is possible that messages of the ReadBufferFromKafkaConsumer will be cleaned-up right in read_kafka_message callback (from KafkaBlockInputStream) if the stop flag isset (i.e. DROP TABLE is waiting the consumer), and if read_kafka_message already processed some rows it will not return 0 and the loop after will try to get current topic from the buffer, which uses messages in the underlying and this will got SIGSEGV: 12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue 12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup 12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11 12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ######################################## 12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11) 12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object. 12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace: 12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse 12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse 12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse 55421 thread (shows that it still waiting for deactivation): 5 std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90 6 DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59 7 DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821 And just in case thread where read_kafka_message is called: 0 DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491 1 DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59 2 DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81 3 DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945 4 DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222 5 DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218 6 DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64 7 DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48 8 DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826 9 DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340 Cc: @filimonov
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jul 3, 2020
As stated by @filimonov it is not relevant (after ClickHouse#11599)
alexey-milovidov
added a commit
that referenced
this pull request
Jul 7, 2020
) * Make topK return Enum for Enum types * parse metadata in parallel when loading tables * Fix error * Fix build * fixup * Update ThreadProfileEvents.cpp * Update browse-code.md (#12047) * Update browse-code.md 纠正了一些翻译错误。 * Update browse-code.md Co-authored-by: Ivan Blinkov <[email protected]> * Bump python-slugify from 1.2.6 to 4.0.1 in /docs/tools Bumps [python-slugify](https://github.com/un33k/python-slugify) from 1.2.6 to 4.0.1. - [Release notes](https://github.com/un33k/python-slugify/releases) - [Changelog](https://github.com/un33k/python-slugify/blob/master/CHANGELOG.md) - [Commits](un33k/python-slugify@1.2.6...4.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update ThreadProfileEvents.cpp * Update README.md * Add a test with negative priority in test_distributed_load_balancing * Fix typo (#12046) * Fix test_allow_introspection. * Try fix labda tuple(LC) argument. * Test image changes * Try fix labda tuple(LC) argument. * Add pvs studio to images * Added test. * fix low card types in merge join (#12035) * Update contrib/poco to ClickHouse-Extras/poco #22 (#12037) * Updated ClickHouse-Extras/poco #22 * Fix defaultValueOfArgumentType * Added test. * Update cpu_synthetic.xml * Moves task shall be started if new storage policy needs them. * Added test for automatic start of background move task. * Add ability to run any image version from packager and runner * Check type of filter for prewhere. * Check type of filter for prewhere. * Check type of filter for prewhere. * Check type of filter for prewhere. * Added test. * Try fix pk in tuple performance Possible approach for fixing #10574 The problem is that prepared sets are built correctly, it is a hash map of key -> set where key is a hash of AST and list of data types (when we a list of tuples of literals). However, when the key is built from the index to try and find if there exists a prepared set that would match it looks for data types of the primary key (see how data_types is populated) because the primary key has only one field (v in my example) it can not find the prepared set. The patch looks for any prepared indexes where data types match for the subset of fields found in primary key, we are not interested in other fields anyway for the purpose of primary key pruning. * Fix partial revokes (complex cases). * Changelog for 20.3.11, 12 * simple changelog script * bump CI * Fix tests. * Add explicit test for a case where AST hashes collide for different prepared sets * [blog] add RSS feed (#12064) * [blog] add rss feed * better title * Update CHANGELOG.md Co-authored-by: Ivan Blinkov <[email protected]> * bump ci * Moved useless S3 logging to TRACE level. * Add a test to cover non-const tuple elemenets (just in case) * Bump * Update query-complexity.md Remove a note about read limits applied on threads level. * Update query-complexity.md * Update query-complexity.md * Update query-complexity.md * DOCS-609: max_server_memory_usage (#11771) * Revolg DOCSUP-1000 add max server memory usage setting (#125) * Add max_server_memory_usage setting, delete max_memory_usage_for_all_queries setting. * Syntax fixed * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Doc for the max_server_memory_usage setting. Updates. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-609: Minor fixes. * CLICKHOUSEDOCS-609: Actualized position of the setting. Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> * Add force_primary_key to a pk in tuple test * DOCS-510: runningAccumulate (#12061) * asiana21-DOCSUP-797 (#117) * docs(runningAccumulate): the function description is added * docs(runningAccumulate): the function description is modified * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * docs(runningAccumulate): some changes * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * docs(runningAccumulate): added ru translation Co-authored-by: asiana21 <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-510: Minor fix. * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: Ivan Blinkov <[email protected]> * CLICKHOUSEDOCS-510: Fixed links. Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove const specifier to allow auto-move (clangtidy) * Rewrite Set lookup to make it more readable * [docs] Sync zh/development/build-osx.md from EN (#12071) * ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN * Update deb image * Don't download image twice * Remove garbage from images * bump ci * Changelog for 20.1, 20.4 * fixup * DOCS-635: Translated the EN version of the AvroConfluent format description (#11930) * DOCSUP-1350 (#128) * edited EN version * add EN and RU translation * minor changes * CLICKHOUSEDOCS-635: Updated the description. Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Evgenia Sudarikova <[email protected]> * Fix tests. * Better PVS image * DOCS-605: Description for the always_fetch_merged_part setting (#11921) * Revolg DOCSUP-998 Document the always_fetch_merged_part setting (#123) * Add always_fetch_merged_part setting * revolg-DOCSUP-998-add_always_fetch_merged_part_setting link fixed * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Add always_fetch_merged_part setting. Updates. * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Add always_fetch_merged_part setting. Updates. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-605: Minor fixes. * CLICKHOUSEDOCS-605: Added Plausible to Adopters. * Update docs/ru/operations/settings/settings.md Co-authored-by: alesapin <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: alesapin <[email protected]> * CLICKHOUSEDOCS-605: Fixed access rights description. Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: alesapin <[email protected]> * Update Dockerfile * revert e9d3c48 * [blog] 'Package Repository Behind CDN' post (#12082) * support iframes from DataLens * initial blog post text * Improve REVOKE command: now it requires only grant/admin option for only access which will be revoked. REVOKE ALL FROM user1 now revokes all granted roles. * Fix limiting the number of threads for VIEW. * Update tips.md * Added test. * Remove pvs studio from images list * Better shutdown and conversion * Reverse arguments * Fix result_rows and result_bytes metrics for selects. * Fix result_rows and result_bytes metrics for selects. * improve breadcrumbs markup * Fix tests. * fix segfault with -StateResample combinators * Less race conditions * fix test with buffer table * [docker] install ca-certificates before the first apt-get update (#12095) * [docker] install ca-certificates before first apt-get update * Update Dockerfile * DOCS-522: max_parser_depth (#12097) * asiana21-DOCSUP-925-max_parser_depth (#132) * docs(max_parser_depth): added the setting description * docs(max_parser_depth): some changes * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * docs(max_parser_depth): added ru translation * docs(max_parser_depth): removed quotation marks Co-authored-by: asiana21 <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-522: Fixed the link. Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> * Rewrite curl dependency in a more ch compatible way - add support of unbundled curl - add CURL::libcurl libraries - avoid explicit linkage of daemon with curl (added with sentry) - set CACHE variables for non-direct users: - mariadb-connector-c - aws-s3-cmake - sentry-native Cc: @alexey-milovidov Cc: @alesapin (requires docker image update) Cc: @abyss7 Refs: #11300 Refs: #8011 Refs: #8905 v2: replace cmake/find/curl.cmake with proper contrib/curl-cmake (as pointed by @abyss7, cmake/find/*.cmake is deprecated) * Added results for AWS Lightsail * (typo) in doc (#12099) * Update polymorphic_parts_l.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_s.xml * kafka: fix SIGSEGV on DROP TABLE After #11599 it is possible that messages of the ReadBufferFromKafkaConsumer will be cleaned-up right in read_kafka_message callback (from KafkaBlockInputStream) if the stop flag isset (i.e. DROP TABLE is waiting the consumer), and if read_kafka_message already processed some rows it will not return 0 and the loop after will try to get current topic from the buffer, which uses messages in the underlying and this will got SIGSEGV: 12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue 12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup 12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11 12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ######################################## 12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11) 12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object. 12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace: 12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse 12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse 12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse 55421 thread (shows that it still waiting for deactivation): 5 std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90 6 DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59 7 DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821 And just in case thread where read_kafka_message is called: 0 DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491 1 DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59 2 DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81 3 DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945 4 DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222 5 DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218 6 DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64 7 DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48 8 DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826 9 DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340 Cc: @filimonov * kafka: check that the data is still usable after parsing * kafka: improve logging during engine shutdown This will help with tracking possible issues, when you need to know was buffer released or not. * kafka: avoid superior polling after DROP/DETACH TABLE Before this patch isStalled() was checked before polledDataUnusable(), and after DROP TABLE isStalled() == true (although this looks tricky). * kafka: remove outdated comment As stated by @filimonov it is not relevant (after #11599) * Added test. * Create codeql-analysis.yml * Tiny fixes * Create anchore-analysis.yml * Update polymorphic_parts_s.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_l.xml * Changelog for 20.5 * Update CHANGELOG.md * Update README.md * Fix test (#12088) * Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV * Add unbundled mode flag * Remove LC converting to Arrow. * Remove LC converting to Arrow. * Move skip lists to clickhouse-test * Remove LC converting to Arrow. * More verbose message about skip * Make skip-list optional * Added test. * Add type column in system.disks * Update clickhouse-test * Fix handling dependency of table with ENGINE=Dictionary on dictionary. * Add test. * Update 01355_CSV_input_format_allow_errors.sh * Update CHANGELOG.md * Added a showcase of minimal Docker image * Added a comment * Added a comment * Added a comment * Formatting * contrib/unixodbc-cmake: Fix build when UNBUNDLED target_compile_definitions may only set INTERFACE properties on IMPORTED targets * Fix version column in replicated version collapsing merge tree (#12121) * poco-cmake: Fix Poco::Data::ODBC target when UNBUNDLED By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? * Add missed <atomic> include in ProxyListConfiguration * Improve performace of reading in order of sorting key. (#11696) * simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test * Do not enable sentry if ENABLE_LIBRARIES is not set * Fail if curl library was enabled and was not found in case of unbundled build * Normalize "pid" file handling #3501 * Update StatusFile.cpp * New ISO8601 year modificators for formatDateTime * Added a test * Include libcurl4-openssl-dev into yandex/clickhouse-deb-builder * Remove harmful code from "geoDistance" #12117 * Update formatDateTime.cpp * Fix warnings from CodeQL * Added a test * Minor modification * Update libdivide to the latest master * Replace exit to abort in libdivide * Fix potential overflow in integer division #12119 * Added a test * Whitespace * Added a test for #4211 * Attempt to fix "Arcadia" build * Rename test * Update arraySum.cpp * Make code clearer: use enum instead of `bool internal`. * Update StorageDictionary.h * Update StorageDictionary.h * ILIKE operator (#12125) * Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> * add parseDateTimeBestEffortUS function (#12028) * add function parseDateTimeBestEffortUS * add test * add doc Co-authored-by: alexey-milovidov <[email protected]> * Cleanup changelog (half done). Now it is acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Additions requested by @filimonov #12104 * Remove underscore as word-break character. This partially reverts #11975 * Fix bad test number * Added a test * Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty * fix segfault with -StateResample combinators * Fix bad code in redundant ORDER BY optimization #10067 * Add a test * Fix error * Autocomplete does not have to work in "Unbundled" build * Whitespace * Style * Test for issue #9088 ALTER DELETE unexpectedly deletes NULL rows * Remove unused potentially dangerous function * Fix mutations interpreter #9088 * Added a test * Added another test just in case * Added yet another test just in case * Update 01358_mutation_delete_null_rows.sql * Fix test * Fix flaky test * [anchore] more detailed Dockerfile scan reports (#12159) * Update array-functions.md (#12130) 修改编码错误 * Update array-functions.md (#12129) 修改编码错误 * [docs] improve redirects destination * Update SECURITY.md (#12161) Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: Alexander Tokmakov <[email protected]> Co-authored-by: kssenii <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: chengy8934 <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Azat Khuzhin <[email protected]> Co-authored-by: MicrochipQ <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Artem Zuikov <[email protected]> Co-authored-by: Alexander Kazakov <[email protected]> Co-authored-by: Vladimir Chebotarev <[email protected]> Co-authored-by: Nicolae Vartolomei <[email protected]> Co-authored-by: filimonov <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: BohuTANG <[email protected]> Co-authored-by: zhang2014 <[email protected]> Co-authored-by: Evgenia Sudarikova <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: manmitya <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Mikhail Filimonov <[email protected]> Co-authored-by: Anton Ivashkin <[email protected]> Co-authored-by: Ilya Yatsishin <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Matwey V. Kornilov <[email protected]> Co-authored-by: vivarum <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: flynn <[email protected]> Co-authored-by: yhgcn <[email protected]> Co-authored-by: Nikita Mikhaylov <[email protected]>
alexey-milovidov
added a commit
that referenced
this pull request
Jul 10, 2020
* kafka: check that the data is still usable after parsing * kafka: improve logging during engine shutdown This will help with tracking possible issues, when you need to know was buffer released or not. * kafka: avoid superior polling after DROP/DETACH TABLE Before this patch isStalled() was checked before polledDataUnusable(), and after DROP TABLE isStalled() == true (although this looks tricky). * kafka: remove outdated comment As stated by @filimonov it is not relevant (after #11599) * Added test. * Create codeql-analysis.yml * Tiny fixes * Create anchore-analysis.yml * Update polymorphic_parts_s.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_l.xml * Changelog for 20.5 * Update CHANGELOG.md * Update README.md * Fix test (#12088) * Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV * Add unbundled mode flag * Remove LC converting to Arrow. * Remove LC converting to Arrow. * Move skip lists to clickhouse-test * Remove LC converting to Arrow. * More verbose message about skip * Make skip-list optional * Added test. * Create initializeAggregation to initialize an aggregation function based on a value * Add type column in system.disks * Update clickhouse-test * fix test with UBSan * Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. * Fix handling dependency of table with ENGINE=Dictionary on dictionary. * Add test. * Update 01355_CSV_input_format_allow_errors.sh * Update CHANGELOG.md * Update Dockerfile * Added a showcase of minimal Docker image * Added a comment * Added a comment * Added a comment * Formatting * contrib/unixodbc-cmake: Fix build when UNBUNDLED target_compile_definitions may only set INTERFACE properties on IMPORTED targets * Fix version column in replicated version collapsing merge tree (#12121) * poco-cmake: Fix Poco::Data::ODBC target when UNBUNDLED By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? * Add missed <atomic> include in ProxyListConfiguration * Improve performace of reading in order of sorting key. (#11696) * simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test * Do not enable sentry if ENABLE_LIBRARIES is not set * Fail if curl library was enabled and was not found in case of unbundled build * Normalize "pid" file handling #3501 * Update StatusFile.cpp * New ISO8601 year modificators for formatDateTime * Added a test * Include libcurl4-openssl-dev into yandex/clickhouse-deb-builder * Remove harmful code from "geoDistance" #12117 * Update formatDateTime.cpp * Fix warnings from CodeQL * Added a test * Minor modification * Update libdivide to the latest master * Replace exit to abort in libdivide * Fix potential overflow in integer division #12119 * Added a test * Whitespace * Added a test for #4211 * Attempt to fix "Arcadia" build * Rename test * Update arraySum.cpp * Run perf tests with memory sampling (for allocations >1M) This is to know the memory allocation size distribution, that can be obtained later from left-metric-log.tsv. This is an attempt to tune tcmalloc (new CPP version by google) to use lock-free part of the allocator for typical allocations (and it is a bad idea just to increase kMaxSize there, since number of allocation for each size class is also important). P.S. hope that this file will be applied, if no, then the same effect can be reached by tunning defaults in Settings.h Refs: #11590 Cc: @akuzm * Make code clearer: use enum instead of `bool internal`. * Update StorageDictionary.h * Update StorageDictionary.h * ILIKE operator (#12125) * Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> * Update SortDescription.h * Update AggregateDescription.cpp * add parseDateTimeBestEffortUS function (#12028) * add function parseDateTimeBestEffortUS * add test * add doc Co-authored-by: alexey-milovidov <[email protected]> * Cleanup changelog (half done). Now it is acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Additions requested by @filimonov #12104 * Remove underscore as word-break character. This partially reverts #11975 * Fix bad test number * Added a test * Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty * fix segfault with -StateResample combinators * Fix bad code in redundant ORDER BY optimization #10067 * Add a test * Support KILL QUERY [connection_id] for MySQL * Fix error * Autocomplete does not have to work in "Unbundled" build * Fix transform query for external databases in presense of aliases #12032 * Whitespace * Add MySQL to ClickHouse query replacement mapping table * Style * update ya.make * Added function "hasThreadFuzzer" * Fix test under ThreadFuzzer * Test for issue #9088 ALTER DELETE unexpectedly deletes NULL rows * Remove unused potentially dangerous function * Fix mutations interpreter #9088 * Added a test * Added another test just in case * Added yet another test just in case * Update 01358_mutation_delete_null_rows.sql * Fix test * Fix flaky test * Attempt to fix flaky test 00721_force_by_identical_result_after_merge_zookeeper * [anchore] more detailed Dockerfile scan reports (#12159) * Update Dockerfile * Update array-functions.md (#12130) 修改编码错误 * Add integration test for mysql replacement query * Update array-functions.md (#12129) 修改编码错误 * fix ubsan final * [docs] improve redirects destination * Update SECURITY.md (#12161) * Update Dockerfile * Update questdb_sum_double.xml * Place common docker compose files to integration docker container * done * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function (#12156) * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function Signed-off-by: Slach <[email protected]> * small russian fixes Signed-off-by: Slach <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove -v from ninja * [docs] introduction for integration table engines (#12167) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * Fix #10437, CR fixes * fix style * add select final to test * Same change for Kafka - just in case, and to make it conform. * [docs] add redirect from an introduction index page (#12176) * [website] add apple-touch-icon (#12164) * Better assert * Don't split dictionary source's table name into schema and table name itself if ODBC driver doesn't support schema. * Sync reference file with changes in sql file * [docs] introduction for third-party interfaces (#12175) * [docs] introduction for third-party interfaces * Update index.md * Update index.md * [docs] introduction for special table engines (#12170) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * [docs] introduction for special table engines * Update index.md * Update index.md * split * A test for UInt8 as bool * Included const uint8 values in test * changelog fixes * remove questionable functionality * Tests for fixed issues #10846 and #7347 * Simple (and fast) inplace fix for UInt8 -> bool * style fix for #12152 * Added test for #3767 * Update zh kafka.md title (#12192) * Update index.md (#12191) Fix merge link broken * changelog fixes * DOCSUP-1348 Russian translation for new functions (#133) (#12194) * Russian translation for new functions * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Minor updates to russian text. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> * Add runner for testflows * No color * throw exception on redirect limit in S3 request * [docs] add intrdocution for commercial page (#12187) * DOCS-647: toStartOfSecond (#12190) * DOCSUP-1120 Documentation for the toStartOfSecond function (#131) * Doc toStartOfSecond function * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Minor update for english text, russian translation added. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-647: Minor text edits. * Update docs/en/sql-reference/functions/date-time-functions.md * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * [docs] refactor Domains overview (#12186) * Add to images.json * Sanitize LINK_LIBRARIES property for the directories (#12160) When you will try to link target with the directory (that exists), cmake will skip this without an error, only the following warning will be reported: target_link_libraries(main /tmp) WARNING: Target "main" requests linking to directory "/tmp". Targets may link only to libraries. CMake is dropping the item. And there is no cmake policy that controls this. (I guess the reason that it is allowed is because of FRAMEWORK for OSX). So to avoid error-prone cmake rules, this can be sanitized. There are the following ways: - overwrite target_link_libraries()/link_libraries() and check *before* calling real macro, but this requires duplicate all supported syntax -- too complex - overwrite target_link_libraries() and check LINK_LIBRARIES property, this works great -- but cannot be used with link_libraries() - use BUILDSYSTEM_TARGETS property to get list of all targets and sanitize -- this will work. I also tested it with the following patch: $ git di diff --git a/base/daemon/CMakeLists.txt b/base/daemon/CMakeLists.txt index 26d59a5..35e6ff6432 100644 --- a/base/daemon/CMakeLists.txt +++ b/base/daemon/CMakeLists.txt @@ -9,4 +9,5 @@ target_link_libraries (daemon PUBLIC loggers PRIVATE clickhouse_common_io clickh if (USE_SENTRY) target_link_libraries (daemon PRIVATE ${SENTRY_LIBRARY}) + target_link_libraries (daemon PRIVATE /tmp) endif () And it works: CMake Error at cmake/sanitize_target_link_libraries.cmake:48 (message): daemon requested to link with directory: /tmp Call Stack (most recent call first): cmake/sanitize_target_link_libraries.cmake:55 (sanitize_link_libraries) CMakeLists.txt:425 (include) Refs: #12041 * Revert "Run perf tests with memory sampling (for allocations >1M)" * too slow * [docs] add intrdocution for statements page (#12189) * [docs] add intrdocution for statements page * Update index.md * Update index.md * Update README.md * Update README.md * Update README.md * Rename ident to indent. * Fix minor issues after #12196 * Implement getLeastSuperType for LowCardinality #8212 * Implement supertype for LowCardinality * Whitespace * Update test * Added a test for PaddedPODArray just in case * Add documentation for arrayFill * Non-significant changes * Update README.md * Update int_parsing.xml * Update build.sh * Update packager * Hide nonzero error code on testflows runner * try remove strange logic in DuplicateOrderByVisitor (#12267) * Update README.md Co-authored-by: Azat Khuzhin <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Mikhail Filimonov <[email protected]> Co-authored-by: Guillaume Tassery <[email protected]> Co-authored-by: Anton Ivashkin <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: Ilya Yatsishin <[email protected]> Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Matwey V. Kornilov <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: vivarum <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: flynn <[email protected]> Co-authored-by: BohuTANG <[email protected]> Co-authored-by: yhgcn <[email protected]> Co-authored-by: Eugene Klimov <[email protected]> Co-authored-by: Nikita Mikhailov <[email protected]> Co-authored-by: Alexander Kazakov <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Artem Zuikov <[email protected]>
alexey-milovidov
added a commit
that referenced
this pull request
Jul 10, 2020
* kafka: remove outdated comment As stated by @filimonov it is not relevant (after #11599) * Added test. * Create codeql-analysis.yml * Tiny fixes * Create anchore-analysis.yml * Update polymorphic_parts_s.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_l.xml * Changelog for 20.5 * Update CHANGELOG.md * Update README.md * Fix test (#12088) * Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV * Add unbundled mode flag * Remove LC converting to Arrow. * Remove LC converting to Arrow. * Move skip lists to clickhouse-test * Remove LC converting to Arrow. * More verbose message about skip * Make skip-list optional * Added test. * Create initializeAggregation to initialize an aggregation function based on a value * Add type column in system.disks * Update clickhouse-test * fix test with UBSan * Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. * Fix handling dependency of table with ENGINE=Dictionary on dictionary. * Add test. * Update 01355_CSV_input_format_allow_errors.sh * Update CHANGELOG.md * Update Dockerfile * Added a showcase of minimal Docker image * Added a comment * Added a comment * Added a comment * Formatting * contrib/unixodbc-cmake: Fix build when UNBUNDLED target_compile_definitions may only set INTERFACE properties on IMPORTED targets * Fix version column in replicated version collapsing merge tree (#12121) * poco-cmake: Fix Poco::Data::ODBC target when UNBUNDLED By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? * Add missed <atomic> include in ProxyListConfiguration * Improve performace of reading in order of sorting key. (#11696) * simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test * Do not enable sentry if ENABLE_LIBRARIES is not set * Fail if curl library was enabled and was not found in case of unbundled build * Normalize "pid" file handling #3501 * Update StatusFile.cpp * New ISO8601 year modificators for formatDateTime * Added a test * Include libcurl4-openssl-dev into yandex/clickhouse-deb-builder * Remove harmful code from "geoDistance" #12117 * Update formatDateTime.cpp * Fix warnings from CodeQL * Added a test * Minor modification * Update libdivide to the latest master * Replace exit to abort in libdivide * Fix potential overflow in integer division #12119 * Added a test * Whitespace * Added a test for #4211 * Attempt to fix "Arcadia" build * Rename test * Update arraySum.cpp * Run perf tests with memory sampling (for allocations >1M) This is to know the memory allocation size distribution, that can be obtained later from left-metric-log.tsv. This is an attempt to tune tcmalloc (new CPP version by google) to use lock-free part of the allocator for typical allocations (and it is a bad idea just to increase kMaxSize there, since number of allocation for each size class is also important). P.S. hope that this file will be applied, if no, then the same effect can be reached by tunning defaults in Settings.h Refs: #11590 Cc: @akuzm * Make code clearer: use enum instead of `bool internal`. * Update StorageDictionary.h * Update StorageDictionary.h * ILIKE operator (#12125) * Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> * Update SortDescription.h * Update AggregateDescription.cpp * add parseDateTimeBestEffortUS function (#12028) * add function parseDateTimeBestEffortUS * add test * add doc Co-authored-by: alexey-milovidov <[email protected]> * Cleanup changelog (half done). Now it is acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Additions requested by @filimonov #12104 * Remove underscore as word-break character. This partially reverts #11975 * Fix bad test number * Added a test * Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty * fix segfault with -StateResample combinators * Fix bad code in redundant ORDER BY optimization #10067 * Add a test * Support KILL QUERY [connection_id] for MySQL * Fix error * Autocomplete does not have to work in "Unbundled" build * Fix transform query for external databases in presense of aliases #12032 * Whitespace * Add MySQL to ClickHouse query replacement mapping table * Style * update ya.make * Added function "hasThreadFuzzer" * Fix test under ThreadFuzzer * Test for issue #9088 ALTER DELETE unexpectedly deletes NULL rows * Remove unused potentially dangerous function * Fix mutations interpreter #9088 * Added a test * Added another test just in case * Added yet another test just in case * Update 01358_mutation_delete_null_rows.sql * Fix test * Fix flaky test * Attempt to fix flaky test 00721_force_by_identical_result_after_merge_zookeeper * [anchore] more detailed Dockerfile scan reports (#12159) * Update Dockerfile * Update array-functions.md (#12130) 修改编码错误 * Add integration test for mysql replacement query * Update array-functions.md (#12129) 修改编码错误 * fix ubsan final * [docs] improve redirects destination * Update SECURITY.md (#12161) * Update Dockerfile * Update questdb_sum_double.xml * Place common docker compose files to integration docker container * done * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function (#12156) * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function Signed-off-by: Slach <[email protected]> * small russian fixes Signed-off-by: Slach <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove -v from ninja * [docs] introduction for integration table engines (#12167) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * Fix #10437, CR fixes * fix style * add select final to test * Same change for Kafka - just in case, and to make it conform. * [docs] add redirect from an introduction index page (#12176) * [website] add apple-touch-icon (#12164) * Better assert * Don't split dictionary source's table name into schema and table name itself if ODBC driver doesn't support schema. * Sync reference file with changes in sql file * [docs] introduction for third-party interfaces (#12175) * [docs] introduction for third-party interfaces * Update index.md * Update index.md * [docs] introduction for special table engines (#12170) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * [docs] introduction for special table engines * Update index.md * Update index.md * split * A test for UInt8 as bool * Included const uint8 values in test * changelog fixes * remove questionable functionality * Tests for fixed issues #10846 and #7347 * Simple (and fast) inplace fix for UInt8 -> bool * style fix for #12152 * Added test for #3767 * Update zh kafka.md title (#12192) * Update index.md (#12191) Fix merge link broken * changelog fixes * DOCSUP-1348 Russian translation for new functions (#133) (#12194) * Russian translation for new functions * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Minor updates to russian text. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> * Add runner for testflows * No color * throw exception on redirect limit in S3 request * [docs] add intrdocution for commercial page (#12187) * DOCS-647: toStartOfSecond (#12190) * DOCSUP-1120 Documentation for the toStartOfSecond function (#131) * Doc toStartOfSecond function * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Minor update for english text, russian translation added. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-647: Minor text edits. * Update docs/en/sql-reference/functions/date-time-functions.md * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * [docs] refactor Domains overview (#12186) * Add to images.json * Sanitize LINK_LIBRARIES property for the directories (#12160) When you will try to link target with the directory (that exists), cmake will skip this without an error, only the following warning will be reported: target_link_libraries(main /tmp) WARNING: Target "main" requests linking to directory "/tmp". Targets may link only to libraries. CMake is dropping the item. And there is no cmake policy that controls this. (I guess the reason that it is allowed is because of FRAMEWORK for OSX). So to avoid error-prone cmake rules, this can be sanitized. There are the following ways: - overwrite target_link_libraries()/link_libraries() and check *before* calling real macro, but this requires duplicate all supported syntax -- too complex - overwrite target_link_libraries() and check LINK_LIBRARIES property, this works great -- but cannot be used with link_libraries() - use BUILDSYSTEM_TARGETS property to get list of all targets and sanitize -- this will work. I also tested it with the following patch: $ git di diff --git a/base/daemon/CMakeLists.txt b/base/daemon/CMakeLists.txt index 26d59a5..35e6ff6432 100644 --- a/base/daemon/CMakeLists.txt +++ b/base/daemon/CMakeLists.txt @@ -9,4 +9,5 @@ target_link_libraries (daemon PUBLIC loggers PRIVATE clickhouse_common_io clickh if (USE_SENTRY) target_link_libraries (daemon PRIVATE ${SENTRY_LIBRARY}) + target_link_libraries (daemon PRIVATE /tmp) endif () And it works: CMake Error at cmake/sanitize_target_link_libraries.cmake:48 (message): daemon requested to link with directory: /tmp Call Stack (most recent call first): cmake/sanitize_target_link_libraries.cmake:55 (sanitize_link_libraries) CMakeLists.txt:425 (include) Refs: #12041 * Revert "Run perf tests with memory sampling (for allocations >1M)" * too slow * [docs] add intrdocution for statements page (#12189) * [docs] add intrdocution for statements page * Update index.md * Update index.md * Update README.md * Update README.md * Update README.md * Rename ident to indent. * Fix minor issues after #12196 * Implement getLeastSuperType for LowCardinality #8212 * Implement supertype for LowCardinality * Whitespace * Update test * Added a test for PaddedPODArray just in case * Add documentation for arrayFill * Fix ugly ugliness * Added a test * Non-significant changes * Update README.md * Update int_parsing.xml * Update build.sh * Update packager * Hide nonzero error code on testflows runner * try remove strange logic in DuplicateOrderByVisitor (#12267) * Update README.md Co-authored-by: Azat Khuzhin <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Mikhail Filimonov <[email protected]> Co-authored-by: Guillaume Tassery <[email protected]> Co-authored-by: Anton Ivashkin <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: Ilya Yatsishin <[email protected]> Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Matwey V. Kornilov <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: vivarum <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: flynn <[email protected]> Co-authored-by: BohuTANG <[email protected]> Co-authored-by: yhgcn <[email protected]> Co-authored-by: Eugene Klimov <[email protected]> Co-authored-by: Nikita Mikhailov <[email protected]> Co-authored-by: Alexander Kazakov <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Artem Zuikov <[email protected]>
alesapin
added a commit
that referenced
this pull request
Jul 10, 2020
…est (#12369) * fix test with buffer table * Adding a template of the SRS with the notes how to use it. * Small changes to the SRS template. * Removing unnecessary text. * Fix small typo. * [docker] install ca-certificates before the first apt-get update (#12095) * [docker] install ca-certificates before first apt-get update * Update Dockerfile * DOCS-522: max_parser_depth (#12097) * asiana21-DOCSUP-925-max_parser_depth (#132) * docs(max_parser_depth): added the setting description * docs(max_parser_depth): some changes * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * docs(max_parser_depth): added ru translation * docs(max_parser_depth): removed quotation marks Co-authored-by: asiana21 <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-522: Fixed the link. Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> * Rewrite curl dependency in a more ch compatible way - add support of unbundled curl - add CURL::libcurl libraries - avoid explicit linkage of daemon with curl (added with sentry) - set CACHE variables for non-direct users: - mariadb-connector-c - aws-s3-cmake - sentry-native Cc: @alexey-milovidov Cc: @alesapin (requires docker image update) Cc: @abyss7 Refs: #11300 Refs: #8011 Refs: #8905 v2: replace cmake/find/curl.cmake with proper contrib/curl-cmake (as pointed by @abyss7, cmake/find/*.cmake is deprecated) * Added results for AWS Lightsail * (typo) in doc (#12099) * Update polymorphic_parts_l.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_s.xml * kafka: fix SIGSEGV on DROP TABLE After #11599 it is possible that messages of the ReadBufferFromKafkaConsumer will be cleaned-up right in read_kafka_message callback (from KafkaBlockInputStream) if the stop flag isset (i.e. DROP TABLE is waiting the consumer), and if read_kafka_message already processed some rows it will not return 0 and the loop after will try to get current topic from the buffer, which uses messages in the underlying and this will got SIGSEGV: 12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue 12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup 12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11 12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ######################################## 12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11) 12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object. 12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace: 12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse 12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse 12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse 55421 thread (shows that it still waiting for deactivation): 5 std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90 6 DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59 7 DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821 And just in case thread where read_kafka_message is called: 0 DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491 1 DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59 2 DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81 3 DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945 4 DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222 5 DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218 6 DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64 7 DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48 8 DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826 9 DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340 Cc: @filimonov * kafka: check that the data is still usable after parsing * kafka: improve logging during engine shutdown This will help with tracking possible issues, when you need to know was buffer released or not. * kafka: avoid superior polling after DROP/DETACH TABLE Before this patch isStalled() was checked before polledDataUnusable(), and after DROP TABLE isStalled() == true (although this looks tricky). * kafka: remove outdated comment As stated by @filimonov it is not relevant (after #11599) * Added test. * Create codeql-analysis.yml * Tiny fixes * Create anchore-analysis.yml * Update polymorphic_parts_s.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_l.xml * Changelog for 20.5 * Update CHANGELOG.md * Update README.md * Fix test (#12088) * Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV * Add unbundled mode flag * Remove LC converting to Arrow. * Remove LC converting to Arrow. * Move skip lists to clickhouse-test * Remove LC converting to Arrow. * More verbose message about skip * Make skip-list optional * Added test. * Create initializeAggregation to initialize an aggregation function based on a value * Add type column in system.disks * Update clickhouse-test * fix test with UBSan * Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. * Fix handling dependency of table with ENGINE=Dictionary on dictionary. * Add test. * Update 01355_CSV_input_format_allow_errors.sh * Update CHANGELOG.md * Update Dockerfile * Added a showcase of minimal Docker image * Added a comment * Added a comment * Added a comment * Formatting * contrib/unixodbc-cmake: Fix build when UNBUNDLED target_compile_definitions may only set INTERFACE properties on IMPORTED targets * Fix version column in replicated version collapsing merge tree (#12121) * poco-cmake: Fix Poco::Data::ODBC target when UNBUNDLED By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? * Add missed <atomic> include in ProxyListConfiguration * Improve performace of reading in order of sorting key. (#11696) * simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test * Do not enable sentry if ENABLE_LIBRARIES is not set * Fail if curl library was enabled and was not found in case of unbundled build * Normalize "pid" file handling #3501 * Update StatusFile.cpp * New ISO8601 year modificators for formatDateTime * Added a test * Include libcurl4-openssl-dev into yandex/clickhouse-deb-builder * Remove harmful code from "geoDistance" #12117 * Update formatDateTime.cpp * Fix warnings from CodeQL * Added a test * Minor modification * Update libdivide to the latest master * Replace exit to abort in libdivide * Fix potential overflow in integer division #12119 * Added a test * Whitespace * Added a test for #4211 * Attempt to fix "Arcadia" build * Rename test * Update arraySum.cpp * Run perf tests with memory sampling (for allocations >1M) This is to know the memory allocation size distribution, that can be obtained later from left-metric-log.tsv. This is an attempt to tune tcmalloc (new CPP version by google) to use lock-free part of the allocator for typical allocations (and it is a bad idea just to increase kMaxSize there, since number of allocation for each size class is also important). P.S. hope that this file will be applied, if no, then the same effect can be reached by tunning defaults in Settings.h Refs: #11590 Cc: @akuzm * Make code clearer: use enum instead of `bool internal`. * Update StorageDictionary.h * Update StorageDictionary.h * ILIKE operator (#12125) * Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> * Update SortDescription.h * Update AggregateDescription.cpp * add parseDateTimeBestEffortUS function (#12028) * add function parseDateTimeBestEffortUS * add test * add doc Co-authored-by: alexey-milovidov <[email protected]> * Cleanup changelog (half done). Now it is acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Additions requested by @filimonov #12104 * Remove underscore as word-break character. This partially reverts #11975 * Fix bad test number * Added a test * Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty * fix segfault with -StateResample combinators * Fix bad code in redundant ORDER BY optimization #10067 * Add a test * Support KILL QUERY [connection_id] for MySQL * Fix error * Autocomplete does not have to work in "Unbundled" build * Fix transform query for external databases in presense of aliases #12032 * Whitespace * Add MySQL to ClickHouse query replacement mapping table * Style * update ya.make * Added function "hasThreadFuzzer" * Fix test under ThreadFuzzer * Test for issue #9088 ALTER DELETE unexpectedly deletes NULL rows * Remove unused potentially dangerous function * Fix mutations interpreter #9088 * Added a test * Added another test just in case * Added yet another test just in case * Update 01358_mutation_delete_null_rows.sql * Fix test * Fix flaky test * Attempt to fix flaky test 00721_force_by_identical_result_after_merge_zookeeper * [anchore] more detailed Dockerfile scan reports (#12159) * Update Dockerfile * Update array-functions.md (#12130) 修改编码错误 * Add integration test for mysql replacement query * Update array-functions.md (#12129) 修改编码错误 * fix ubsan final * [docs] improve redirects destination * Update SECURITY.md (#12161) * Update Dockerfile * Update questdb_sum_double.xml * Place common docker compose files to integration docker container * done * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function (#12156) * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function Signed-off-by: Slach <[email protected]> * small russian fixes Signed-off-by: Slach <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove -v from ninja * [docs] introduction for integration table engines (#12167) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * Fix #10437, CR fixes * fix style * add select final to test * Same change for Kafka - just in case, and to make it conform. * [docs] add redirect from an introduction index page (#12176) * [website] add apple-touch-icon (#12164) * Better assert * Don't split dictionary source's table name into schema and table name itself if ODBC driver doesn't support schema. * Sync reference file with changes in sql file * [docs] introduction for third-party interfaces (#12175) * [docs] introduction for third-party interfaces * Update index.md * Update index.md * [docs] introduction for special table engines (#12170) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * [docs] introduction for special table engines * Update index.md * Update index.md * split * A test for UInt8 as bool * Included const uint8 values in test * changelog fixes * Tests for fixed issues #10846 and #7347 * Simple (and fast) inplace fix for UInt8 -> bool * style fix for #12152 * Added test for #3767 * Update zh kafka.md title (#12192) * Update index.md (#12191) Fix merge link broken * changelog fixes * DOCSUP-1348 Russian translation for new functions (#133) (#12194) * Russian translation for new functions * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Minor updates to russian text. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> * Add runner for testflows * No color * throw exception on redirect limit in S3 request * [docs] add intrdocution for commercial page (#12187) * DOCS-647: toStartOfSecond (#12190) * DOCSUP-1120 Documentation for the toStartOfSecond function (#131) * Doc toStartOfSecond function * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: BayoNet <[email protected]> * Minor update for english text, russian translation added. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-647: Minor text edits. * Update docs/en/sql-reference/functions/date-time-functions.md * Update docs/en/sql-reference/functions/date-time-functions.md Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * [docs] refactor Domains overview (#12186) * Add to images.json * Sanitize LINK_LIBRARIES property for the directories (#12160) When you will try to link target with the directory (that exists), cmake will skip this without an error, only the following warning will be reported: target_link_libraries(main /tmp) WARNING: Target "main" requests linking to directory "/tmp". Targets may link only to libraries. CMake is dropping the item. And there is no cmake policy that controls this. (I guess the reason that it is allowed is because of FRAMEWORK for OSX). So to avoid error-prone cmake rules, this can be sanitized. There are the following ways: - overwrite target_link_libraries()/link_libraries() and check *before* calling real macro, but this requires duplicate all supported syntax -- too complex - overwrite target_link_libraries() and check LINK_LIBRARIES property, this works great -- but cannot be used with link_libraries() - use BUILDSYSTEM_TARGETS property to get list of all targets and sanitize -- this will work. I also tested it with the following patch: $ git di diff --git a/base/daemon/CMakeLists.txt b/base/daemon/CMakeLists.txt index 26d59a5..35e6ff6432 100644 --- a/base/daemon/CMakeLists.txt +++ b/base/daemon/CMakeLists.txt @@ -9,4 +9,5 @@ target_link_libraries (daemon PUBLIC loggers PRIVATE clickhouse_common_io clickh if (USE_SENTRY) target_link_libraries (daemon PRIVATE ${SENTRY_LIBRARY}) + target_link_libraries (daemon PRIVATE /tmp) endif () And it works: CMake Error at cmake/sanitize_target_link_libraries.cmake:48 (message): daemon requested to link with directory: /tmp Call Stack (most recent call first): cmake/sanitize_target_link_libraries.cmake:55 (sanitize_link_libraries) CMakeLists.txt:425 (include) Refs: #12041 * Revert "Run perf tests with memory sampling (for allocations >1M)" * too slow * [docs] add intrdocution for statements page (#12189) * [docs] add intrdocution for statements page * Update index.md * Update index.md * Update README.md * Update README.md * Update README.md * Rename ident to indent. * Fix minor issues after #12196 * Whitespace * Update test * Add documentation for arrayFill * Non-significant changes * Update README.md Co-authored-by: Anton Popov <[email protected]> Co-authored-by: Vitaliy Zakaznikov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Azat Khuzhin <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: manmitya <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Mikhail Filimonov <[email protected]> Co-authored-by: Guillaume Tassery <[email protected]> Co-authored-by: Anton Ivashkin <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: Ilya Yatsishin <[email protected]> Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Matwey V. Kornilov <[email protected]> Co-authored-by: vivarum <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: flynn <[email protected]> Co-authored-by: BohuTANG <[email protected]> Co-authored-by: yhgcn <[email protected]> Co-authored-by: Eugene Klimov <[email protected]> Co-authored-by: Nikita Mikhailov <[email protected]> Co-authored-by: Alexander Kazakov <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]>
alesapin
added a commit
that referenced
this pull request
Jul 10, 2020
#12259) * simple changelog script * bump CI * Fix tests. * Add explicit test for a case where AST hashes collide for different prepared sets * [blog] add RSS feed (#12064) * [blog] add rss feed * better title * Update CHANGELOG.md Co-authored-by: Ivan Blinkov <[email protected]> * bump ci * Moved useless S3 logging to TRACE level. * Add a test to cover non-const tuple elemenets (just in case) * Bump * Update query-complexity.md Remove a note about read limits applied on threads level. * Update query-complexity.md * Update query-complexity.md * Update query-complexity.md * DOCS-609: max_server_memory_usage (#11771) * Revolg DOCSUP-1000 add max server memory usage setting (#125) * Add max_server_memory_usage setting, delete max_memory_usage_for_all_queries setting. * Syntax fixed * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Doc for the max_server_memory_usage setting. Updates. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-609: Minor fixes. * CLICKHOUSEDOCS-609: Actualized position of the setting. Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> * Add force_primary_key to a pk in tuple test * DOCS-510: runningAccumulate (#12061) * asiana21-DOCSUP-797 (#117) * docs(runningAccumulate): the function description is added * docs(runningAccumulate): the function description is modified * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * docs(runningAccumulate): some changes * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: BayoNet <[email protected]> * docs(runningAccumulate): added ru translation Co-authored-by: asiana21 <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-510: Minor fix. * Update docs/en/sql-reference/functions/other-functions.md Co-authored-by: Ivan Blinkov <[email protected]> * CLICKHOUSEDOCS-510: Fixed links. Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove const specifier to allow auto-move (clangtidy) * Rewrite Set lookup to make it more readable * [docs] Sync zh/development/build-osx.md from EN (#12071) * ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN * Update deb image * Don't download image twice * Remove garbage from images * bump ci * Changelog for 20.1, 20.4 * fixup * DOCS-635: Translated the EN version of the AvroConfluent format description (#11930) * DOCSUP-1350 (#128) * edited EN version * add EN and RU translation * minor changes * CLICKHOUSEDOCS-635: Updated the description. Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: Evgenia Sudarikova <[email protected]> * Fix tests. * Better PVS image * DOCS-605: Description for the always_fetch_merged_part setting (#11921) * Revolg DOCSUP-998 Document the always_fetch_merged_part setting (#123) * Add always_fetch_merged_part setting * revolg-DOCSUP-998-add_always_fetch_merged_part_setting link fixed * Apply suggestions from code review Co-authored-by: BayoNet <[email protected]> * Add always_fetch_merged_part setting. Updates. * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Add always_fetch_merged_part setting. Updates. Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-605: Minor fixes. * CLICKHOUSEDOCS-605: Added Plausible to Adopters. * Update docs/ru/operations/settings/settings.md Co-authored-by: alesapin <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: alesapin <[email protected]> * CLICKHOUSEDOCS-605: Fixed access rights description. Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: alesapin <[email protected]> * Update Dockerfile * revert e9d3c48 * [blog] 'Package Repository Behind CDN' post (#12082) * support iframes from DataLens * initial blog post text * Improve REVOKE command: now it requires only grant/admin option for only access which will be revoked. REVOKE ALL FROM user1 now revokes all granted roles. * Fix limiting the number of threads for VIEW. * Update tips.md * Added test. * Remove pvs studio from images list * Better shutdown and conversion * Reverse arguments * Fix result_rows and result_bytes metrics for selects. * Fix result_rows and result_bytes metrics for selects. * improve breadcrumbs markup * Fix tests. * fix segfault with -StateResample combinators * Less race conditions * fix test with buffer table * [docker] install ca-certificates before the first apt-get update (#12095) * [docker] install ca-certificates before first apt-get update * Update Dockerfile * DOCS-522: max_parser_depth (#12097) * asiana21-DOCSUP-925-max_parser_depth (#132) * docs(max_parser_depth): added the setting description * docs(max_parser_depth): some changes * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * Update docs/en/operations/settings/settings.md Co-authored-by: BayoNet <[email protected]> * docs(max_parser_depth): added ru translation * docs(max_parser_depth): removed quotation marks Co-authored-by: asiana21 <[email protected]> Co-authored-by: BayoNet <[email protected]> * CLICKHOUSEDOCS-522: Fixed the link. Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> * Rewrite curl dependency in a more ch compatible way - add support of unbundled curl - add CURL::libcurl libraries - avoid explicit linkage of daemon with curl (added with sentry) - set CACHE variables for non-direct users: - mariadb-connector-c - aws-s3-cmake - sentry-native Cc: @alexey-milovidov Cc: @alesapin (requires docker image update) Cc: @abyss7 Refs: #11300 Refs: #8011 Refs: #8905 v2: replace cmake/find/curl.cmake with proper contrib/curl-cmake (as pointed by @abyss7, cmake/find/*.cmake is deprecated) * Added results for AWS Lightsail * (typo) in doc (#12099) * Update polymorphic_parts_l.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_s.xml * kafka: fix SIGSEGV on DROP TABLE After #11599 it is possible that messages of the ReadBufferFromKafkaConsumer will be cleaned-up right in read_kafka_message callback (from KafkaBlockInputStream) if the stop flag isset (i.e. DROP TABLE is waiting the consumer), and if read_kafka_message already processed some rows it will not return 0 and the loop after will try to get current topic from the buffer, which uses messages in the underlying and this will got SIGSEGV: 12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue 12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup 12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11 12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ######################################## 12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11) 12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object. 12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace: 12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse 12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse 12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse 12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse 55421 thread (shows that it still waiting for deactivation): 5 std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90 6 DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59 7 DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821 And just in case thread where read_kafka_message is called: 0 DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491 1 DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59 2 DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81 3 DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945 4 DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222 5 DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218 6 DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64 7 DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48 8 DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826 9 DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340 Cc: @filimonov * kafka: check that the data is still usable after parsing * kafka: improve logging during engine shutdown This will help with tracking possible issues, when you need to know was buffer released or not. * kafka: avoid superior polling after DROP/DETACH TABLE Before this patch isStalled() was checked before polledDataUnusable(), and after DROP TABLE isStalled() == true (although this looks tricky). * kafka: remove outdated comment As stated by @filimonov it is not relevant (after #11599) * Added test. * Create codeql-analysis.yml * Tiny fixes * Create anchore-analysis.yml * Update polymorphic_parts_s.xml * Update polymorphic_parts_m.xml * Update polymorphic_parts_l.xml * Changelog for 20.5 * Update CHANGELOG.md * Update README.md * Fix test (#12088) * Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV * Add unbundled mode flag * Remove LC converting to Arrow. * Remove LC converting to Arrow. * Move skip lists to clickhouse-test * Remove LC converting to Arrow. * More verbose message about skip * Make skip-list optional * Added test. * Create initializeAggregation to initialize an aggregation function based on a value * Add type column in system.disks * Update clickhouse-test * fix test with UBSan * Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. * Fix handling dependency of table with ENGINE=Dictionary on dictionary. * Add test. * Update 01355_CSV_input_format_allow_errors.sh * Update CHANGELOG.md * Update Dockerfile * Added a showcase of minimal Docker image * Added a comment * Added a comment * Added a comment * Formatting * contrib/unixodbc-cmake: Fix build when UNBUNDLED target_compile_definitions may only set INTERFACE properties on IMPORTED targets * Fix version column in replicated version collapsing merge tree (#12121) * poco-cmake: Fix Poco::Data::ODBC target when UNBUNDLED By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? * Add missed <atomic> include in ProxyListConfiguration * Improve performace of reading in order of sorting key. (#11696) * simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test * Do not enable sentry if ENABLE_LIBRARIES is not set * Fail if curl library was enabled and was not found in case of unbundled build * Normalize "pid" file handling #3501 * Update StatusFile.cpp * New ISO8601 year modificators for formatDateTime * Added a test * Include libcurl4-openssl-dev into yandex/clickhouse-deb-builder * Remove harmful code from "geoDistance" #12117 * Update formatDateTime.cpp * Fix warnings from CodeQL * Added a test * Minor modification * Update libdivide to the latest master * Replace exit to abort in libdivide * Fix potential overflow in integer division #12119 * Added a test * Whitespace * Added a test for #4211 * Attempt to fix "Arcadia" build * Rename test * Update arraySum.cpp * Run perf tests with memory sampling (for allocations >1M) This is to know the memory allocation size distribution, that can be obtained later from left-metric-log.tsv. This is an attempt to tune tcmalloc (new CPP version by google) to use lock-free part of the allocator for typical allocations (and it is a bad idea just to increase kMaxSize there, since number of allocation for each size class is also important). P.S. hope that this file will be applied, if no, then the same effect can be reached by tunning defaults in Settings.h Refs: #11590 Cc: @akuzm * Make code clearer: use enum instead of `bool internal`. * Update StorageDictionary.h * Update StorageDictionary.h * ILIKE operator (#12125) * Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> * add parseDateTimeBestEffortUS function (#12028) * add function parseDateTimeBestEffortUS * add test * add doc Co-authored-by: alexey-milovidov <[email protected]> * Cleanup changelog (half done). Now it is acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Now it is more acceptable #12104 * Cleanup changelog (half done). Additions requested by @filimonov #12104 * Remove underscore as word-break character. This partially reverts #11975 * Fix bad test number * Added a test * Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty * fix segfault with -StateResample combinators * Fix bad code in redundant ORDER BY optimization #10067 * Add a test * Support KILL QUERY [connection_id] for MySQL * Fix error * Autocomplete does not have to work in "Unbundled" build * Whitespace * Add MySQL to ClickHouse query replacement mapping table * Style * update ya.make * Added function "hasThreadFuzzer" * Fix test under ThreadFuzzer * Test for issue #9088 ALTER DELETE unexpectedly deletes NULL rows * Remove unused potentially dangerous function * Fix mutations interpreter #9088 * Added a test * Added another test just in case * Added yet another test just in case * Update 01358_mutation_delete_null_rows.sql * Fix test * Fix flaky test * Attempt to fix flaky test 00721_force_by_identical_result_after_merge_zookeeper * [anchore] more detailed Dockerfile scan reports (#12159) * Update Dockerfile * Update array-functions.md (#12130) 修改编码错误 * Add integration test for mysql replacement query * Update array-functions.md (#12129) 修改编码错误 * fix ubsan final * [docs] improve redirects destination * Update SECURITY.md (#12161) * Update Dockerfile * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function (#12156) * add cluster() adn clusterAllReplicas() table functions description, add signatures to remoteSecure() table function Signed-off-by: Slach <[email protected]> * small russian fixes Signed-off-by: Slach <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> * Update docs/en/sql-reference/table-functions/cluster.md Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> * Remove -v from ninja * [docs] introduction for integration table engines (#12167) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * Fix #10437, CR fixes * Same change for Kafka - just in case, and to make it conform. * [docs] add redirect from an introduction index page (#12176) * [website] add apple-touch-icon (#12164) * Better assert * Don't split dictionary source's table name into schema and table name itself if ODBC driver doesn't support schema. * Sync reference file with changes in sql file * [docs] introduction for third-party interfaces (#12175) * [docs] introduction for third-party interfaces * Update index.md * Update index.md * [docs] introduction for special table engines (#12170) * [docs] introduction for integration table engines * Update jdbc.md * Update odbc.md * Update mysql.md * Update kafka.md * Update hdfs.md * [docs] introduction for special table engines * Update index.md * Update index.md Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Nicolae Vartolomei <[email protected]> Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: Ivan Blinkov <[email protected]> Co-authored-by: Alexander Kuzmenkov <[email protected]> Co-authored-by: Vladimir Chebotarev <[email protected]> Co-authored-by: filimonov <[email protected]> Co-authored-by: BayoNet <[email protected]> Co-authored-by: olgarev <[email protected]> Co-authored-by: Olga Revyakina <[email protected]> Co-authored-by: Sergei Shtykov <[email protected]> Co-authored-by: AsiaKorushkina <[email protected]> Co-authored-by: asiana21 <[email protected]> Co-authored-by: BohuTANG <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: zhang2014 <[email protected]> Co-authored-by: Evgenia Sudarikova <[email protected]> Co-authored-by: Alexander Kazakov <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: Azat Khuzhin <[email protected]> Co-authored-by: manmitya <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Mikhail Filimonov <[email protected]> Co-authored-by: Guillaume Tassery <[email protected]> Co-authored-by: Anton Ivashkin <[email protected]> Co-authored-by: Ilya Yatsishin <[email protected]> Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Matwey V. Kornilov <[email protected]> Co-authored-by: vivarum <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: myrrc <[email protected]> Co-authored-by: flynn <[email protected]> Co-authored-by: yhgcn <[email protected]> Co-authored-by: Eugene Klimov <[email protected]>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md)
Make more input format work with Kafka engine. Fix the issue with premature flushes. Fix the performance issue when
kafka_num_consumersis greater than number of partitions in topic.Detailed description / Documentation draft:
next()call were bypassing PeekableReadBuffer and it was confused by state change of underlying buffer. Also I've added state resetting to some formats. Because it required to check theeofanother way - i've splitpoll/nextImpl, and did some refactoring. Closes 20.5 Kafka + JSONAsString = assert fail in PeekableReadBuffer::checkStateCorrect #11514 /cc @AvogarMAX_FAILED_POLL_ATTEMPTS(10) reties. Closes Kafka premature flush when reaching end of partition #11216