Add ORCBlockOutputFormat#11662
Add ORCBlockOutputFormat#11662nikitamikhaylov merged 21 commits intoClickHouse:masterfrom Avogar:orc_output_format
Conversation
|
I forgot to add include path in cmake, I'l add it later |
nikitamikhaylov
left a comment
nikitamikhaylov
left a comment
There was a problem hiding this comment.
Please write more comments and add performance test (just include ORC format into existing tests of formats).
| number_orc_column->notNull[i] = 0; | ||
| continue; | ||
| } | ||
| if constexpr (std::is_same<NumberType, UInt8>::value) |
There was a problem hiding this comment.
I think it is dirty hack :) Please write comment about this special case.
There was a problem hiding this comment.
And it doesn't work https://clickhouse-builds.s3.yandex.net/11662/717f63923a19b9a4b0932e6295ed60d3753e7009/build_log_707272824_1592914485.txt
Maybe add Int8 to if statement?
src/CMakeLists.txt
Outdated
|
|
||
| target_include_directories (clickhouse_common_io SYSTEM BEFORE PUBLIC ${MSGPACK_INCLUDE_DIR}) | ||
|
|
||
| target_include_directories (clickhouse_common_io SYSTEM BEFORE PUBLIC ${ORC_INCLUDE_DIR}) |
There was a problem hiding this comment.
Maybe better to write it under if (USE_ORC) statement?
| } | ||
|
|
||
| template <typename ColumnType, typename GetSecondsFunc, typename GetNanosecondsFunc> | ||
| void ORCBlockOutputFormat::ORCBlockOutputFormat::writeDateTimes( |
There was a problem hiding this comment.
Double ORCBlockOutputFormat::ORCBlockOutputFormat ?
|
@nikitamikhaylov can you help? I can't understand what is wrong with Functional stateless tests (unbundled) and Performance test. They don't see ORC output format. |
I will help, of course. But there is another strange error with clang-tidy build... Which I don’t know how to fix. |
…_orc_output_format
|
Tests |
robot-clickhouse
added
the
submodule changed
|
Build failure is caused by internal CI problem. |
5 participants
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add ORCBlockOutputFormat
Detailed description / Documentation draft:
ORC output format
This output format writes data in orc format.