max_thread_pool_size setting for changing max Threads in Global Thread Pool#11668
Merged
akuzm merged 11 commits intoClickHouse:masterfrom Jun 24, 2020
bharatnc:bnc/config-max-num-threads
Merged
max_thread_pool_size setting for changing max Threads in Global Thread Pool#11668akuzm merged 11 commits intoClickHouse:masterfrom bharatnc:bnc/config-max-num-threads
akuzm merged 11 commits intoClickHouse:masterfrom
bharatnc:bnc/config-max-num-threads
Conversation
This PR adds a server level config for overriding the default max number of threads in global thread pool that is currently allowed (10,000). This might be useful in scenarios where there are a large number of distributed queries that are executing concurrently and where the default number of max threads might not be necessarily be sufficient.
This adds the `max_thread_pool_size` config to tests/server-test.xml file.
This adds the docs for the new server level setting `max_thread_pool_size`.
Contributor
Author
|
Can't seem to find the reason why |
akuzm
approved these changes
Jun 19, 2020
Member
|
It's not false-positive, test fails because there is no instance of |
Contributor
Author
|
Thank you @akuzm for your help with fixing the failing test. |
Contributor
You're welcome. 'Yandex third-party checks' are broken for a different reason, will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
max_thread_pool_sizeconfig for changing the maximum number of Threads in Global Thread Pool.Detailed description / Documentation draft:
This PR makes the maximum number of threads in the Global Thread Pool configurable. Currently this value defaults to 10000 and is being set inside
ThreadPool.cpp.The setting for this option is
max_thread_pool_sizeand is being added to theconfig.xmlfile and is loaded while returning a GlobalThreadPool instance.Also adds the configuration to relevant tests and docs (en) have also been added.
Addresses the issue: #7099