Switched paths in S3 metadata to relative#11892
Merged
Akazz merged 1 commit intoClickHouse:masterfrom Jul 6, 2020
excitoon-favorites:relatives3paths
Merged
Switched paths in S3 metadata to relative#11892Akazz merged 1 commit intoClickHouse:masterfrom excitoon-favorites:relatives3paths
Akazz merged 1 commit intoClickHouse:masterfrom
excitoon-favorites:relatives3paths
Conversation
Akazz
reviewed
Jul 6, 2020
Contributor
Akazz
left a comment
Akazz
left a comment
There was a problem hiding this comment.
This changeset looks okay in general.
Although you might want to improve Metadata class in the future: to entirely encapsulate s3_root and return objectIds (which are simply random numbers) from addObject(). This way the class would be semantically more consistent and so you do not need to worry about generating names outside.
P.S. It looks like WriteIndirectBufferFromS3::finalize() is not exception-safe and can leak remote blob space (if metadata.save() fails). Perhaps it is worth putting a comment/TODO in about it.
Contributor
|
Performance tests failures seem unrelated completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Switched paths in S3 metadata to relative which allows to handle S3 blobs more easily.