Change MySQL global variables query to globalVariable function#11901
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Jun 25, 2020
Merged
Change MySQL global variables query to globalVariable function#11901alexey-milovidov merged 6 commits intoClickHouse:masterfrom
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
Conversation
bohutang
force-pushed
the
mysql_global_variables
branch
from
de3378d to
4d96a25
Compare
Contributor
Author
|
CC @alexey-milovidov |
| { | ||
| if (!checkColumnConst<ColumnString>(arguments[0].column.get())) | ||
| throw Exception("Agrument of function " + getName() + " must be constant string", ErrorCodes::BAD_ARGUMENTS); | ||
| throw Exception("Argument of function " + getName() + " must be constant string", ErrorCodes::BAD_ARGUMENTS); |
alexey-milovidov
approved these changes
Jun 24, 2020
Member
|
Also please look at #11089 |
bohutang
changed the title
Contributor
Author
Done |
|
sorry for jumping this thread, is possible add mysql "connection_id()" fake function in this stage? |
Contributor
Author
This patch is about global variables, connection_id() is function. |
Member
|
Flaky test is reported in #11815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Deprecate the old regular style and use the new globalVariable method #11832