remove unused headers#11922
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jun 24, 2020
bharatnc:ncb/remove-unused-headers
Merged
remove unused headers#11922alexey-milovidov merged 2 commits intoClickHouse:masterfrom bharatnc:ncb/remove-unused-headers
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
bharatnc:ncb/remove-unused-headers
Conversation
The following files had some unused headers and caught my eyes, so cleaning them up: ```bash programs/obfuscator/Obfuscator.cpp src/Databases/DatabaseAtomic.cpp ```
alexey-milovidov
approved these changes
Jun 24, 2020
Member
|
Ok. BTW, how did you find these unused headers? |
Contributor
Author
I use CLion and it does a pretty good job of giving me hints on unused headers in a file. I found them randomly while I was going through some code similar to how I found a few others in #11660. I will also know for sure if CLion is correct this time when all these tests pass! |
Member
|
Builds Ok, merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Clean up unused header files from
Obfuscator.cppandDatabaseAtomic.cppDetailed description / Documentation draft:
Noticed that the following files had some unused headers, so
cleaning them up: