Allow to perform "metadata-only" ALTER of partition key.#11973
Merged
Allow to perform "metadata-only" ALTER of partition key.#11973
Conversation
filimonov
reviewed
Jun 26, 2020
alesapin
reviewed
Jun 26, 2020
Member
Author
Broken in #11903 |
alexey-milovidov
force-pushed
the
alter-enum-partition-key
branch
from
8e46771 to
d429ead
Compare
alesapin
approved these changes
Jun 29, 2020
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
LGTM. Also, we have a check for partition key in ReplicatedMergeTreeMetadata, but it verifies only column names, without types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow to perform "metadata-only" ALTER of partition key such as adding more elements to Enum data type. This fixes #7513.
Details:
This feature was discussed on ClickHouse Meetup online on Jun 18.