ISSUES-3985 Support MySQL engine reading Enums type#11996
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Jun 27, 2020
Merged
ISSUES-3985 Support MySQL engine reading Enums type#11996alexey-milovidov merged 3 commits intoClickHouse:masterfrom
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
bohutang
changed the title
| node1.query(''' | ||
| CREATE TABLE {}(id UInt32, name String, age UInt32, money UInt32, source Enum8('IP' = 1, 'URL' = 2)) ENGINE = MySQL('mysql1:3306', 'clickhouse', '{}', 'root', 'clickhouse', 1); | ||
| '''.format(table_name, table_name)) | ||
| node1.query("INSERT INTO {}(id, name, age, money) VALUES (1,'name',0, 0)".format(table_name)) |
Member
There was a problem hiding this comment.
Is it possible to INSERT source (enum column)?
alexey-milovidov
approved these changes
Jun 27, 2020
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
Ok.
BTW, we can also convert Enum to Enum, it will be more efficient. But it's not needed in this PR.
Contributor
Author
|
Yes. |
Contributor
Author
|
BTW, thanks for giving 'can be tested' free pass. |
Member
Broken in #11903 |
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support MySQL engine reading Enums type #3985