Skip to content

Fix calculation of access rights when allow_introspection_functions = 0#12031

Merged
vitlibar merged 2 commits intoClickHouse:masterfrom
vitlibar:fix-access-rights-if-allow_introspection_functions-is-0
Jun 30, 2020
Merged

Fix calculation of access rights when allow_introspection_functions = 0#12031
vitlibar merged 2 commits intoClickHouse:masterfrom
vitlibar:fix-access-rights-if-allow_introspection_functions-is-0

Conversation

@vitlibar
Copy link
Member

@vitlibar vitlibar commented Jun 29, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Bug Fix

Changelog entry:
Fix calculation of access rights when allow_introspection_functions=0

@blinkov blinkov added the pr-bugfix Pull request with bugfix, not backported by default label Jun 29, 2020
@abyss7 abyss7 self-assigned this Jun 29, 2020
abyss7
abyss7 reviewed Jun 29, 2020
View reviewed changes
tests/integration/test_settings_profile/test.py Outdated
Copy link
Contributor

@abyss7 abyss7 Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you shrinked the test that much? Why don't you test previous scenarios?

Copy link
Member Author

@vitlibar vitlibar Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good point. I've changed the test to keep some of the previous checks.

@vitlibar vitlibar force-pushed the fix-access-rights-if-allow_introspection_functions-is-0 branch 2 times, most recently from ac764e5 to 7efe22c Compare June 29, 2020 17:49
@vitlibar vitlibar force-pushed the fix-access-rights-if-allow_introspection_functions-is-0 branch from 7efe22c to ace9c99 Compare June 30, 2020 09:20
@vitlibar vitlibar merged commit 40942a2 into ClickHouse:master Jun 30, 2020
@vitlibar vitlibar deleted the fix-access-rights-if-allow_introspection_functions-is-0 branch June 30, 2020 15:32
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2020
Merged
robot-clickhouse added a commit that referenced this pull request Jul 7, 2020
@robot-clickhouse
Merge pull request #12229 from ClickHouse/cherrypick/20.5/40942a2164e…
571e77a 
…7d0d4fef55460348906d87e5a2d32

Cherry pick #12031 to 20.5: Fix calculation of access rights when allow_introspection_functions = 0
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2020
Closed
alesapin pushed a commit that referenced this pull request Jul 10, 2020
@alesapin
Merge pull request #12031 from vitlibar/fix-access-rights-if-allow_in…
47ce21d 
…trospection_functions-is-0

Fix calculation of access rights when allow_introspection_functions = 0

(cherry picked from commit 40942a2)
vitlibar pushed a commit that referenced this pull request Aug 5, 2020
Merge pull request #12031 from vitlibar/fix-access-rights-if-allow_in…
9bdb371 
…trospection_functions-is-0

Fix calculation of access rights when allow_introspection_functions = 0

(cherry picked from commit 40942a2)
@bgranvea
Copy link
Contributor

bgranvea commented Aug 18, 2020

does this PR fix this kind of errors?

GRANT ALL ON xxx.* TO yyyy
Clickhouse error when executing command: Code: 446, Message: default: Introspection functions are disabled

(with Clickhouse 20.6.3.28)

@vitlibar
Copy link
Member Author

vitlibar commented Aug 18, 2020 •
edited
Loading

does this PR fix this kind of errors?

GRANT ALL ON xxx.* TO yyyy
Clickhouse error when executing command: Code: 446, Message: default: Introspection functions are disabled

(with Clickhouse 20.6.3.28)

No, it hasn't fixed yet.
To use the ALL keyword while you're granting privileges you should set allow_introspection_functions=1 (because all privileges include INTROSPECTION). For now you can either set allow_introspection_functions=1 for the user who grants access rights or use a statement like GRANT SELECT, INSERT, ... instead of GRANT ALL.

@vitlibar
Copy link
Member Author

vitlibar commented Aug 24, 2020

does this PR fix this kind of errors?

GRANT ALL ON xxx.* TO yyyy
Clickhouse error when executing command: Code: 446, Message: default: Introspection functions are disabled

(with Clickhouse 20.6.3.28)

I'm fixing that error in #13987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abyss7 abyss7 abyss7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abyss7 abyss7

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vitlibar @bgranvea @abyss7 @blinkov @alesapin