Skip to content

Parse metadata in parallel when loading tables#12045

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix_loading_of_tables
Jun 30, 2020
Merged

Parse metadata in parallel when loading tables#12045
alexey-milovidov merged 1 commit intomasterfrom
fix_loading_of_tables

Conversation

@tavplubix
Copy link
Member

@tavplubix tavplubix commented Jun 30, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Parse tables metadata in parallel when loading database. This fixes slow server startup when there are large number of tables.

Fixes #11943

@blinkov blinkov added the pr-improvement Pull request with some product improvements label Jun 30, 2020
wait

$CLICKHOUSE_CLIENT -q "CREATE TABLE $db.table_merge (i UInt64, d Date, s String, n Nested(i UInt8, f Float32)) ENGINE=Merge('$db', '^table_')"
#FIXME the following query leads to segfault
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create an issue about that?

@alexey-milovidov alexey-milovidov self-assigned this Jun 30, 2020
@tavplubix
Copy link
Member Author

00738_lock_for_inner_table - seems not related, added to CI Fest

@alexey-milovidov
Copy link
Member

Ok, though I did not see this test before as flaky.

@alexey-milovidov alexey-milovidov merged commit 948af0b into master Jun 30, 2020
@alexey-milovidov alexey-milovidov deleted the fix_loading_of_tables branch June 30, 2020 18:16
@tavplubix tavplubix added pr-bugfix Pull request with bugfix, not backported by default and removed pr-improvement Pull request with some product improvements labels Jul 2, 2020
tavplubix pushed a commit that referenced this pull request Jul 6, 2020
Parse metadata in parallel when loading tables

(cherry picked from commit 948af0b)
tavplubix pushed a commit that referenced this pull request Jul 7, 2020
alexey-milovidov pushed a commit that referenced this pull request Jul 7, 2020
…ables (#12233)

Co-authored-by: Alexander Tokmakov <avtokmakov@sandbox-407922969>
alesapin pushed a commit that referenced this pull request Jul 10, 2020
Parse metadata in parallel when loading tables

(cherry picked from commit 948af0b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading of tables is not parallel in version 20.1+

4 participants