Skip to content

max_rows_to_read remove note about 'applied on each thread separately'#12070

Merged
qoega merged 4 commits intomasterfrom
filimonov-max_rows_to_read-threads
Jul 3, 2020
Merged

max_rows_to_read remove note about 'applied on each thread separately'#12070
qoega merged 4 commits intomasterfrom
filimonov-max_rows_to_read-threads

Conversation

@filimonov
Copy link
Contributor

Remove a note about read limits applied on threads level.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Detailed description / Documentation draft:
That sentence is wrong and leads to misunderstandings.

SET max_rows_to_read = 100, max_block_size = 24, read_overflow_mode = 'break', max_threads = 32;

Ok.

0 rows in set. Elapsed: 0.001 sec. 

SELECT 
    blockNumber() AS b, 
    count()
FROM system.numbers_mt
GROUP BY b
    WITH TOTALS

┌──b─┬─count()─┐
│ 36 │      24 │
│ 35 │      24 │
│ 34 │      24 │
│ 33 │      24 │
└────┴─────────┘

Totals:
┌─b─┬─count()─┐
│ 0 │      96 │
└───┴─────────┘

4 rows in set. Elapsed: 0.006 sec. 

@blinkov blinkov added the pr-documentation Documentation PRs for the specific code PR label Jul 1, 2020
@qoega qoega merged commit 5a4d9fb into master Jul 3, 2020
@qoega qoega deleted the filimonov-max_rows_to_read-threads branch July 3, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-documentation Documentation PRs for the specific code PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants