Move skip lists for tests to skip_list.json file#12107
Conversation
|
No builds :( |
alesapin
changed the title
| UNDEFINED = 'ub-sanitizer' | ||
| MEMORY = 'memory-sanitizer' | ||
| DEBUG = 'debug-build' | ||
| UNBUNDLED = 'unbundled-build' |
There was a problem hiding this comment.
BTW, maybe it's also possible to add ARCADIA.
There was a problem hiding this comment.
Otherwise we will have separate skip list in different format for ARCADIA.
(we can do it in another PR)
There was a problem hiding this comment.
let's do it in another PR.
| @@ -0,0 +1,130 @@ | |||
| { | |||
There was a problem hiding this comment.
It's is a pity that JSON does not support comments.
(but it's Ok, I cannot propose something better).
There was a problem hiding this comment.
Maybe Python can parse JSON extension with comments?
There was a problem hiding this comment.
No vanilla python json module doesn't support comments in JSON :( Also it's possible to move this list into clickhouse-test script or separate .py file and receive config with eval or exec.
There was a problem hiding this comment.
Looks like the recommended way to support comments in JSON with Python is JSMin:
https://pypi.org/project/jsmin/
3 participants
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add
UNBUNDLEDflag tosystem.build_optionstable. Move skip lists forclickhouse-testto clickhouse repo.