Skip to content

Minor cmake fixes for UNBUNDLED build#12131

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
matwey:fix/cmake_unixodbc
Jul 4, 2020
Merged

Minor cmake fixes for UNBUNDLED build#12131
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
matwey:fix/cmake_unixodbc

Conversation

@matwey
Copy link
Contributor

@matwey matwey commented Jul 4, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Minor CMake fixes for UNBUNDLED build.

matwey added 2 commits July 4, 2020 10:21
target_compile_definitions may only set INTERFACE properties on IMPORTED targets
By default IMPORTED target has a scope in the directory in which it is created
and below. This leads to the following issues when building UNBUNDLED:

Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not
found.  Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
@blinkov blinkov added the pr-build Pull request with build/testing/packaging improvement label Jul 4, 2020
@alexey-milovidov alexey-milovidov requested a review from abyss7 July 4, 2020 12:32
@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Jul 4, 2020
@alexey-milovidov alexey-milovidov self-assigned this Jul 4, 2020
@alexey-milovidov alexey-milovidov merged commit 6ae9bfe into ClickHouse:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants