Skip to content

Add missed <atomic> include in ProxyListConfiguration#12134

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
matwey:fix/missed_include
Jul 5, 2020
Merged

Add missed <atomic> include in ProxyListConfiguration#12134
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
matwey:fix/missed_include

Conversation

@matwey
Copy link
Contributor

@matwey matwey commented Jul 4, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Missed <atomic> is required for std::atomic<>.

@blinkov blinkov added the pr-build Pull request with build/testing/packaging improvement label Jul 4, 2020
@alexey-milovidov alexey-milovidov self-assigned this Jul 4, 2020
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jul 5, 2020

Split build:

Executing cmd: 'docker run --network=host --volume=/place/sandbox-data/tasks/4/5/716107354/clang-10_relwithdebuginfo_none_bundled_splitted_disable_False_binary:/package_folder --volume=/place/sandbox-data/tasks/5/0/716112705/server_log:/var/log/clickhouse-server yandex/clickhouse-split-build-smoke-test:latest >/place/sandbox-data/tasks/5/0/716112705/test_output/result.log'
Unable to find image 'yandex/clickhouse-split-build-smoke-test:latest' locally
docker: Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers).
See 'docker run --help'.

@alexey-milovidov alexey-milovidov merged commit c257255 into ClickHouse:master Jul 5, 2020
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jul 5, 2020

Network issue when connecting to Docker registry.

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 5, 2020
Closed
16 tasks
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 15, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

no-docs-needed pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matwey @alexey-milovidov @blinkov @qoega