Skip to content

New ISO8601 year modificators for formatDateTime() function#12136

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
vivarum:vivarum-04659-new-ISO8601-year-modificators-for-formatDateTime
Jul 5, 2020
Merged

New ISO8601 year modificators for formatDateTime() function#12136
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
vivarum:vivarum-04659-new-ISO8601-year-modificators-for-formatDateTime

Conversation

@vivarum
Copy link
Contributor

@vivarum vivarum commented Jul 4, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added support for %g (two digit ISO year) and %G (four digit ISO year) substitutions in formatDateTime function.

@alexey-milovidov alexey-milovidov self-assigned this Jul 4, 2020
@blinkov blinkov added the pr-improvement Pull request with some product improvements label Jul 4, 2020
@alexey-milovidov
Copy link
Member

I've added NOLINT to skip clang-tidy check about function names.

@alexey-milovidov
Copy link
Member

Yandex synchronization check (only for Yandex employees)

Our collegues has found a bug in this check. Actually everything is Ok, will merge.

@alexey-milovidov alexey-milovidov merged commit c08e24d into ClickHouse:master Jul 5, 2020
@AnaUvarova
Copy link
Contributor

Hi, please help me understand what is the difference between %y, %Y and %g, %G?

@alexey-milovidov
Copy link
Member

https://en.wikipedia.org/wiki/ISO_week_date#Relation_with_the_Gregorian_calendar

@AnaUvarova
Copy link
Contributor

@vivarum Hi! Could you please share some cases of usage for this function?

@vivarum
Copy link
Contributor Author

vivarum commented Oct 7, 2020

@vivarum Hi! Could you please share some cases of usage for this function?

You can have a look on the original issue, probably it can give some background: #4023

@AnaUvarova
Copy link
Contributor

@vivarum Hi! Could you please share some cases of usage for this function?

You can have a look on the original issue, probably it can give some background: #4023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants