Exclude partition key columns from SummingMergeTree #12173
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Jul 7, 2020
Merged
Exclude partition key columns from SummingMergeTree #12173alexey-milovidov merged 3 commits intoClickHouse:masterfrom
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
| case MergeTreeData::MergingParams::Summing: | ||
| return std::make_shared<SummingSortedTransform>(header, pipes.size(), | ||
| sort_description, data.merging_params.columns_to_sum, max_block_size); | ||
| sort_description, data.merging_params.columns_to_sum, partition_key_columns, max_block_size); |
Member
There was a problem hiding this comment.
We also need a test with SELECT FINAL?
alexey-milovidov
added a commit
that referenced
this pull request
Jul 12, 2020
…40e62ee261882363efdceea5b60a3 Cherry pick #12173 to 20.5: Exclude partition key columns from SummingMergeTree
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12173 to 20.5: Exclude partition key columns from SummingMergeTree
abyss7
added a commit
that referenced
this pull request
Jul 31, 2020
…ummingMergeTree" This reverts commit f3f5ae3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the behaviour when
SummingMergeTreeengine sums up columns from partition key. Added an exception in case of explicit definition of columns to sum which intersects with partition key columns. This fixes #7867