Backport #12140 to 20.5: Fix potential overflow in integer division#12248
Merged
alexey-milovidov merged 748 commits into20.5from Jul 7, 2020
Merged
Backport #12140 to 20.5: Fix potential overflow in integer division#12248alexey-milovidov merged 748 commits into20.5from
alexey-milovidov merged 748 commits into20.5from
Conversation
client exit with unrecognized arguments
…flow-generate-random
Revert "[experiment] maybe fix warnings in integration tests"
…erate-random Fix array size overflow in generateRandom
Avoid floating point error in geohashesInBox #11369
Added a showcase of minimal Docker image
Normalize "pid" file handling #3501
Minor cmake fixes for UNBUNDLED build
Fix Parquet for LowCardinality
Fix result_rows and result_bytes metrics for selects.
Check wrong type for filter.
Add type column in system.disks
Add missed <atomic> include in ProxyListConfiguration
Remove harmful code from "geoDistance"
…m-tries Added a test for #4211
Fix warnings from CodeQL
* Integrated CachingAllocator into MarkCache * fixed build errors * reset func hotfix * upd: Fixing build * updated submodules links * fix 2 * updating grabber allocator proto * updating lost work * updating CMake to use concepts * some other changes to get it building (integration into MarkCache) * further integration into caches * updated Async metrics, fixed some build errors * and some other errors revealing * added perfect forwarding to some functions * fix: forward template * fix: constexpr modifier * fix: FakePODAllocator missing member func * updated PODArray constructor taking alloc params * fix: PODArray overload with n restored * fix: FakePODAlloc duplicating alloc() func * added constexpr variable for alloc_tag_t * split cache values by allocators, provided updates * fix: memcpy * fix: constexpr modifier * fix: noexcept modifier * fix: alloc_tag_t for PODArray constructor * fix: PODArray copy ctor with different alloc * fix: resize() signature * updating to lastest working master * syncing with 273267 * first draft version * fix: update Searcher to case-insensitive * added ILIKE test * fixed style errors, updated test, split like and ilike, added notILike * replaced inconsistent comments * fixed show tables ilike * updated missing test cases * regenerated ya.make * Update 01355_ilike.sql Co-authored-by: myrrc <[email protected]> Co-authored-by: alexey-milovidov <[email protected]>
Fix potential overflow in integer division
…26a188209ceac51f708f0ba329f53 Cherry pick #12140 to 20.5: Fix potential overflow in integer division
robot-clickhouse
added
the
pr-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #12140
Cherry-pick pull-request #12221
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.