Fix rare hanging in DNSResolver#12296
Merged
alexey-milovidov merged 1 commit intomasterfrom Jul 8, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Jul 8, 2020
tavplubix
added a commit
that referenced
this pull request
Jul 9, 2020
tavplubix
added a commit
that referenced
this pull request
Jul 9, 2020
Co-authored-by: Alexander Tokmakov <[email protected]>
This was referenced Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Some threads might randomly hang for a few seconds during DNS cache updating. It's fixed.
Detailed description / Documentation draft:
OwnSplitChannel::logSplit(...)callsDNSResolver::getHostName()and may wait onDNSResolver::Impl::drop_mutex, whileDNSResolver::updateCache()callsgethostname(...)holding the mutex.