Skip to content

Log sanitizer trap messages from separate thread#12313

Merged
alexey-milovidov merged 3 commits intomasterfrom
sanitizer-trap-log-from-separate-thread
Jul 9, 2020
Merged

Log sanitizer trap messages from separate thread#12313
alexey-milovidov merged 3 commits intomasterfrom
sanitizer-trap-log-from-separate-thread

Conversation

@alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Jul 9, 2020

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Log sanitizer trap messages from separate thread. This will prevent possible deadlock under thread sanitizer.

+ minor Sentry refactoring.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Jul 9, 2020
@alexey-milovidov
Copy link
Member Author

Tested manually.

@alexey-milovidov alexey-milovidov marked this pull request as draft July 9, 2020 04:08
@alexey-milovidov alexey-milovidov marked this pull request as ready for review July 9, 2020 04:47
@alexey-milovidov
Copy link
Member Author

TSan report, fix: #12315

@alexey-milovidov alexey-milovidov merged commit bb5247e into master Jul 9, 2020
@alexey-milovidov alexey-milovidov deleted the sanitizer-trap-log-from-separate-thread branch July 9, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants