Skip to content

Fix obvious race condition in test#12336

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-obvious-race-condition-in-test
Jul 9, 2020
Merged

Fix obvious race condition in test#12336
alexey-milovidov merged 1 commit intomasterfrom
fix-obvious-race-condition-in-test

Conversation

@alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@alexey-milovidov alexey-milovidov added the testing Special issue with list of bugs found by CI label Jul 9, 2020
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 9, 2020
16 tasks
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 9, 2020
@alexey-milovidov
Copy link
Member Author

alexey-milovidov commented Jul 9, 2020

We were doing SELECT from replica just after INSERT without quorum.
But replication is quick enough (faster than tens of ms needed to run clickhouse-client) and the race condition in test only reproduces once in a few days.

@alexey-milovidov alexey-milovidov merged commit 7799dc2 into master Jul 9, 2020
@alexey-milovidov alexey-milovidov deleted the fix-obvious-race-condition-in-test branch July 9, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog testing Special issue with list of bugs found by CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants