Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments#12376
Merged
alexey-milovidov merged 4 commits intomasterfrom Jul 10, 2020
Merged
Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments#12376alexey-milovidov merged 4 commits intomasterfrom
alexey-milovidov merged 4 commits intomasterfrom
Conversation
Member
Author
|
This also wrong: |
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
force-pushed
the
fix-totals-state-2
branch
from
af8fbd0 to
42a9449
Compare
alexey-milovidov
force-pushed
the
fix-totals-state-2
branch
from
42a9449 to
12e0041
Compare
Member
Author
|
I recommend @akuzm @KochetovNicolai @CurtizJ just to take a look - this is a really weird issue in managing of aggregation states. |
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
…ns with -State and Nullable arguments
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12376 to 20.5: Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
…ns with -State and Nullable arguments
alexey-milovidov
added a commit
that referenced
this pull request
Jul 28, 2020
Backport #12376 to 20.3: Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments
abyss7
added a commit
that referenced
this pull request
Jul 31, 2020
… functions with -State and Nullable arguments" This reverts commit 84f8d48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix TOTALS/ROLLUP/CUBE for aggregate functions with
-StateandNullablearguments. This fixes #12163.