Skip to content

output_format_json_quote_64bit_integers new config option [#METR-22950]#126

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
ludv1x:METR-22950
Sep 30, 2016
Merged

output_format_json_quote_64bit_integers new config option [#METR-22950]#126
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
ludv1x:METR-22950

Conversation

@ludv1x
Copy link
Contributor

@ludv1x ludv1x commented Sep 30, 2016

No description provided.

@ludv1x ludv1x changed the title output_format_json_quote_64bit_integers new config option output_format_json_quote_64bit_integers new config option [#METR-22950] Sep 30, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let rename force_quoting to force_quoting_64bit_integers everywhere.
Because otherwise developers may think that it will quote all data types (or all numbers).
Long name is no problem.

Copy link
Contributor Author

@ludv1x ludv1x Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, parameter with such name is too specific for interface function.
However, I don't have any other suggestions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that specific name is Ok.

@alexey-milovidov alexey-milovidov merged commit 6f3e69c into ClickHouse:master Sep 30, 2016
@ludv1x ludv1x deleted the METR-22950 branch October 1, 2016 11:34
@ludv1x ludv1x restored the METR-22950 branch October 4, 2016 16:05
blinkov pushed a commit that referenced this pull request Jun 17, 2020
…#126) (#11738)

* literacy checking

* ru translation

* Update docs/ru/interfaces/http.md

Co-authored-by: BayoNet <[email protected]>

* Update docs/ru/interfaces/http.md

Co-authored-by: BayoNet <[email protected]>

* Update docs/ru/interfaces/http.md

Co-authored-by: BayoNet <[email protected]>

* Update docs/ru/interfaces/http.md

Co-authored-by: BayoNet <[email protected]>

* Update http.md

* Update http.md

Co-authored-by: Anna Devyatova <[email protected]>
Co-authored-by: BayoNet <[email protected]>

Co-authored-by: Sergei Shtykov <[email protected]>
Co-authored-by: Anna <[email protected]>
Co-authored-by: Anna Devyatova <[email protected]>
tonickkozlov pushed a commit to tonickkozlov/ClickHouse that referenced this pull request Apr 6, 2022
Merge in PLAT/clickhouse from shaynes/clickhouse-1287-pin-pandas to cf/master

* commit '3f13271c02701a1187f9e78f5cc0b9895b07928d':
  Pin Pandas version for lts branch; 1.3 already requires python-dev
  Switch to internal llvm mirror
lgbo-ustc added a commit to bigo-sg/ClickHouse that referenced this pull request Sep 16, 2022
fuwhu pushed a commit to fuwhu/ClickHouse that referenced this pull request Feb 12, 2026
fuwhu pushed a commit to fuwhu/ClickHouse that referenced this pull request Feb 12, 2026
[ClickHouse#126]fix connection drain problem caused by remote query timeout

See merge request datacenter/clickhouse!481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants